Fix indexing with zero-size arrays (#124)

Author: Keno

src/broadcast.jl

@@ -53,7 +53,7 @@ end
     newsize = tuple(newsize...)
 
     exprs = Array{Expr}(newsize)
-    more = true
+    more = newsize[1] != 0
     current_ind = ones(Int, length(newsize))
 
     while more
@@ -116,7 +116,7 @@ end
 
     exprs = Array{Expr}(newsize)
     j = 1
-    more = true
+    more = newsize[1] != 0
     current_ind = ones(Int, max(length(newsize), length.(sizes)...))
     while more
         exprs_vals = [(a[i] <: Number ? :(a[$i]) : :(a[$i][$(broadcasted_index(sizes[i], current_ind))])) for i = 1:length(sizes)]

src/indexing.jl

@@ -133,7 +133,7 @@ end
     # Iterate over input indices
     ind_types = inds.parameters
     current_ind = ones(Int,length(linearsizes))
-    more = true
+    more = linearsizes[1] != 0
     while more
         exprs_tmp = [_ind(i, current_ind[i], ind_types[i]) for i = 1:length(linearsizes)]
         exprs[current_ind...] = :(getindex(a, $(exprs_tmp...)))
@@ -203,6 +203,14 @@ end
 end
 
 # disambiguities from Base
+@propagate_inbounds function setindex!(a::Array, value, i1::StaticVector{Int})
+    _setindex!(a, value, index_sizes(i1), (i1,))
+end
+
+@propagate_inbounds function setindex!(a::Array, value::AbstractArray, i1::StaticVector{Int})
+    _setindex!(a, value, index_sizes(i1), (i1,))
+end
+
 @propagate_inbounds function setindex!(a::Array, value::AbstractArray, i1::StaticArray{Int}, inds::Union{Int, StaticArray{Int}}...)
     _setindex!(a, value, index_sizes(i1, inds...), (i1, inds...))
 end
@@ -227,7 +235,7 @@ end
     # Iterate over input indices
     ind_types = inds.parameters
     current_ind = ones(Int,length(ind_types))
-    more = true
+    more = linearsizes[1] != 0
     while more
         exprs_tmp = [_ind(i, current_ind[i], ind_types[i]) for i = 1:length(ind_types)]
         exprs[current_ind...] = :(setindex!(a, value, $(exprs_tmp...)))

test/indexing.jl

@@ -93,4 +93,12 @@
         @test (ma[2,1,1,1] = 48; ma[2,1,1,1] === 48)
     end
 
+    @testset "Indexing with empty vectors" begin
+        a = randn(2,2)
+        @test a[SVector{0,Int}()] == SVector{0,Float64}(())
+        @test a[SVector{0,Int}(),SVector{0,Int}()] == SMatrix{0,0,Float64,0}(())
+        b = copy(a)
+        a[SVector{0,Int}()] = 5.0
+        @test b == a
+    end
 end

test/mapreduce.jl

@@ -74,5 +74,7 @@
         @test mm == @MMatrix [3 4; 7 8; 11 12; 15 16]
         # issue #103
         @test map(+, M, M) == [2 4; 6 8; 10 12; 14 16]
+        
+        @test ((@SVector Int64[]) + (@SVector Int64[])) == (@SVector Int64[])
     end
 end