Merge pull request #432 from rdeits/isbitstype

isbits -> isbitstype

Author: andyferris

REQUIRE

@@ -1,2 +1,2 @@
 julia 0.6.0
-Compat 0.59
+Compat 0.66

src/MArray.jl

@@ -97,12 +97,12 @@ end
     end
 
     T = eltype(v)
-    if isbits(T)
+    if isbitstype(T)
         unsafe_store!(Base.unsafe_convert(Ptr{T}, pointer_from_objref(v)), convert(T, val), i)
     else
         # This one is unsafe (#27)
         # unsafe_store!(Base.unsafe_convert(Ptr{Ptr{Nothing}}, pointer_from_objref(v.data)), pointer_from_objref(val), i)
-        error("setindex!() with non-isbits eltype is not supported by StaticArrays. Consider using SizedArray.")
+        error("setindex!() with non-isbitstype eltype is not supported by StaticArrays. Consider using SizedArray.")
     end
 
     return val

src/MMatrix.jl

@@ -73,7 +73,7 @@ end
     #end
 
     # This is nasty... but it turns out Julia will literally copy the whole tuple to the stack otherwise!
-    if isbits(T)
+    if isbitstype(T)
         unsafe_load(Base.unsafe_convert(Ptr{T}, pointer_from_objref(m)), i)
     else
         # Not sure about this... slow option for now...
@@ -88,12 +88,12 @@ end
     #    throw(BoundsError(m,i))
     #end
 
-    if isbits(T)
+    if isbitstype(T)
         unsafe_store!(Base.unsafe_convert(Ptr{T}, pointer_from_objref(m)), val, i)
     else # TODO check that this isn't crazy. Also, check it doesn't cause problems with GC...
         # This one is unsafe (#27)
         # unsafe_store!(Base.unsafe_convert(Ptr{Ptr{Nothing}}, pointer_from_objref(m.data)), pointer_from_objref(val), i)
-        error("setindex!() with non-isbits eltype is not supported by StaticArrays. Consider using SizedArray.")
+        error("setindex!() with non-isbitstype eltype is not supported by StaticArrays. Consider using SizedArray.")
     end
 
     return val

src/MVector.jl

@@ -42,12 +42,12 @@ end
         throw(BoundsError())
     end
 
-    if isbits(T)
+    if isbitstype(T)
         unsafe_store!(Base.unsafe_convert(Ptr{T}, pointer_from_objref(v)), val, i)
     else
         # This one is unsafe (#27)
         #unsafe_store!(Base.unsafe_convert(Ptr{Ptr{Nothing}}, pointer_from_objref(v.data)), pointer_from_objref(val), i)
-        error("setindex!() with non-isbits eltype is not supported by StaticArrays. Consider using SizedArray.")
+        error("setindex!() with non-isbitstype eltype is not supported by StaticArrays. Consider using SizedArray.")
     end
 
     return val

src/matrix_multiply.jl

@@ -201,7 +201,7 @@ end
 
     S = Size(sa[1], sb[2])
 
-    # Do a custom b[:, k2] to return a SVector (an isbits type) rather than (possibly) a mutable type. Avoids allocation == faster
+    # Do a custom b[:, k2] to return a SVector (an isbitstype type) rather than (possibly) a mutable type. Avoids allocation == faster
     tmp_type_in = :(SVector{$(sb[1]), T})
     tmp_type_out = :(SVector{$(sa[1]), T})
     vect_exprs = [:($(Symbol("tmp_$k2"))::$tmp_type_out = partly_unrolled_multiply(Size(a), Size($(sb[1])), a,
@@ -403,7 +403,7 @@ end
 
     #vect_exprs = [:($(Symbol("tmp_$k2")) = partly_unrolled_multiply(A, B[:, $k2])) for k2 = 1:sB[2]]
 
-    # Do a custom b[:, k2] to return a SVector (an isbits type) rather than a mutable type. Avoids allocation == faster
+    # Do a custom b[:, k2] to return a SVector (an isbitstype type) rather than a mutable type. Avoids allocation == faster
     tmp_type = SVector{sb[1], eltype(c)}
     vect_exprs = [:($(Symbol("tmp_$k2")) = partly_unrolled_multiply($(Size(sa)), $(Size(sb[1])), a, $(Expr(:call, tmp_type, [Expr(:ref, :b, LinearIndices(sb)[i, k2]) for i = 1:sb[1]]...)))) for k2 = 1:sb[2]]
 

test/arraymath.jl

@@ -85,7 +85,7 @@ import StaticArrays.arithmetic_closure
         @test (t*t) isa T
         @test (t/t) isa T
 
-        if isbits(T0)
+        if isbitstype(T0)
             @test @allocated(arithmetic_closure(T0)) == 0
         end
     end