Merge pull request #85 from umgrmxsvaf/fix-prod

Fix definition of prod()

Author: c42f

src/mapreduce.jl

@@ -92,7 +92,7 @@ end
 
 # These are all similar in Base but not @inline'd
 @inline sum{T}(a::StaticArray{T}) = reduce(+, zero(T), a)
-@inline prod{T}(a::StaticArray{T}) = reduce(+, zero(T), a)
+@inline prod{T}(a::StaticArray{T}) = reduce(*, one(T), a)
 @inline count(a::StaticArray{Bool}) = reduce(+, 0, a)
 @inline all(a::StaticArray{Bool}) = reduce(&, true, a)  # non-branching versions
 @inline any(a::StaticArray{Bool}) = reduce(|, false, a) # (benchmarking needed)

test/mapreduce.jl

@@ -20,6 +20,8 @@
         v1 = @SVector [2,4,6,8]
         @test reduce(+, v1) === 20
         @test reduce(+, 0, v1) === 20
+        @test sum(v1) === 20
+        @test prod(v1) === 384
     end
 
     @testset "mapreduce" begin