resolve reshape ambiguity to Base (#289)

* resolve reshape ambiguity to Base

* debug: retrigger CI

* add test

Author: johnnychen94

src/OffsetArrays.jl

@@ -376,9 +376,12 @@ Base.reshape(A::OffsetArray, inds::Tuple{Union{Integer,Base.OneTo},Vararg{Union{
 Base.reshape(A::OffsetArray, inds::Dims) = _reshape_nov(A, inds)
 Base.reshape(A::OffsetVector, ::Colon) = A
 Base.reshape(A::OffsetVector, ::Tuple{Colon}) = A
-Base.reshape(A::OffsetArray, ::Colon) = reshape(A, (Colon(),))
 Base.reshape(A::OffsetArray, inds::Union{Int,Colon}...) = reshape(A, inds)
 Base.reshape(A::OffsetArray, inds::Tuple{Vararg{Union{Int,Colon}}}) = _reshape_nov(A, inds)
+# The following two additional methods for Colon are added to resolve method ambiguities to
+# Base: https://github.com/JuliaLang/julia/pull/45387#issuecomment-1132859663
+Base.reshape(A::OffsetArray, inds::Colon) = reshape(parent(A), inds)
+Base.reshape(A::OffsetArray, inds::Tuple{Colon}) = reshape(parent(A), inds)
 
 # permutedims in Base does not preserve axes, and can not be fixed in a non-breaking way
 # This is a stopgap solution

test/runtests.jl

@@ -1835,6 +1835,11 @@ end
     rp = parent(r)
     @test axes(reshape(rp, 4:6), 1) == 4:6
     @test axes(reshape(r, (3,1))) == (1:3, 1:1)
+
+    # reshape with one single colon becomes a `vec`
+    A = OffsetArray(rand(4, 4), -1, -1)
+    @test reshape(A, (:, )) == vec(A)
+    @test reshape(A, :) == vec(A)
 end
 
 @testset "permutedims" begin