bugfix in constructors

Author: jishnub

src/OffsetArrays.jl

@@ -165,11 +165,10 @@ for FT in (:OffsetArray, :OffsetVector, :OffsetMatrix)
     # In general, indices get converted to AbstractUnitRanges.
     # CartesianIndices{N} get converted to N ranges
     @eval function $FT(A::AbstractArray, inds::Tuple)
-        inds2 = to_indices(A, axes(A), inds)
-        OffsetArray(A, _toAbstractUnitRanges(inds2))
+        $FT(A, _toAbstractUnitRanges(to_indices(A, axes(A), inds)))
     end
 
-    @eval $FT(A::AbstractArray, inds::Vararg) = OffsetArray(A, inds)
+    @eval $FT(A::AbstractArray, inds::Vararg) = $FT(A, inds)
 
     # convert ranges to offsets
     @eval function $FT(A::AbstractArray{<:Any,N}, inds::Indices{N}) where {N}
@@ -180,7 +179,7 @@ for FT in (:OffsetArray, :OffsetVector, :OffsetMatrix)
         $FT(A, map(_offset, axparent, inds)) 
     end
 
-    @eval $FT(A::AbstractArray, origin::Origin) = OffsetArray(A, origin(A))
+    @eval $FT(A::AbstractArray, origin::Origin) = $FT(A, origin(A))
 end
 
 # Ambiguity resolution

test/runtests.jl

@@ -251,7 +251,10 @@ end
         @test_throws ArgumentError OffsetArray(ao, (-2, )) # convinient constructor accumulate offsets
 
         # disallow OffsetVector(::Array{<:Any, N}, offsets) where N != 1
-        @test_throws ArgumentError OffsetVector(zeros(2,2), (2,2))
+        @test_throws ArgumentError OffsetVector(zeros(2,2), (2, 2))
+        @test_throws ArgumentError OffsetVector(zeros(2,2), 2, 2)
+        @test_throws ArgumentError OffsetVector(zeros(2,2), (1:2, 1:2))
+        @test_throws ArgumentError OffsetVector(zeros(2,2), 1:2, 1:2)
         @test_throws ArgumentError OffsetVector(zeros(), ())
     end
 
@@ -372,6 +375,9 @@ end
 
         # disallow OffsetMatrix(::Array{<:Any, N}, offsets) where N != 2
         @test_throws ArgumentError OffsetMatrix(zeros(2), (2,))
+        @test_throws ArgumentError OffsetMatrix(zeros(2), 2)
+        @test_throws ArgumentError OffsetMatrix(zeros(2), (1:2,))
+        @test_throws ArgumentError OffsetMatrix(zeros(2), 1:2)
         @test_throws ArgumentError OffsetMatrix(zeros(), ())
     end