Skip to content

Commit 20deccb

Browse files
authored
a::Vararg -> a... (#265)
Shorter, more readable, and doesn't break Julia. What's not to like? xref JuliaLang/julia#42161
1 parent 3bdb4d4 commit 20deccb

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/OffsetArrays.jl

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ for FT in (:OffsetArray, :OffsetVector, :OffsetMatrix)
204204
$FT(A, map(_offset, axes(A), inds); kw...)
205205
end
206206

207-
@eval @inline $FT(A::AbstractArray, inds::Vararg; kw...) = $FT(A, inds; kw...)
207+
@eval @inline $FT(A::AbstractArray, inds...; kw...) = $FT(A, inds; kw...)
208208
@eval @inline $FT(A::AbstractArray; checkoverflow = false) = $FT(A, ntuple(zero, Val(ndims(A))), checkoverflow = checkoverflow)
209209

210210
@eval @inline $FT(A::AbstractArray, origin::Origin; checkoverflow = true) = $FT(A, origin(A); checkoverflow = checkoverflow)
@@ -220,7 +220,7 @@ end
220220
@inline OffsetArray{T,N}(M::OffsetArray{T,N}, I...; kw...) where {T,N} = OffsetArray(M, I...; kw...)
221221
@inline OffsetArray{T,N}(M::AbstractArray{T,N}, I...; kw...) where {T,N} = OffsetArray{T,N,typeof(M)}(M, I...; kw...)
222222

223-
@inline OffsetArray{T,N,A}(M::AbstractArray{<:Any,N}, I::Vararg; kw...) where {T,N,A<:AbstractArray{T,N}} = OffsetArray{T,N,A}(M, I; kw...)
223+
@inline OffsetArray{T,N,A}(M::AbstractArray{<:Any,N}, I...; kw...) where {T,N,A<:AbstractArray{T,N}} = OffsetArray{T,N,A}(M, I; kw...)
224224
@inline function OffsetArray{T,N,A}(M::AbstractArray{<:Any,N}, I::NTuple{N,Int}; checkoverflow = true) where {T,N,A<:AbstractArray{T,N}}
225225
checkoverflow && map(overflow_check, axes(M), I)
226226
Mv = no_offset_view(M)
@@ -263,13 +263,13 @@ end
263263
@inline function OffsetArray{T, N}(init::ArrayInitializer, inds::Tuple; kw...) where {T, N}
264264
OffsetArray{T, N}(init, _toAbstractUnitRanges(inds); kw...)
265265
end
266-
@inline OffsetArray{T,N}(init::ArrayInitializer, inds::Vararg; kw...) where {T,N} = OffsetArray{T,N}(init, inds; kw...)
266+
@inline OffsetArray{T,N}(init::ArrayInitializer, inds...; kw...) where {T,N} = OffsetArray{T,N}(init, inds; kw...)
267267

268268
@inline OffsetArray{T}(init::ArrayInitializer, inds::NTuple{N, OffsetAxisKnownLength}; kw...) where {T,N} = OffsetArray{T,N}(init, inds; kw...)
269269
@inline function OffsetArray{T}(init::ArrayInitializer, inds::Tuple; kw...) where {T}
270270
OffsetArray{T}(init, _toAbstractUnitRanges(inds); kw...)
271271
end
272-
@inline OffsetArray{T}(init::ArrayInitializer, inds::Vararg; kw...) where {T} = OffsetArray{T}(init, inds; kw...)
272+
@inline OffsetArray{T}(init::ArrayInitializer, inds...; kw...) where {T} = OffsetArray{T}(init, inds; kw...)
273273

274274
Base.IndexStyle(::Type{OA}) where {OA<:OffsetArray} = IndexStyle(parenttype(OA))
275275
parenttype(::Type{OffsetArray{T,N,AA}}) where {T,N,AA} = AA

0 commit comments

Comments
 (0)