Skip to content

Commit 9d38d86

Browse files
authored
Fully qualify constructor extension
Extending constructors without module specification can lead to undefined behaviour in case of name clashes. This is fixed by fully qualifying `ArrayInterface.BandedMatrixIndex` when it is extended in the banded matrix ext.
1 parent 9e3936c commit 9d38d86

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

ext/ArrayInterfaceBandedMatricesExt.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ function _bandsize(bandind, rowsize, colsize)
4646
end
4747
end
4848

49-
function BandedMatrixIndex(rowsize, colsize, lowerbandwidth, upperbandwidth, isrow)
49+
function ArrayInterface.BandedMatrixIndex(rowsize, colsize, lowerbandwidth, upperbandwidth, isrow)
5050
upperbandwidth > -lowerbandwidth || throw(ErrorException("Invalid Bandwidths"))
5151
bandinds = upperbandwidth:-1:(-lowerbandwidth)
5252
bandsizes = [_bandsize(band, rowsize, colsize) for band in bandinds]

0 commit comments

Comments
 (0)