Skip to content

Added import Base: isassigned so that view works correctly on QuasiAr… #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

macd
Copy link
Contributor

@macd macd commented Jan 6, 2025

Currently, the following fails with a missing method

    using QuasiArrays
    A = QuasiArray(randn(5,2), (0:0.5:2, [1,4]))
    V = view(A, 0.0, [1,4])

This PR just adds that import to QuasiArrays.jl. There is a test for this in test_quasipermutedims and it does pass, but fails
outside of the test environment.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (b0741da) to head (9e691cc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #116       +/-   ##
==========================================
- Coverage   64.25%   0.00%   -64.26%     
==========================================
  Files          23      23               
  Lines        1835    1818       -17     
==========================================
- Hits         1179       0     -1179     
- Misses        656    1818     +1162     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlfivefifty dlfivefifty merged commit f241cf7 into JuliaApproximation:master Jan 7, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants