Improve code coverage

Author: JoshData

tests/test_deliverability.py

@@ -2,7 +2,7 @@
 import re
 
 from email_validator import EmailUndeliverableError, \
-                            validate_email
+                            validate_email, caching_resolver
 from email_validator.deliverability import validate_email_deliverability
 
 from mocked_dns_response import MockedDnsResponseData, MockedDnsResponseDataCleanup  # noqa: F401
@@ -53,3 +53,24 @@ def test_deliverability_dns_timeout():
     response = validate_email_deliverability('timeout.com', 'timeout.com', dns_resolver=RESOLVER)
     assert "mx" not in response
     assert response.get("unknown-deliverability") == "timeout"
+
+
+@pytest.mark.network
+def test_caching_dns_resolver():
+    class TestCache:
+        def __init__(self):
+            self.cache = {}
+
+        def get(self, key):
+            return self.cache.get(key)
+
+        def put(self, key, value):
+            self.cache[key] = value
+
+    cache = TestCache()
+    resolver = caching_resolver(timeout=1, cache=cache)
+    validate_email("test@gmail.com", dns_resolver=resolver)
+    assert len(cache.cache) == 1
+
+    validate_email("test@gmail.com", dns_resolver=resolver)
+    assert len(cache.cache) == 1

tests/test_main.py

@@ -1,4 +1,6 @@
-from email_validator import validate_email
+import pytest
+
+from email_validator import validate_email, EmailSyntaxError
 # Let's test main but rename it to be clear
 from email_validator.__main__ import main as validator_command_line_tool
 
@@ -45,3 +47,14 @@ def test_main_multi_input(monkeypatch, capsys):
     assert test_cases[1] not in stdout
     assert test_cases[2] in stdout
     assert test_cases[3] in stdout
+
+
+def test_bytes_input():
+    input_email = b"testaddr@example.tld"
+    valid_email = validate_email(input_email, check_deliverability=False)
+    assert isinstance(valid_email.as_dict(), dict)
+    assert valid_email.as_dict()["email"] == input_email.decode("utf8")
+
+    input_email = "testaddr中example.tld".encode("utf32")
+    with pytest.raises(EmailSyntaxError):
+        validate_email(input_email, check_deliverability=False)

tests/test_syntax.py

@@ -239,11 +239,18 @@ def test_email_valid(email_input, output):
         ('111111111122222222223333333333444444444455555555556666666666777777@example.com', 'The email address is too long before the @-sign (2 characters too many).'),
         ('me@1111111111222222222233333333334444444444555555555.6666666666777777777788888888889999999999000000000.1111111111222222222233333333334444444444555555555.6666666666777777777788888888889999999999000000000.111111111122222222223333333333444444444455555555556.com', 'The email address is too long (4 characters too many).'),
         ('me@1111111111222222222233333333334444444444555555555.6666666666777777777788888888889999999999000000000.1111111111222222222233333333334444444444555555555.6666666666777777777788888888889999999999000000000.1111111111222222222233333333334444444444555555555566.com', 'The email address is too long after the @-sign (1 character too many).'),
+        ('me@中1111111111222222222233333333334444444444555555555.6666666666777777777788888888889999999999000000000.1111111111222222222233333333334444444444555555555.6666666666777777777788888888889999999999000000000.1111111111222222222233333333334444444444555555555566.com', 'The email address is too long after the @-sign.'),
         ('my.long.address@1111111111222222222233333333334444444444555555555.6666666666777777777788888888889999999999000000000.1111111111222222222233333333334444444444555555555.6666666666777777777788888888889999999999000000000.11111111112222222222333333333344444.info', 'The email address is too long (2 characters too many).'),
         ('my.long.address@λ111111111222222222233333333334444444444555555555.6666666666777777777788888888889999999999000000000.1111111111222222222233333333334444444444555555555.6666666666777777777788888888889999999999000000000.11111111112222222222333333.info', 'The email address is too long (when converted to IDNA ASCII).'),
         ('my.long.address@λ111111111222222222233333333334444444444555555555.6666666666777777777788888888889999999999000000000.1111111111222222222233333333334444444444555555555.6666666666777777777788888888889999999999000000000.1111111111222222222233333333334444.info', 'The email address is too long (at least 1 character too many).'),
         ('my.λong.address@1111111111222222222233333333334444444444555555555.6666666666777777777788888888889999999999000000000.1111111111222222222233333333334444444444555555555.6666666666777777777788888888889999999999000000000.111111111122222222223333333333444.info', 'The email address is too long (when encoded in bytes).'),
         ('my.λong.address@1111111111222222222233333333334444444444555555555.6666666666777777777788888888889999999999000000000.1111111111222222222233333333334444444444555555555.6666666666777777777788888888889999999999000000000.1111111111222222222233333333334444.info', 'The email address is too long (at least 1 character too many).'),
+        ('me@bad-tld-1', 'The part after the @-sign is not valid. It should have a period.'),
+        ('me@bad.tld-2', 'The part after the @-sign is not valid. It is not within a valid top-level domain.'),
+        ('me@-', 'The part after the @-sign contains invalid characters (Label must not start or end with a hyphen).'),
+        ('me@x!', 'The part after the @-sign contains invalid characters (Codepoint U+0021 at position 2 of \'x!\' not allowed).'),
+        ('me@xn--', 'The part after the @-sign contains invalid characters (Malformed A-label, no Punycode eligible content found).'),
+        ('me@yy--', 'The part after the @-sign contains invalid characters (Label has disallowed hyphens in 3rd and 4th position).'),
     ],
 )
 def test_email_invalid_syntax(email_input, error_msg):
@@ -287,6 +294,7 @@ def test_email_invalid_reserved_domain(email_input):
         ('\uD800@test'),  # surrogate (Cs)
         ('\uE000@test'),  # private use (Co)
         ('\uFDEF@test'),  # unassigned (Cn)
+        ('\u0300@test'),  # grave accent (M)
     ],
 )
 def test_email_unsafe_character(email_input):