Skip to content

Commit 3855a17

Browse files
Remove Bash workaround for Alpine image
There was an issue with Bash >= 5.1 where the wait function did not work as inteded and we had to limit which version we installed. This [problem][1] is fixed as of [Bash 5.1.16][2], so we can remove our special case again. [1]: JonasAlfredsson/bash_fail-to-wait#2 [2]: https://git.savannah.gnu.org/cgit/bash.git/commit/?id=910fcdc415abeb3d7d85fb46ee0d3e804a4c47a6
1 parent 2c942a5 commit 3855a17

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

src/Dockerfile-alpine

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ ENV CERTBOT_DNS_AUTHENTICATORS \
2121
RUN set -ex && \
2222
# Install packages necessary during the build phase (for all architectures).
2323
apk add --no-cache \
24+
bash \
2425
cargo \
2526
curl \
2627
findutils \
@@ -34,8 +35,6 @@ RUN set -ex && \
3435
python3-dev \
3536
sed \
3637
&& \
37-
# Because of the bug mentioned in issue #42 we must use Bash <5.1.x for now.
38-
apk add --no-cache --repository https://dl-cdn.alpinelinux.org/alpine/v3.12/main/ 'bash<5.1' && \
3938
# Install the latest version of PIP, Setuptools and Wheel.
4039
curl -L 'https://bootstrap.pypa.io/get-pip.py' | python3 && \
4140
# Install certbot.

0 commit comments

Comments
 (0)