Skip to content

Update moveFundsBetweenPots usage #3820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kronosapiens opened this issue Dec 2, 2024 · 0 comments
Open

Update moveFundsBetweenPots usage #3820

kronosapiens opened this issue Dec 2, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@kronosapiens
Copy link
Contributor

During testing of JoinColony/colonyNetwork#1193 (see comment) it appears as though the front-end is using a deprecated version of the moveFundsBetweenPots function. Specifically, it is using this version:

moveFundsBetweenPots(uint256,uint256,uint256,uint256,uint256,uint256,address)

Which has been deprecated for security purposes. The new version is

moveFundsBetweenPots(uint256,uint256,uint256,uint256,uint256,uint256,uint256,uint256,address)

Featuring two additional uint256 arguments at the front-end, linking the permission domain to the "parent" domain of the two funding pots being affected.

  function moveFundsBetweenPots(
    uint256 _permissionDomainId,
    uint256 _childSkillIndex,
    uint256 _domainId,
    uint256 _fromChildSkillIndex,
    uint256 _toChildSkillIndex,
    uint256 _fromPot,
    uint256 _toPot,
    uint256 _amount,
    address _token
  )

Usage should be updated prior to merging of JoinColony/colonyNetwork#1193.

@kronosapiens kronosapiens added the bug Something isn't working label Dec 2, 2024
@rdig rdig self-assigned this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants