From 23b806d16e1343357f95fe9d3bbc652f0ecd4f62 Mon Sep 17 00:00:00 2001 From: Veniamin Krol <153412+vkrol@users.noreply.github.com> Date: Thu, 16 Oct 2025 12:31:33 +0300 Subject: [PATCH] Take document scrollbar into account while calculating popup position (#8939) --- src/popup/position.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/popup/position.ts b/src/popup/position.ts index df004e67ea6..df55bdbd9f4 100644 --- a/src/popup/position.ts +++ b/src/popup/position.ts @@ -2,7 +2,6 @@ import { getDocumentScrollLeft, getDocumentScrollTop, getRect, - getWindowHeight, isMounted, type Rect, } from '../global/dom'; @@ -90,7 +89,7 @@ interface OverflowAttrs extends PositionAttrs { } function verticalOverflow(styles: PositionStyles, scrollingCoordinates: Position, attrs: OverflowAttrs) { - const containerHeight = attrs.container ? attrs.container.clientHeight : getWindowHeight(); + const containerHeight = attrs.container ? attrs.container.clientHeight : document.documentElement.clientHeight; const viewportMinX = scrollingCoordinates.top + attrs.sidePadding; const viewportMaxX = scrollingCoordinates.top + containerHeight - attrs.sidePadding; @@ -104,7 +103,7 @@ function verticalOverflow(styles: PositionStyles, scrollingCoordinates: Position } function horizontalOverflow(styles: PositionStyles, scrollingCoordinates: Position, attrs: OverflowAttrs) { - const containerWidth = attrs.container ? attrs.container.clientWidth : window.innerWidth; + const containerWidth = attrs.container ? attrs.container.clientWidth : document.documentElement.clientWidth; const viewportMinY = scrollingCoordinates.left + attrs.sidePadding; const viewportMaxY = scrollingCoordinates.left + containerWidth - attrs.sidePadding;