Skip to content

Commit da69b25

Browse files
committed
fix: test ros_version
1 parent b987b18 commit da69b25

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

test/conftest.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,12 @@ def fake_check_output(cmd, *a, **k):
7575
"manager.manager.manager.check_gpu_acceleration", lambda x=None: "OFF"
7676
)
7777

78-
# Patch get_ros_version
78+
def dummy_run(self, start_pose=None):
79+
print('run around')
80+
7981
monkeypatch.setattr(
80-
"manager.libs.process_utils.get_ros_version",
81-
lambda: "humble" # change if needed
82+
"manager.manager.launcher.launcher_robot.LauncherRobot.run",
83+
dummy_run
8284
)
8385

8486
# Patch os.makedirs and os.path.isdir to avoid real FS operations
@@ -127,6 +129,7 @@ def terminate(self):
127129
pass
128130

129131
monkeypatch.setattr("manager.manager.manager.LauncherTools", DummyToolsLauncher)
132+
# Deprecated
130133
# monkeypatch.setattr("manager.manager.manager.Server", DummyServer)
131134
# monkeypatch.setattr("manager.manager.manager.FileWatchdog", DummyFileWatchdog)
132135

test/test_terminate_transitions.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ def resume(self):
2020
pass
2121

2222

23-
class DummyVisualizationLauncher:
23+
class DummyToolsLauncher:
2424
"""Dummy class for testing visualization launching."""
2525

2626
def launch(self):
@@ -90,7 +90,7 @@ def test_terminate_tools_valid(manager, monkeypatch):
9090
# Ensure the manager is in a state where it can stop
9191
setup_manager_to_tools_ready(manager, monkeypatch)
9292
# Mock needed methods and attributes
93-
manager.visualization_launcher = DummyVisualizationLauncher()
93+
manager.visualization_launcher = DummyToolsLauncher()
9494
manager.terminate_harmonic_processes = lambda: None
9595

9696
# Trigger the stop transition
@@ -123,7 +123,7 @@ def test_terminate_universe_valid(manager, monkeypatch):
123123
# Ensure the manager is in a state where it can stop
124124
setup_manager_to_world_ready(manager, monkeypatch)
125125
# Mock needed methods and attributes
126-
manager.visualization_launcher = DummyVisualizationLauncher()
126+
manager.visualization_launcher = DummyToolsLauncher()
127127
manager.terminate_harmonic_processes = lambda: None
128128

129129
# Trigger the stop transition

0 commit comments

Comments
 (0)