More Spider mine fixes, and small usability improvements for BTs

Author: Bytekeeper

src/main/java/org/bk/ass/bt/Parallel.java

@@ -9,13 +9,18 @@
  */
 public class Parallel extends CompoundNode {
 
-  private Policy policy;
+  private final Policy policy;
 
   public enum Policy {
     SEQUENCE,
     SELECTOR
   }
 
+  public Parallel(TreeNode... children) {
+    super(children);
+    policy = Policy.SEQUENCE;
+  }
+
   public Parallel(Policy policy, TreeNode... children) {
     super(children);
     this.policy = policy;

src/main/java/org/bk/ass/bt/Repeat.java

@@ -5,7 +5,7 @@
 public class Repeat extends Decorator {
   private final int initialLimit;
   private int remaining;
-  private Policy policy;
+  private final Policy policy;
 
   public enum Policy {
     SEQUENCE,

src/main/java/org/bk/ass/sim/SuiciderBehavior.java

@@ -39,6 +39,8 @@ public boolean simUnit(
       return false;
     }
 
+    // Spider mines are detected once they home in
+    agent.detected = true;
     moveToward(frameSkip, agent, selectedEnemy, (float) Math.sqrt(selectedDistanceSquared));
 
     if (selectedDistanceSquared <= agent.speedSquared) {

src/test/java/org/bk/ass/sim/SimulatorTest.java

@@ -1138,6 +1138,23 @@ void spiderMineShouldDoSplashDamage() {
     assertThat(simulator.getAgentsB()).isEmpty();
   }
 
+  @Test
+  void hydrasShouldTakeCareOfSpiderMines() {
+    // GIVEN
+    simulator.addAgentA(factory.of(UnitType.Terran_Vulture_Spider_Mine).setDetected(false).setBurrowed(true));
+    simulator.addAgentB(factory.of(UnitType.Zerg_Hydralisk).setX(96).setHealth(1));
+    simulator.addAgentB(factory.of(UnitType.Zerg_Hydralisk).setX(96).setHealth(1));
+    simulator.addAgentB(factory.of(UnitType.Zerg_Hydralisk).setX(96).setHealth(1));
+    simulator.addAgentB(factory.of(UnitType.Zerg_Hydralisk).setX(96).setHealth(1));
+    simulator.addAgentB(factory.of(UnitType.Zerg_Hydralisk).setX(96).setHealth(1));
+
+    // WHEN
+    simulator.simulate(20);
+
+    // THEN
+    assertThat(simulator.getAgentsB()).isNotEmpty();
+  }
+
   @Test
   void spiderMineShouldNotAttackWorker() {
     // GIVEN