According to Amkmairdor (@discord) - only inner splash damage affects burrowed units; also prevent burrowed units from retreating

Author: Bytekeeper

src/main/java/org/bk/ass/AgentUtil.java

@@ -60,21 +60,17 @@ public static void dealRadialSplashDamage(
   }
 
   private static void applySplashDamage(Weapon weapon, Agent mainTarget, Agent splashTarget) {
-    if (splashTarget == mainTarget
-        || splashTarget.burrowed
-        || splashTarget.isFlyer != mainTarget.isFlyer) {
+    if (splashTarget == mainTarget || splashTarget.isFlyer != mainTarget.isFlyer) {
       return;
     }
 
     int distanceSquared = distanceSquared(splashTarget, mainTarget);
-    if (distanceSquared <= weapon.outerSplashRadiusSquared) {
+    if (distanceSquared <= weapon.innerSplashRadiusSquared) {
+      applyDamage(splashTarget, weapon.damageType, weapon.damageShifted, weapon.hits);
+    } else if (!splashTarget.burrowed) {
       if (distanceSquared <= weapon.medianSplashRadiusSquared) {
-        if (distanceSquared <= weapon.innerSplashRadiusSquared) {
-          applyDamage(splashTarget, weapon.damageType, weapon.damageShifted, weapon.hits);
-        } else {
-          applyDamage(splashTarget, weapon.damageType, weapon.damageShifted / 2, weapon.hits);
-        }
-      } else {
+        applyDamage(splashTarget, weapon.damageType, weapon.damageShifted / 2, weapon.hits);
+      } else if (distanceSquared <= weapon.outerSplashRadiusSquared) {
         applyDamage(splashTarget, weapon.damageType, weapon.damageShifted / 4, weapon.hits);
       }
     }
@@ -106,7 +102,7 @@ public static void dealLineSplashDamage(
             + weapon.innerSplashRadiusSquared;
     for (int i = enemies.size() - 1; i >= 0; i--) {
       Agent enemy = enemies.get(i);
-      if (enemy == mainTarget || enemy.burrowed || enemy.isFlyer != mainTarget.isFlyer) {
+      if (enemy == mainTarget || enemy.isFlyer != mainTarget.isFlyer) {
         continue;
       }
       int enemyDistSq = distanceSquared(enemy, source);

src/main/java/org/bk/ass/RetreatBehavior.java

@@ -15,6 +15,7 @@ public boolean simUnit(
   }
 
   static boolean simFlee(Agent agent, UnorderedCollection<Agent> enemies) {
+    if (agent.burrowed) return false;
     Agent selectedEnemy = null;
     int selectedDistanceSquared = Integer.MAX_VALUE;
     for (int i = enemies.size() - 1; i >= 0; i--) {

src/test/java/org/bk/ass/SimulatorTest.java

@@ -143,6 +143,26 @@ void lurkerVsTwoOpposingMarinesSingleFrame() {
     assertThat(simulator.getAgentsA()).extracting("health").contains(20, 40);
   }
 
+  @Test
+  void tankVsBurrowedZerglings() {
+    // GIVEN
+    simulator.addAgentA(factory.of(UnitType.Terran_Siege_Tank_Siege_Mode));
+    simulator.addAgentB(factory.of(UnitType.Zerg_Hydralisk).setX(384).setBurrowed(true));
+    simulator.addAgentB(factory.of(UnitType.Zerg_Hydralisk).setX(394).setBurrowed(true));
+    simulator.addAgentB(factory.of(UnitType.Zerg_Hydralisk).setX(404).setBurrowed(true));
+    simulator.addAgentB(factory.of(UnitType.Zerg_Hydralisk).setX(404));
+
+    // WHEN
+    simulator.simulate(1);
+
+    // THEN
+    assertThat(simulator.getAgentsB()).extracting("health")
+            .contains(80, // out of inner splash range while burrowed
+                    62, // direct hit
+                    62, // inner splash hit burrowed
+                    71); // unburrowed, inside outer splash
+  }
+
   @Test
   void lurkerVsTwoMarinesSingleFrame() {
     // GIVEN