check all enums that use idToEnum to be correct

Author: JasperGeurtz

src/main/java/bwapi/UpgradeType.java

@@ -199,7 +199,7 @@ public enum UpgradeType {
             Race.Protoss, Race.Protoss, Race.Protoss, Race.None, Race.None, Race.Protoss, Race.None, Race.Protoss, Race.None, Race.Terran, Race.Zerg, Race.Zerg, Race.Terran, Race.None, Race.None, Race.None, Race.None, Race.None, Race.None, Race.None, Race.Unknown
     };
 
-    public static final UpgradeType[] idToEnum = new UpgradeType[62 + 1];
+    static final UpgradeType[] idToEnum = new UpgradeType[62 + 1];
 
     static {
         Arrays.stream(UpgradeType.values()).forEach(v -> idToEnum[v.id] = v);

src/test/java/bwapi/EnumsTest.java

@@ -0,0 +1,51 @@
+package bwapi;
+
+import org.junit.Test;
+
+import java.io.File;
+import java.lang.reflect.Field;
+import java.util.Arrays;
+import java.util.Objects;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+
+public class EnumsTest {
+    static String CLASSES_LOCATION = "src/main/java/bwapi";
+    static String ARRAY_VALUE = "idToEnum";
+    static String ID_VALUE = "id";
+
+    /*
+     * Check, via reflection, that all Enums that have an "idToEnum" array to be of correct lenght
+     */
+    @Test
+    public void checkAllEnums() throws Exception {
+        for (File file : Objects.requireNonNull(new File(CLASSES_LOCATION).listFiles())) {
+            if (file.isFile()) {
+                Class<?> cls = Class.forName("bwapi." + file.getName().replace(".java", ""));
+                if (cls.isEnum() && Arrays.stream(cls.getDeclaredFields()).anyMatch(f -> f.getName().equals(ARRAY_VALUE))) {
+                    Field field = cls.getDeclaredField(ARRAY_VALUE);
+                    assertFalse(field.isAccessible());
+                    field.setAccessible(true);
+
+                    int arrayLength = ((Object[])field.get(null)).length;
+                    int maxEnumVal = Arrays.stream((Object[]) cls.getDeclaredMethod("values").invoke(null))
+                            .mapToInt(obj -> {
+                                try {
+                                    Field f = obj.getClass().getDeclaredField(ID_VALUE);
+                                    assertFalse(f.isAccessible());
+                                    f.setAccessible(true);
+                                    return f.getInt(obj);
+                                } catch (Exception e) {
+                                    e.printStackTrace();
+                                    return -1;
+                                }
+                            })
+                            .max()
+                            .orElse(-1);
+                    assertEquals(arrayLength, maxEnumVal + 1);
+                }
+            }
+        }
+    }
+}