Merge commit 'f4d3a6ecac44fbc83e121c9476fe240bf9329316' into jakerad_generic_math

Author: asmirnov82

src/Microsoft.Data.Analysis/DataFrameBuffer.cs

@@ -77,8 +77,9 @@ internal override T this[int index]
         {
             set
             {
-                if (index > Length)
+                if (index >= Length)
                     throw new ArgumentOutOfRangeException(nameof(index));
+
                 RawSpan[index] = value;
             }
         }

src/Microsoft.Data.Analysis/PrimitiveDataFrameColumn.cs

@@ -165,7 +165,7 @@ protected internal override Apache.Arrow.Array ToArrowArray(long startIndex, int
         {
             get
             {
-                if (startIndex > Length)
+                if (startIndex >= Length)
                 {
                     throw new ArgumentOutOfRangeException(nameof(startIndex));
                 }
@@ -175,7 +175,7 @@ protected internal override Apache.Arrow.Array ToArrowArray(long startIndex, int
 
         protected override IReadOnlyList<object> GetValues(long startIndex, int length)
         {
-            if (startIndex > Length)
+            if (startIndex >= Length)
             {
                 throw new ArgumentOutOfRangeException(nameof(startIndex));
             }

src/Microsoft.Data.Analysis/ReadOnlyDataFrameBuffer.cs

@@ -66,8 +66,9 @@ internal virtual T this[int index]
         {
             get
             {
-                if (index > Length)
+                if (index >= Length)
                     throw new ArgumentOutOfRangeException(nameof(index));
+
                 return ReadOnlySpan[index];
             }
             set => throw new NotSupportedException();

src/Microsoft.Data.Analysis/StringDataFrameColumn.cs

@@ -77,7 +77,7 @@ public void Append(string value)
 
         private int GetBufferIndexContainingRowIndex(ref long rowIndex)
         {
-            if (rowIndex > Length)
+            if (rowIndex >= Length)
             {
                 throw new ArgumentOutOfRangeException(Strings.ColumnIndexOutOfRange, nameof(rowIndex));
             }

src/Microsoft.Data.Analysis/VBufferDataFrameColumn.cs

@@ -85,10 +85,11 @@ public void Append(VBuffer<T> value)
 
         private int GetBufferIndexContainingRowIndex(ref long rowIndex)
         {
-            if (rowIndex > Length)
+            if (rowIndex >= Length)
             {
                 throw new ArgumentOutOfRangeException(Strings.ColumnIndexOutOfRange, nameof(rowIndex));
             }
+
             return (int)(rowIndex / int.MaxValue);
         }