Skip to content

Commit 45cc611

Browse files
format markdown files and update TODO
1 parent a1185cf commit 45cc611

File tree

5 files changed

+29
-14
lines changed

5 files changed

+29
-14
lines changed

README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,10 @@ An extension of [AiCoverGen](https://github.com/SociallyIneptWeeb/AICoverGen), w
1313
Ultimate RVC is under constant development and testing, but you can try it out right now locally or on Google Colab!
1414

1515
## Youtube Showcase
16+
1617
* [Ultimate RVC: The Most Powerful AI Voice Cloning Tool Yet!](https://www.youtube.com/watch?v=dVpCF68JpNg)
1718
* [Ultimate-RVC on Your PC | Turn Any Voice Into Yours!](https://www.youtube.com/watch?v=IxFgz50y1AY)
18-
* [ Train Any Voice with Ultimate RVC | Fast & Accurate Voice Cloning](https://www.youtube.com/watch?v=O7VeYLL3H-c)
19+
* [Train Any Voice with Ultimate RVC | Fast & Accurate Voice Cloning](https://www.youtube.com/watch?v=O7VeYLL3H-c)
1920

2021
Courtesy of [Social & Apps](https://www.youtube.com/@socialapps1194)
2122

@@ -44,7 +45,7 @@ To setup the project follow the steps below and execute the provided commands in
4445

4546
### Install Git
4647

47-
Follow the instructions [here](https://git-scm.com/book/en/v2/Getting-Started-Installing-Git) to install Git on your computer.
48+
Follow the [Git installation instructions](https://git-scm.com/book/en/v2/Getting-Started-Installing-Git) to install Git on your computer.
4849

4950
### Set execution policy (Windows only)
5051

@@ -145,7 +146,7 @@ The Ultimate RVC project package can then be installed as follows:
145146
pip install ultimate-rvc
146147
```
147148

148-
### Usage
149+
### CLI Usage
149150

150151
The `ultimate-rvc` package can be used as a python library but is primarily intended to be used as a command line tool. The package exposes two top-level commands:
151152

notes/TODO.md

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,20 @@
11
# TODO
22

3+
* figure out a way of safely storing PyPI credentials
4+
* promote dependencies to latest versions
5+
* and do proper testing before committing
6+
* setup testing with pytest
7+
* setup folder structure for tests
8+
* configure required dependencies in `pyproject.toml`
9+
* pytest, faker
10+
* setup pytest configuration in `pyproject.toml`
11+
* setup pytest pre-commit hook
12+
* setup test coverage
13+
* first research best framework for this in python
14+
* setup auto documentation generation
15+
316
* fix configuration saving/loading so that visibility status can also be saved and loaded
4-
* this needs to be done statically: when defining a configuration component there should be an optional children field which denotes the children of the component that will be unfolded, i.e. shouldb become visible. There hsould also (perhaps on the same field) be a defined value for which the child components should be visible. Then during the saving of new component values, we will do a check where we see if a given component has any children. if so and if the new component value is equal to the value for which the children should become visible, then we set the visibility field on the children to true.
17+
* this needs to be done statically: when defining a configuration component there should be an optional children field which denotes the children of the component that will be unfolded, i.e. shouldb become visible. There hsould also (perhaps on the same field) be a defined value for which the child components should be visible. Then during the saving of new component values, we will do a check where we see if a given component has any children. if so and if the new component value is equal to the value for which the children should become visible, then we set the visibility field on the children to true.
518
* When this has been implemented we can finally have all the components with children be included rather than excluded from saving and loading as is the case now (and of course the visiblity of their children will be saved too)
619

720
* remodularize frontend code to reflect new tab layout
@@ -85,11 +98,11 @@
8598
* Possible solutions
8699
* use gr.browserstate to allow state to be preserved acrross page loads.
87100
* Save any changes to components to a session dictionary and load from it upon refresh
88-
* See [here](https://github.com/gradio-app/gradio/issues/3106#issuecomment-1694704623)
101+
* See [this GitHub issue comment](https://github.com/gradio-app/gradio/issues/3106#issuecomment-1694704623)
89102
* Problem is that this solution might not work with accordions or other types of blocks
90103
* should use .expand() and .collapse() event listeners on accordions to programmatically reset the state of accordions to what they were before after user has refreshed the page
91104
* Use localstorage
92-
* see [here](https://huggingface.co/spaces/YiXinCoding/gradio-chat-history/blob/main/app.py) and [here](https://huggingface.co/spaces/radames/gradio_window_localStorage/blob/main/app.py)
105+
* see [this chat history example](https://huggingface.co/spaces/YiXinCoding/gradio-chat-history/blob/main/app.py) and [this localStorage example](https://huggingface.co/spaces/radames/gradio_window_localStorage/blob/main/app.py)
93106

94107
* Whenever the state of a component is changed save the new state to a custom JSON file.
95108
* Then whenever the app is refreshed load the current state of components from the JSON file
@@ -128,7 +141,7 @@
128141

129142
## Core
130143

131-
### Common
144+
### Common Features
132145

133146
* instead of having custom embedder models, just allow users to upload new embedder models which will be shown in the main embedder models dropdown (and perhaps also saved in the main embedder models dir?)
134147

@@ -403,9 +416,11 @@
403416
* when ultimate rvc is downloaded as a pypi package the exposed commands are much faster so investigate this
404417

405418
## GitHub
419+
406420
* setup discussions forum on repo
407421
* add support me/by me coffee section on readme
408422
* add an acknowledgements section to readme
423+
409424
### Actions
410425

411426
* linting with Ruff

notes/app-doc.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ Run the Ultimate RVC web application.
55
**Usage**:
66

77
```console
8-
$ main [OPTIONS]
8+
main [OPTIONS]
99
```
1010

1111
**Options**:

notes/cli-doc.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ CLI for the Ultimate RVC project
55
**Usage**:
66

77
```console
8-
$ urvc-cli [OPTIONS] COMMAND [ARGS]...
8+
urvc-cli [OPTIONS] COMMAND [ARGS]...
99
```
1010

1111
**Options**:
@@ -25,7 +25,7 @@ Generate song covers
2525
**Usage**:
2626

2727
```console
28-
$ urvc-cli song-cover [OPTIONS] COMMAND [ARGS]...
28+
urvc-cli song-cover [OPTIONS] COMMAND [ARGS]...
2929
```
3030

3131
**Options**:
@@ -43,7 +43,7 @@ Run the song cover generation pipeline.
4343
**Usage**:
4444

4545
```console
46-
$ urvc-cli song-cover run-pipeline [OPTIONS] SOURCE MODEL_NAME
46+
urvc-cli song-cover run-pipeline [OPTIONS] SOURCE MODEL_NAME
4747
```
4848

4949
**Arguments**:

notes/prioritized_todo.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
* rework other settings tab
66
* this should also contain other settings such as the ability to change the theme of the app
7-
* Add Support for changing theme in app?
7+
* Add Support for changing theme in app?
88
* there should be a button to apply settings which will reload the app with the new settings
99

1010
* move all post processing from vocal conversion step to postprocessing step
@@ -47,10 +47,9 @@
4747
* figure out way of making ./urvc commands execute faster
4848
* when ultimate rvc is downloaded as a pypi package the exposed commands are much faster so investigate this
4949

50-
5150
* Add example audio files to use for testing
5251
* Should be located in `audio/examples`
5352
* could have sub-folders `input` and `output`
5453
* in `output` folder we have `output_audio.ext` files each with a corresponding `input_audio.json` file containing metadata explaining arguments used to generate output
5554
* We can then test that actual output is close enough to expected output using audio similarity metric.
56-
* Setup unit testing framework using pytest
55+
* Setup unit testing framework using pytest

0 commit comments

Comments
 (0)