Skip to content

Commit ef9fef3

Browse files
authored
Fix docker build (#13439)
1 parent fb80f4c commit ef9fef3

File tree

4 files changed

+49
-17
lines changed

4 files changed

+49
-17
lines changed

.dockerignore

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,27 @@
1+
.git
12
.gitignore
23
.dockerignore
34

45
Dockerfile
56
Dockerfile.*
67
.github/
78

9+
.devcontainer/
10+
11+
*/bin
12+
*/build
13+
*/out
14+
15+
docs/
16+
17+
gg.cmd
18+
gradlew.bat
19+
820
# no generated files in version control
921
src/main/gen/
1022
src/main/generated/
1123
src-gen/
1224

13-
src/main/resources/csl-styles
14-
src/main/resources/csl-locales
15-
buildres/abbrv.jabref.org
16-
17-
jablib/src/main/resources/csl-styles
18-
jablib/src/main/resources/csl-locales
19-
2025
.lycheecache
2126

2227
.kotlin

.github/workflows/dockerimages.yml

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ name: Docker Images
33
on:
44
pull_request:
55
paths:
6+
- '.dockerignore'
67
- '.github/workflows/dockerimages.yml'
78
- 'Dockerfile.*'
89
push:
@@ -51,6 +52,19 @@ jobs:
5152
uses: docker/setup-qemu-action@v3
5253
- name: Set up Docker Buildx
5354
uses: docker/setup-buildx-action@v3
55+
- name: Fetch all history for all tags and branches
56+
uses: actions/checkout@v4
57+
with:
58+
fetch-depth: 0
59+
submodules: 'true'
60+
show-progress: 'false'
61+
- name: Install GitVersion
62+
uses: gittools/actions/gitversion/setup@v3.2.1
63+
with:
64+
versionSpec: "5.x"
65+
- name: Run GitVersion
66+
id: gitversion
67+
uses: gittools/actions/gitversion/execute@v3.2.1
5468
- name: Build and push
5569
uses: docker/build-push-action@v6
5670
with:
@@ -63,3 +77,6 @@ jobs:
6377
tags: ${{ steps.meta.outputs.tags }}
6478
labels: ${{ steps.meta.outputs.labels }}
6579
file: Dockerfile.${{ matrix.component }}
80+
build-args: |
81+
VERSION=${{ steps.gitversion.outputs.AssemblySemVer }}
82+
VERSION_INFO=${{ steps.gitversion.outputs.InformationalVersion }}

Dockerfile.jabkit

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,21 @@
11
FROM gradle:jdk24-noble AS build
22

3-
WORKDIR /app
3+
LABEL org.opencontainers.image.title="jabkit"
4+
LABEL org.opencontainers.image.description="JabRef's CLI tool"
45

5-
COPY . .
6+
ARG VERSION="100.0.0"
7+
ARG VERSION_INFO="100.0.0"
8+
ARG TAG_BUILD="false"
9+
10+
WORKDIR /build
611

7-
RUN gradle --no-daemon :jabkit:jpackage
12+
COPY . .
813

9-
RUN find jabkit/build/distribution
14+
RUN gradle --no-daemon -PprojVersion="${VERSION}" -PprojVersionInfo="${VERSION_INFO}" -Ptagbuild="${TAG_BUILD}" :jabkit:jpackage
1015

1116
RUN mkdir /dist
1217

13-
RUN mv jabkit/build/distribution/jabkit /dist
18+
RUN mv jabkit/build/packages/*/* /dist
1419

1520
# jpackage needs glibc; alpine does not work
1621
FROM debian:bookworm-slim AS runtime

Dockerfile.jabsrv

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,21 @@
11
FROM gradle:jdk24-noble AS build
22

3-
WORKDIR /app
3+
LABEL org.opencontainers.image.title="jabsrv"
4+
LABEL org.opencontainers.image.description="JabRef's HTTP server"
45

5-
COPY . .
6+
ARG VERSION="100.0.0"
7+
ARG VERSION_INFO="100.0.0"
8+
ARG TAG_BUILD="false"
9+
10+
WORKDIR /build
611

7-
RUN gradle --no-daemon :jabsrv-cli:jpackage
12+
COPY . .
813

9-
RUN find jabsrv-cli/build/distribution
14+
RUN gradle --no-daemon -PprojVersion="${VERSION}" -PprojVersionInfo="${VERSION_INFO}" -Ptagbuild="${TAG_BUILD}" :jabsrv-cli:jpackage
1015

1116
RUN mkdir /dist
1217

13-
RUN mv jabsrv-cli/build/distribution/jabsrv /dist
18+
RUN mv jabsrv-cli/build/packages/*/* /dist
1419

1520
# jpackage needs glibc; alpine does not work
1621
FROM debian:bookworm-slim AS runtime

0 commit comments

Comments
 (0)