Merge branch 'main' into feature/static-analysis-fixes

Author: koppor

.github/ghprcomment.yml

@@ -79,12 +79,20 @@
     If you made changes that are visible to the user, please add a brief description along with the issue number to the `CHANGELOG.md` file.
     If you did not, please replace the cross (`[x]`) by a slash (`[/]`) to indicate that no `CHANGELOG.md` entry is necessary.
     More details can be found in our [Developer Documentation about the changelog](https://devdocs.jabref.org/decisions/0007-human-readable-changelog.html).
-- jobName: CHANGELOG.md
+- jobName: 'CHANGELOG.md - only unreleased touched'
   message: >
     While the PR was in progress, a new version of JabRef has been released.
 
 
     You have to merge `upstream/main` and move your entry in `CHANGELOG.md` up to the section `## [Unreleased]`.
+- jobName: CHANGELOG.md
+  message: >
+    You modified `CHANGELOG.md` and did not meet JabRef's rules for consistently formatted Markdown files.
+    To ensure consistent styling, we have [markdown-lint](https://github.com/DavidAnson/markdownlint) in place.
+    [Markdown lint's rules](https://github.com/DavidAnson/markdownlint/blob/main/doc/Rules.md#rules) help to keep our Markdown files consistent within this repository and consistent with the Markdown files outside here.
+
+
+    You can check the detailed error output by navigating to your pull request, selecting the tab "Checks", section "Tests" (on the left), subsection "CHANGELOG.md".
 - jobName: Markdown
   message: >
     You modified Markdown (`*.md`) files and did not meet JabRef's rules for consistently formatted Markdown files.

.github/workflows/binaries-ea.yml

@@ -6,7 +6,7 @@ on:
 
 jobs:
   assign:
-    if: github.repository == 'JabRef/jabref'
+    if: github.repository_owner == 'JabRef'
     runs-on: ubuntu-latest
     permissions:
       contents: read

.github/workflows/binaries.yml

@@ -9,6 +9,7 @@ jobs:
     name: Determine issue number
     runs-on: ubuntu-latest
     if: >
+      (github.repository == 'JabRef/jabref') &&
       !(
         (github.actor == 'dependabot[bot]') ||
         (

.github/workflows/on-issue-comment.yml

@@ -10,6 +10,7 @@ jobs:
     name: Determine issue number
     runs-on: ubuntu-latest
     if: >
+      (github.repository == 'JabRef/jabref') &&
       !(
         (github.actor == 'dependabot[bot]') ||
         (
@@ -53,7 +54,6 @@ jobs:
           echo "No valid ticket number found!"
           exit 1
   move_issue:
-    if: github.repository_owner == 'JabRef'
     name: Mark issue as in progress
     # after determine_issue_number to ensure that there is only one failure because of no ticket number
     needs: determine_issue_number
@@ -84,7 +84,6 @@ jobs:
           issue-number: ${{ needs.determine_issue_number.outputs.issue_number }}
           skip-if-not-in-project: true
   ensure_assignment:
-    if: github.repository_owner == 'JabRef'
     name: Ensure that contributor is assigned (fails if not commented on issue)
     # after determine_issue_number to ensure that there is only one failure because of no ticket number
     needs: determine_issue_number
@@ -126,6 +125,7 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
   conflicts_with_target:
+    if: github.repository == 'JabRef/jabref'
     name: Conflicts with target branch
     runs-on: ubuntu-latest
     steps:
@@ -144,7 +144,7 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
   upload-pr-number:
-    if: ${{ github.repository == 'JabRef/jabref' }}
+    if: github.repository == 'JabRef/jabref'
     runs-on: ubuntu-latest
     steps:
       - name: Create pr_number.txt

.github/workflows/on-pr-closed.yml

@@ -6,6 +6,7 @@ on:
 
 jobs:
   welcome-first-time-contributor:
+    if: github.repository == 'JabRef/jabref'
     runs-on: ubuntu-latest
     permissions:
       issues: write

.github/workflows/on-pr-opened-updated.yml

@@ -25,7 +25,7 @@ concurrency:
 
 jobs:
   build:
-    if: ${{ github.repository_owner == 'JabRef' }}
+    if: github.repository == 'JabRef/jabref'
     runs-on: ubuntu-latest
     steps:
       - name: Checkout

.github/workflows/on-pr-opened.yml

@@ -76,7 +76,7 @@ jobs:
             echo "workflow_run_id=${{ github.event.workflow_run.id }}" >> $GITHUB_OUTPUT
           fi
 
-      - name: Check if PR has 'dev: no-bot-comments' label
+      - name: "Check if PR has 'dev: no-bot-comments' label"
         if: ${{ github.event_name == 'workflow_dispatch' || (steps.read-pr_number.outputs.pr_number != '' && steps.isCrossRepository.outputs.isCrossRepository == 'true') }}
         id: check-label
         run: |
@@ -89,7 +89,7 @@ jobs:
       # This step runs in both cases using the proper variables.
       - name: ghprcomment@main
         if: ${{ steps.check-label.outputs.has_label == 'false' && (github.event_name == 'workflow_dispatch' || (steps.read-pr_number.outputs.pr_number != '' && steps.isCrossRepository.outputs.isCrossRepository == 'true')) }}
-        uses: jbangdev/jbang-action@v0.126.2
+        uses: jbangdev/jbang-action@v0.126.3
         with:
           script: https://github.com/koppor/ghprcomment/blob/main/ghprcomment.java
           scriptargs: "-r JabRef/jabref -p ${{ steps.set-vars.outputs.pr_number }} -w ${{ steps.set-vars.outputs.workflow_run_id }}"

.github/workflows/pages.yml

@@ -0,0 +1,107 @@
+name: Publish to maven central
+
+on:
+  pull_request:
+    paths:
+     - .github/workflows/publish.yml
+  push:
+    paths:
+     - .github/workflows/publish.yml
+    tags:
+      - '*'
+  schedule:
+    # run on each Monday
+    - cron: '2 3 * * 1'
+  workflow_dispatch:
+
+permissions:
+  actions: write
+  contents: read
+  pull-requests: write
+
+env:
+  GRADLE_OPTS: -Xmx4g -Dorg.gradle.vfs.watch=false
+  JAVA_OPTS: -Xmx4g
+
+concurrency:
+  group: "${{ github.workflow }}-${{ github.head_ref || github.ref }}-${{ github.event_name }}"
+  cancel-in-progress: true
+
+jobs:
+  publish:
+    name: jablib
+    if: github.repository == 'JabRef/jabref'
+    runs-on: ubuntu-latest
+    steps:
+      - name: Fetch all history for all tags and branches
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 0
+          submodules: 'true'
+          show-progress: 'false'
+      - name: Checkout java-module-packaging
+        uses: actions/checkout@v4
+        with:
+          repository: koppor/java-module-packaging
+          path: build-logic/java-module-packaging
+          ref: fix-params
+      - name: Install GitVersion
+        uses: gittools/actions/gitversion/setup@v3.2.1
+        with:
+          versionSpec: "5.x"
+      - name: Run GitVersion
+        id: gitversion
+        uses: gittools/actions/gitversion/execute@v3.2.1
+      - name: Setup JDK
+        uses: actions/setup-java@v4
+        with:
+          java-version: '24'
+          distribution: 'corretto'
+          java-package: 'jdk'
+      - name: Setup Gradle
+        uses: gradle/actions/setup-gradle@v4
+      - name: Generate JBang cache key
+        id: cache-key
+        shell: bash
+        run: |
+          echo "cache_key=jbang-$(date +%F)" >> $GITHUB_OUTPUT
+      - name: Use cache
+        uses: actions/cache@v4
+        with:
+          lookup-only: true
+          path: ~/.jbang
+          key: ${{ steps.cache-key.outputs.cache_key }}
+          restore-keys:
+            jbang-
+      - name: Setup JBang
+        uses: jbangdev/setup-jbang@main
+
+      # region Publish JabLib on Maven Central
+      - id: istagbuild
+        run: |
+          if [[ "${GITHUB_REF}" == refs/tags/* ]]; then
+            echo "tagbuild=true" >> "$GITHUB_OUTPUT"
+          else
+            echo "tagbuild=false" >> "$GITHUB_OUTPUT"
+          fi
+      - name: Decode secretKeyRingFile
+        id: secring
+        uses: timheuer/base64-to-file@v1
+        with:
+          fileName: 'secring.gpg'
+          encodedString: ${{ secrets.KOPPOR_SIGNING_SECRETKEYRINGFILE_BASE64 }}
+      - name: store secrets
+        run: |
+          cat >> gradle.properties <<EOF
+          signing.keyId=${{ secrets.KOPPOR_SIGNING_KEYID }}
+          signing.password=${{ secrets.KOPPOR_SIGNING_PASSWORD }}
+          signing.secretKeyRingFile=${{ steps.secring.outputs.filePath }}
+          mavenCentralUsername=${{ secrets.KOPPOR_MAVENCENTRALUSERNAME }}
+          mavenCentralPassword=${{ secrets.KOPPOR_MAVENCENTRALPASSWORD }}
+          EOF
+          grep secretKeyRingFile gradle.properties
+          file ${{ steps.secring.outputs.filePath }}
+          md5sum ${{ steps.secring.outputs.filePath }}
+      - name: publishAllPublicationsToMavenCentralRepository
+        run: ./gradlew -PprojVersion="${{ steps.gitversion.outputs.AssemblySemVer }}" -PprojVersionInfo="${{ steps.gitversion.outputs.InformationalVersion }}" -Ptagbuild="${{ steps.istagbuild.outputs.tagbuild }}" :jablib:publishAllPublicationsToMavenCentralRepository
+      # endregion