fix: address Checkstyle issues

Author: zikunz

src/main/java/org/jabref/logic/journals/JournalAbbreviationRepository.java

@@ -226,7 +226,7 @@ private Optional<Abbreviation> findAbbreviationFuzzyMatched(String input) {
     }
 
     /**
-     * Finds the best matching abbreviation by fuzzy matching from a collection of abbreviations
+     * Finds the best matching abbreviation by fuzzy matching from a collection of abbreviations.
      *
      * @param abbreviations Collection of abbreviations to search
      * @param input The input string to match against

src/test/java/org/jabref/gui/journals/UndoableUnabbreviatorTest.java

@@ -1,6 +1,6 @@
 package org.jabref.gui.journals;
 
-import java.util.List;
+import java.util.Set;
 
 import javax.swing.undo.CompoundEdit;
 
@@ -37,11 +37,11 @@ class UndoableUnabbreviatorTest {
     @BeforeEach
     void setUp() {
         repository = new JournalAbbreviationRepository();
-        repository.addCustomAbbreviations(List.of(BUILT_IN_1, BUILT_IN_2), 
+        repository.addCustomAbbreviations(Set.of(BUILT_IN_1, BUILT_IN_2), 
                                          JournalAbbreviationRepository.BUILTIN_LIST_ID, 
                                          true);
 
-        repository.addCustomAbbreviations(List.of(CUSTOM_1, CUSTOM_2), 
+        repository.addCustomAbbreviations(Set.of(CUSTOM_1, CUSTOM_2), 
                                          CUSTOM_SOURCE, 
                                          true);
 

src/test/java/org/jabref/gui/preferences/journals/JournalAbbreviationsViewModelTabTest.java

@@ -7,6 +7,7 @@
 import java.util.Arrays;
 import java.util.List;
 import java.util.Optional;
+import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
 import javafx.beans.property.SimpleBooleanProperty;

src/test/java/org/jabref/logic/journals/AbbreviationsTest.java

@@ -1,7 +1,7 @@
 package org.jabref.logic.journals;
 
-import java.util.List;
 import java.util.Optional;
+import java.util.Set;
 
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
@@ -22,7 +22,7 @@ class AbbreviationsTest {
     void setUp() {
         repository = new JournalAbbreviationRepository();
 
-        repository.addCustomAbbreviations(List.of(TEST_JOURNAL, DOTTED_JOURNAL), 
+        repository.addCustomAbbreviations(Set.of(TEST_JOURNAL, DOTTED_JOURNAL), 
                                          JournalAbbreviationRepository.BUILTIN_LIST_ID, 
                                          true);
     }

src/test/java/org/jabref/logic/journals/JournalAbbreviationRepositoryTest.java

@@ -52,7 +52,7 @@ class JournalAbbreviationRepositoryTest {
     private JournalAbbreviationRepository createTestRepository() {
         JournalAbbreviationRepository testRepo = new JournalAbbreviationRepository();
 
-        testRepo.addCustomAbbreviations(List.of(
+        testRepo.addCustomAbbreviations(Set.of(
             AMERICAN_JOURNAL,
             ACS_MATERIALS,
             ANTIOXIDANTS,
@@ -409,7 +409,7 @@ void dotlessForPhysRevB() {
     @ParameterizedTest
     @MethodSource("provideAbbreviationTestCases")
     void fuzzyMatch(List<Abbreviation> abbreviationList, String input, String expectedAbbreviation, String expectedDotless, String expectedShortest, String ambiguousInput) {
-        repository.addCustomAbbreviations(abbreviationList);
+        repository.addCustomAbbreviations(Set.copyOf(abbreviationList));
 
         assertEquals(expectedAbbreviation, repository.getDefaultAbbreviation(input).orElse("WRONG"));
 
@@ -423,7 +423,7 @@ void fuzzyMatch(List<Abbreviation> abbreviationList, String input, String expect
     static Stream<Arguments> provideAbbreviationTestCases() {
         return Stream.of(
                 Arguments.of(
-                        List.of(
+                        Set.of(
                                 new Abbreviation("Journal of Physics A", "J. Phys. A", "JPA"),
                                 new Abbreviation("Journal of Physics B", "J. Phys. B", "JPB"),
                                 new Abbreviation("Journal of Physics C", "J. Phys. C", "JPC")
@@ -435,7 +435,7 @@ static Stream<Arguments> provideAbbreviationTestCases() {
                         "Journal of Physics"
                 ),
                 Arguments.of(
-                        List.of(
+                        Set.of(
                                 new Abbreviation("中国物理学报", "物理学报", "ZWP"),
                                 new Abbreviation("中国物理学理", "物理学报报", "ZWP"),
                                 new Abbreviation("中国科学: 物理学", "中科物理", "ZKP")
@@ -447,7 +447,7 @@ static Stream<Arguments> provideAbbreviationTestCases() {
                         "中国物理学"
                 ),
                 Arguments.of(
-                        List.of(
+                        Set.of(
                                 new Abbreviation("Zeitschrift für Chem", "Z. Phys. Chem.", "ZPC"),
                                 new Abbreviation("Zeitschrift für Chys", "Z. Angew. Chem.", "ZAC")
                         ),
@@ -464,7 +464,7 @@ static Stream<Arguments> provideAbbreviationTestCases() {
     void addCustomAbbreviationsWithEnabledState() {
         String sourceKey = "test-source";
 
-        repository.addCustomAbbreviations(List.of(
+        repository.addCustomAbbreviations(Set.of(
             new Abbreviation("Journal One", "J. One"),
             new Abbreviation("Journal Two", "J. Two")
         ), sourceKey, true);
@@ -479,7 +479,7 @@ void addCustomAbbreviationsWithEnabledState() {
     void disablingSourcePreventsAccessToAbbreviations() {
         String sourceKey = "test-source";
 
-        repository.addCustomAbbreviations(List.of(
+        repository.addCustomAbbreviations(Set.of(
             new Abbreviation("Unique Journal", "U. J.")
         ), sourceKey, true);
 
@@ -497,7 +497,7 @@ void disablingSourcePreventsAccessToAbbreviations() {
     void reenablingSourceRestoresAccessToAbbreviations() {
         String sourceKey = "test-source";
 
-        repository.addCustomAbbreviations(List.of(
+        repository.addCustomAbbreviations(Set.of(
             new Abbreviation("Disabled Journal", "D. J.")
         ), sourceKey, true);
 
@@ -545,11 +545,11 @@ void multipleSourcesCanBeToggled() {
         String sourceKey1 = "source-1-special";
         String sourceKey2 = "source-2-special";
 
-        testRepo.addCustomAbbreviations(List.of(
+        testRepo.addCustomAbbreviations(Set.of(
             new Abbreviation("Unique Journal Source One XYZ", "UniqueJS1")
         ), sourceKey1, true);
 
-        testRepo.addCustomAbbreviations(List.of(
+        testRepo.addCustomAbbreviations(Set.of(
             new Abbreviation("Unique Journal Source Two ABC", "UniqueJS2")
         ), sourceKey2, true);
 
@@ -624,15 +624,15 @@ void getAllAbbreviationsWithSourcesReturnsCorrectSources() {
 
         testRepo.getCustomAbbreviations().clear();
 
-        testRepo.addCustomAbbreviations(List.of(
+        testRepo.addCustomAbbreviations(Set.of(
             AMERICAN_JOURNAL,
             ACS_MATERIALS,
             ANTIOXIDANTS,
             PHYSICAL_REVIEW
         ), JournalAbbreviationRepository.BUILTIN_LIST_ID, true);
 
         String customSource = "test-custom";
-        testRepo.addCustomAbbreviations(List.of(
+        testRepo.addCustomAbbreviations(Set.of(
             new Abbreviation("Custom Journal", "Cust. J.")
         ), customSource, true);
 
@@ -657,7 +657,7 @@ void getAllAbbreviationsWithSourcesReturnsCorrectSources() {
         assertTrue(customAbbr.isPresent(), "Should find custom abbreviation with source");
         assertEquals("Custom Journal", customAbbr.get().getAbbreviation().getName());
 
-        for (Abbreviation abbr : List.of(AMERICAN_JOURNAL, ACS_MATERIALS, ANTIOXIDANTS, PHYSICAL_REVIEW)) {
+        for (Abbreviation abbr : Set.of(AMERICAN_JOURNAL, ACS_MATERIALS, ANTIOXIDANTS, PHYSICAL_REVIEW)) {
             boolean found = allWithSources.stream()
                            .anyMatch(aws -> JournalAbbreviationRepository.BUILTIN_LIST_ID.equals(aws.getSource()) && 
                                      abbr.getName().equals(aws.getAbbreviation().getName()));