minor-code-updates-2 (#13494)

* Refine JavaDoc comment

* Use _

* Streamline ++ usage

* Use _

* Update jablib/src/main/java/org/jabref/model/entry/BibEntry.java

Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>

* Refine loop

---------

Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>

Author: koppor

jabgui/src/main/java/org/jabref/gui/util/UiTaskExecutor.java

@@ -182,7 +182,7 @@ public static <V> Task<V> getJavaFXTask(BackgroundTask<V> task) {
                         cancel();
                     }
                 });
-                setOnCancelled(event -> task.cancel());
+                setOnCancelled(_ -> task.cancel());
             }
 
             @Override
@@ -193,10 +193,10 @@ protected V call() throws Exception {
         };
         Runnable onRunning = task.getOnRunning();
         if (onRunning != null) {
-            javaTask.setOnRunning(event -> onRunning.run());
+            javaTask.setOnRunning(_ -> onRunning.run());
         }
         Consumer<V> onSuccess = task.getOnSuccess();
-        javaTask.setOnSucceeded(event -> {
+        javaTask.setOnSucceeded(_ -> {
             // Set to 100% completed on completion
             task.updateProgress(1, 1);
 
@@ -206,7 +206,7 @@ protected V call() throws Exception {
         });
         Consumer<Exception> onException = task.getOnException();
         if (onException != null) {
-            javaTask.setOnFailed(event -> onException.accept(convertToException(javaTask.getException())));
+            javaTask.setOnFailed(_ -> onException.accept(convertToException(javaTask.getException())));
         }
         return javaTask;
     }

jablib/src/main/java/org/jabref/logic/search/IndexManager.java

@@ -59,7 +59,7 @@ public IndexManager(BibDatabaseContext databaseContext,
         this.taskExecutor = executor;
         this.databaseContext = databaseContext;
         this.shouldIndexLinkedFiles = preferences.getFilePreferences().fulltextIndexLinkedFilesProperty();
-        this.preferencesListener = (observable, oldValue, newValue) -> bindToPreferences(newValue);
+        this.preferencesListener = (_, _, newValue) -> bindToPreferences(newValue);
         this.shouldIndexLinkedFiles.addListener(preferencesListener);
 
         bibFieldsIndexer = new BibFieldsIndexer(preferences.getBibEntryPreferences(), databaseContext, postgreServer.getConnection());

jablib/src/main/java/org/jabref/logic/search/indexing/BibFieldsIndexer.java

@@ -5,6 +5,7 @@
 import java.sql.SQLException;
 import java.util.Arrays;
 import java.util.Collection;
+import java.util.List;
 import java.util.Map;
 import java.util.Optional;
 import java.util.Set;
@@ -164,25 +165,25 @@ public void updateOnStart(BackgroundTask<?> task) {
         addToIndex(databaseContext.getDatabase().getEntries(), task);
     }
 
-    public void addToIndex(Collection<BibEntry> entries, BackgroundTask<?> task) {
-        if (entries.size() > 1) {
+    public void addToIndex(List<BibEntry> entries, BackgroundTask<?> task) {
+        int count = entries.size();
+        if (count > 1) {
             task.showToUser(true);
             task.setTitle(Localization.lang("Indexing bib fields for %0", libraryName));
         }
-        int i = 1;
         long startTime = System.currentTimeMillis();
-        LOGGER.debug("Adding {} entries to index", entries.size());
-        for (BibEntry entry : entries) {
+        LOGGER.debug("Adding {} entries to index", count);
+        for (int i = 0; i < count; i++) {
             if (task.isCancelled()) {
                 LOGGER.debug("Indexing canceled");
                 return;
             }
+            BibEntry entry = entries.get(i);
             addToIndex(entry);
-            task.updateProgress(i, entries.size());
-            task.updateMessage(Localization.lang("%0 of %1 entries added to the index.", i, entries.size()));
-            i++;
+            task.updateProgress(i, count);
+            task.updateMessage(Localization.lang("%0 of %1 entries added to the index.", i, count));
         }
-        LOGGER.debug("Added {} entries to index in {} ms", entries.size(), System.currentTimeMillis() - startTime);
+        LOGGER.debug("Added {} entries to index in {} ms", count, System.currentTimeMillis() - startTime);
     }
 
     private void addToIndex(BibEntry bibEntry) {

jablib/src/main/java/org/jabref/model/entry/BibEntry.java

@@ -349,11 +349,12 @@ private Optional<String> genericGetResolvedFieldOrAlias(Field field, @Nullable B
                 Optional.of(database.resolveForStrings(result.get()));
     }
 
-    /**
-     * Returns this entry's ID. It is used internally to distinguish different BibTeX entries.
-     * <p>
-     * It is <em>not</em> the citation key (which is stored in the {@link InternalField#KEY_FIELD} and also known as BibTeX key).
-     */
+    /// Returns this entry's ID. It is used internally to distinguish different BibTeX entries.
+    //  It is **not** the citation key (which is stored in the {@link InternalField#KEY_FIELD} and also known as BibTeX key).
+    ///
+    /// This id changes on each run of JabRef (because it is currently generated as increasing number).
+    ///
+    /// For more stable ids, check {@link org.jabref.model.entry.SharedBibEntryData#getSharedID}
     public String getId() {
         return id;
     }