Added warning label that allows user to jump to already existing entry (#13390)

jayvardhanghildiyal · web-flow · commit 714e3ba0380d · 2025-07-04T16:39:57.000Z
* Added warning label that allows user to jump to already existing entry

* removed comment and changed hashmap definition

* pulled from main and updated CHANGELOG.md

* removed line 'requires jbibtex;' from the end of module-info.java

* shifted most code to viewmodel from view, removed unused initializeCreateEntry function

* removing and updating some logic. the functionality requested should now be functional

* removing some existing code and replacing it with validation logic. also added a new key in jabref_en.properties

* warning now displays if entry present in any active library. removed commented code and unused variables.

* changed return type of checkDOI function for handling null values safely.

* duplicate checks now happen in currently active library only. solved tooltip issue.

* validation badge now works as intended. adding padding to textfield hyperlink

* rectified checkstyle error
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,7 @@ Note that this project **does not** adhere to [Semantic Versioning](https://semv
 
 - We introduced a settings parameter to manage citations' relations local storage time-to-live with a default value set to 30 days. [#11189](https://github.com/JabRef/jabref/issues/11189)
 - We distribute arm64 images for Linux. [#10842](https://github.com/JabRef/jabref/issues/10842)
+- When adding an entry to a library, a warning is displayed if said entry already exists in an active library. [#13261](https://github.com/JabRef/jabref/issues/13261)
 - We added the field `monthfiled` to the default list of fields to resolve BibTeX-Strings for [#13375](https://github.com/JabRef/jabref/issues/13375)
 - We added a new ID based fetcher for [EuropePMC](https://europepmc.org/). [#13389](https://github.com/JabRef/jabref/pull/13389)
 - We added an initial [cite as you write](https://retorque.re/zotero-better-bibtex/citing/cayw/) endpoint. [#13187](https://github.com/JabRef/jabref/issues/13187)  
diff --git a/jabgui/src/main/java/org/jabref/gui/newentry/NewEntryView.java b/jabgui/src/main/java/org/jabref/gui/newentry/NewEntryView.java
@@ -10,12 +10,14 @@
 import javafx.scene.control.Button;
 import javafx.scene.control.ButtonType;
 import javafx.scene.control.ComboBox;
+import javafx.scene.control.Hyperlink;
 import javafx.scene.control.Label;
 import javafx.scene.control.RadioButton;
 import javafx.scene.control.Tab;
 import javafx.scene.control.TabPane;
 import javafx.scene.control.TextArea;
 import javafx.scene.control.TextField;
+import javafx.scene.control.TextInputControl;
 import javafx.scene.control.TitledPane;
 import javafx.scene.control.ToggleGroup;
 import javafx.scene.control.Tooltip;
@@ -27,6 +29,7 @@
 import org.jabref.gui.DialogService;
 import org.jabref.gui.LibraryTab;
 import org.jabref.gui.StateManager;
+import org.jabref.gui.fieldeditors.EditorValidator;
 import org.jabref.gui.preferences.GuiPreferences;
 import org.jabref.gui.search.SearchType;
 import org.jabref.gui.util.BaseDialog;
@@ -104,6 +107,8 @@ public class NewEntryView extends BaseDialog<BibEntry> {
     @FXML private TilePane entryCustom;
 
     @FXML private TextField idText;
+    @FXML private Tooltip idTextTooltip;
+    @FXML private Hyperlink idJumpLink;
     @FXML private RadioButton idLookupGuess;
     @FXML private RadioButton idLookupSpecify;
     @FXML private ComboBox<IdBasedFetcher> idFetcher;
@@ -260,7 +265,6 @@ private void initializeLookupIdentifier() {
         //       method (each automatically independently, or all through the same fetcher).
         idText.setPromptText(Localization.lang("Enter the reference identifier to search for."));
         idText.textProperty().bindBidirectional(viewModel.idTextProperty());
-        final String clipboardText = ClipBoardManager.getContents().trim();
 
         ToggleGroup toggleGroup = new ToggleGroup();
         idLookupGuess.setToggleGroup(toggleGroup);
@@ -272,9 +276,19 @@ private void initializeLookupIdentifier() {
             idLookupSpecify.selectedProperty().set(true);
         }
 
+        viewModel.populateDOICache();
+
         // [impl->req~newentry.clipboard.autofocus~1]
         Optional<Identifier> validClipboardId = extractValidIdentifierFromClipboard();
         if (validClipboardId.isPresent()) {
+            viewModel.duplicateDoiValidatorStatus().validProperty().addListener((_, _, isValid) -> {
+                if (isValid) {
+                    Tooltip.install(idText, idTextTooltip);
+                } else {
+                    Tooltip.uninstall(idText, idTextTooltip);
+                }
+            });
+            
             idText.setText(ClipBoardManager.getContents().trim());
             idText.selectAll();
 
@@ -301,8 +315,16 @@ private void initializeLookupIdentifier() {
         idFetcher.setValue(initialFetcher);
         idFetcher.setOnAction(_ -> preferences.setLatestIdFetcher(idFetcher.getValue().getName()));
 
+        idJumpLink.visibleProperty().bind(viewModel.duplicateDoiValidatorStatus().validProperty().not());
         idErrorInvalidText.visibleProperty().bind(viewModel.idTextValidatorProperty().not());
+        idErrorInvalidText.managedProperty().bind(viewModel.idTextValidatorProperty().not());
         idErrorInvalidFetcher.visibleProperty().bind(idLookupSpecify.selectedProperty().and(viewModel.idFetcherValidatorProperty().not()));
+
+        idJumpLink.setOnAction(_ -> libraryTab.showAndEdit(viewModel.getDuplicateEntry()));
+
+        TextInputControl textInput = idText;
+        EditorValidator validator = new EditorValidator(this.guiPreferences);
+        validator.configureValidation(viewModel.duplicateDoiValidatorStatus(), textInput);
     }
 
     private void initializeInterpretCitations() {
diff --git a/jabgui/src/main/java/org/jabref/gui/newentry/NewEntryViewModel.java b/jabgui/src/main/java/org/jabref/gui/newentry/NewEntryViewModel.java
@@ -1,6 +1,8 @@
 package org.jabref.gui.newentry;
 
+import java.util.HashMap;
 import java.util.List;
+import java.util.Map;
 import java.util.Objects;
 import java.util.Optional;
 
@@ -38,12 +40,17 @@
 import org.jabref.logic.importer.plaincitation.RuleBasedPlainCitationParser;
 import org.jabref.logic.importer.plaincitation.SeveralPlainCitationParser;
 import org.jabref.logic.l10n.Localization;
+import org.jabref.logic.layout.LayoutFormatter;
+import org.jabref.logic.layout.format.DOIStrip;
+import org.jabref.model.database.BibDatabaseContext;
 import org.jabref.model.entry.BibEntry;
+import org.jabref.model.entry.field.StandardField;
 import org.jabref.model.strings.StringUtil;
 import org.jabref.model.util.FileUpdateMonitor;
 
 import de.saxsys.mvvmfx.utils.validation.FunctionBasedValidator;
 import de.saxsys.mvvmfx.utils.validation.ValidationMessage;
+import de.saxsys.mvvmfx.utils.validation.ValidationStatus;
 import de.saxsys.mvvmfx.utils.validation.Validator;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -65,6 +72,7 @@ public class NewEntryViewModel {
 
     private final StringProperty idText;
     private final Validator idTextValidator;
+    private final Validator duplicateDoiValidator;
     private final ListProperty<IdBasedFetcher> idFetchers;
     private final ObjectProperty<IdBasedFetcher> idFetcher;
     private final Validator idFetcherValidator;
@@ -79,6 +87,8 @@ public class NewEntryViewModel {
     private final StringProperty bibtexText;
     private final Validator bibtexTextValidator;
     private Task<Optional<List<BibEntry>>> bibtexWorker;
+    private final Map<String, BibEntry> doiCache;
+    private BibEntry duplicateEntry;
 
     public NewEntryViewModel(GuiPreferences preferences,
                                     LibraryTab libraryTab,
@@ -97,12 +107,16 @@ public NewEntryViewModel(GuiPreferences preferences,
 
         executing = new SimpleBooleanProperty(false);
         executedSuccessfully = new SimpleBooleanProperty(false);
+        doiCache = new HashMap<>();
 
         idText = new SimpleStringProperty();
         idTextValidator = new FunctionBasedValidator<>(
             idText,
             StringUtil::isNotBlank,
             ValidationMessage.error(Localization.lang("You must specify an identifier.")));
+        duplicateDoiValidator = new FunctionBasedValidator<>(
+            idText,
+            input -> checkDOI(input).orElse(null));
         idFetchers = new SimpleListProperty<>(FXCollections.observableArrayList());
         idFetchers.addAll(WebFetchers.getIdBasedFetchers(preferences.getImportFormatPreferences(), preferences.getImporterPreferences()));
         idFetcher = new SimpleObjectProperty<>();
@@ -130,6 +144,41 @@ public NewEntryViewModel(GuiPreferences preferences,
         bibtexWorker = null;
     }
 
+    public void populateDOICache() {
+        doiCache.clear();
+        Optional<BibDatabaseContext> activeDatabase = stateManager.getActiveDatabase();
+
+        activeDatabase.map(BibDatabaseContext::getEntries)
+                    .ifPresent(entries -> {
+                        entries.forEach(entry -> {
+                            entry.getField(StandardField.DOI)
+                                 .ifPresent(doi -> {
+                                     doiCache.put(doi, entry);
+                                 });
+                        });
+                    });
+    }
+
+    public Optional<ValidationMessage> checkDOI(String doiInput) {
+        if (doiInput == null || doiInput.isBlank()) {
+            return Optional.empty();
+        }
+
+        LayoutFormatter doiStrip = new DOIStrip();
+        String normalized = doiStrip.format(doiInput.toLowerCase());
+
+        if (doiCache.containsKey(normalized)) {
+            duplicateEntry = doiCache.get(normalized);
+            return Optional.of(ValidationMessage.warning(Localization.lang("Entry already exists in a library")));
+        }
+
+        return Optional.empty();
+    }
+
+    public BibEntry getDuplicateEntry() {
+        return duplicateEntry;
+    }
+
     public ReadOnlyBooleanProperty executingProperty() {
         return executing;
     }
@@ -146,6 +195,10 @@ public ReadOnlyBooleanProperty idTextValidatorProperty() {
         return idTextValidator.getValidationStatus().validProperty();
     }
 
+    public ValidationStatus duplicateDoiValidatorStatus() {
+        return duplicateDoiValidator.getValidationStatus();
+    }
+
     public ListProperty<IdBasedFetcher> idFetchersProperty() {
         return idFetchers;
     }
diff --git a/jabgui/src/main/resources/org/jabref/gui/newentry/NewEntry.fxml b/jabgui/src/main/resources/org/jabref/gui/newentry/NewEntry.fxml
@@ -4,6 +4,7 @@
 <?import javafx.scene.control.ButtonType?>
 <?import javafx.scene.control.ComboBox?>
 <?import javafx.scene.control.DialogPane?>
+<?import javafx.scene.control.Hyperlink?>
 <?import javafx.scene.control.Label?>
 <?import javafx.scene.control.RadioButton?>
 <?import javafx.scene.control.Tab?>
@@ -16,6 +17,7 @@
 <?import javafx.scene.layout.TilePane?>
 <?import javafx.scene.layout.VBox?>
 <?import javafx.scene.text.Font?>
+<?import javafx.scene.layout.StackPane?>
 <DialogPane xmlns:fx="http://javafx.com/fxml/1" prefWidth="600" xmlns="http://javafx.com/javafx/8.0.171"
             fx:controller="org.jabref.gui.newentry.NewEntryView">
     <buttonTypes>
@@ -58,11 +60,14 @@
                     </Label>
                     <HBox alignment="CENTER_LEFT" spacing="10.0">
                         <Label text="%Identifier"/>
-                        <TextField fx:id="idText" prefHeight="30.0" HBox.hgrow="ALWAYS">
-                            <tooltip>
-                                <Tooltip text="%Specify the source identifier to look up."/>
-                            </tooltip>
-                        </TextField>
+                        <StackPane HBox.hgrow="ALWAYS">
+                            <TextField fx:id="idText" prefHeight="30.0" HBox.hgrow="ALWAYS">
+                                <tooltip>
+                                    <Tooltip fx:id="idTextTooltip" text="%Specify the source identifier to look up."/>
+                                </tooltip>
+                            </TextField>
+                            <Hyperlink fx:id="idJumpLink" StackPane.alignment="CENTER_RIGHT" text="%Jump to entry" visible="false" style="-fx-padding: 0 15 0 0;"/>
+                        </StackPane>
                     </HBox>
                     <VBox spacing="5.0">
                         <RadioButton fx:id="idLookupGuess" text="%Automatically determine identifier type">
diff --git a/jablib/src/main/java/org/jabref/logic/database/DuplicateCheck.java b/jablib/src/main/java/org/jabref/logic/database/DuplicateCheck.java
@@ -76,8 +76,8 @@ public DuplicateCheck(BibEntryTypesManager entryTypesManager) {
 
     private static boolean haveSameIdentifier(final BibEntry one, final BibEntry two) {
         return one.getFields().stream()
-                .filter(field -> field.getProperties().contains(FieldProperty.IDENTIFIER))
-                .anyMatch(field -> two.getField(field).map(content -> one.getField(field).orElseThrow().equals(content)).orElse(false));
+                  .filter(field -> field.getProperties().contains(FieldProperty.IDENTIFIER))
+                  .anyMatch(field -> two.getField(field).map(content -> one.getField(field).orElseThrow().equals(content)).orElse(false));
     }
 
     private static boolean haveDifferentEntryType(final BibEntry one, final BibEntry two) {
diff --git a/jablib/src/main/resources/l10n/JabRef_en.properties b/jablib/src/main/resources/l10n/JabRef_en.properties
@@ -2922,6 +2922,7 @@ Enter\ identifier...=Enter identifier...
 Enter\ identifier=Enter identifier
 Enter\ plain\ citations\ to\ parse,\ separated\ by\ blank\ lines.=Enter plain citations to parse, separated by blank lines.
 Enter\ the\ reference\ identifier\ to\ search\ for.=Enter the reference identifier to search for.
+Entry\ already\ exists\ in\ a\ library=Entry already exists in a library
 Failed\ to\ interpret\ citations.\nThe\ following\ error\ was\ encountered\:\n%0=Failed to interpret citations.\nThe following error was encountered:\n%0
 Failed\ to\ interpret\ citations=Failed to interpret citations
 Failed\ to\ lookup\ identifier=Failed to lookup identifier
@@ -2936,6 +2937,7 @@ Interpret\ citations...=Interpret citations...
 Interpret\ citations=Interpret citations
 Invalid\ result=Invalid result
 Invalid\ result\ returned=Invalid result returned
+Jump\ to\ entry=Jump to entry
 New\ Entry=New Entry
 Other\ types=Other types
 Parser=Parser

Original file line number	Diff line number	Diff line change
`@@ -76,8 +76,8 @@ public DuplicateCheck(BibEntryTypesManager entryTypesManager) {`
`76`	`76`
`77`	`77`	`private static boolean haveSameIdentifier(final BibEntry one, final BibEntry two) {`
`78`	`78`	`return one.getFields().stream()`
`79`		`- .filter(field -> field.getProperties().contains(FieldProperty.IDENTIFIER))`
`80`		`- .anyMatch(field -> two.getField(field).map(content -> one.getField(field).orElseThrow().equals(content)).orElse(false));`
	`79`	`+ .filter(field -> field.getProperties().contains(FieldProperty.IDENTIFIER))`
	`80`	`+ .anyMatch(field -> two.getField(field).map(content -> one.getField(field).orElseThrow().equals(content)).orElse(false));`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`private static boolean haveDifferentEntryType(final BibEntry one, final BibEntry two) {`