Skip to content

Commit 0ff44ac

Browse files
committed
fix: resolve checkstyle violations and improve code quality
1 parent cfc3361 commit 0ff44ac

File tree

6 files changed

+3
-8
lines changed

6 files changed

+3
-8
lines changed

jabgui/src/main/java/org/jabref/gui/commonfxcontrols/SaveOrderConfigPanel.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package org.jabref.gui.commonfxcontrols;
22

33
import java.util.List;
4-
import java.util.stream.Collectors;
54

65
import javax.swing.undo.UndoManager;
76

jabgui/src/main/java/org/jabref/gui/preview/PreviewPreferences.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ public void setLayoutCyclePosition(int position) {
6868
}
6969

7070
public PreviewLayout getSelectedPreviewLayout() {
71-
if (layoutCycle.size() == 0
71+
if (layoutCycle.isEmpty()
7272
|| layoutCyclePosition.getValue() < 0
7373
|| layoutCyclePosition.getValue() >= layoutCycle.size()) {
7474
return getCustomPreviewLayout();

jablib/src/main/java/org/jabref/logic/importer/fetcher/DoiResolution.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import java.util.Locale;
1111
import java.util.Objects;
1212
import java.util.Optional;
13-
import java.util.stream.Collectors;
1413

1514
import org.jabref.logic.importer.FulltextFetcher;
1615
import org.jabref.logic.importer.ImportFormatPreferences;
@@ -150,7 +149,7 @@ private Optional<URL> citationMetaTag(Document html) {
150149
if (citationPdfUrl.isPresent()) {
151150
try {
152151
return Optional.of(URLUtil.create(citationPdfUrl.get()));
153-
} catch (MalformedURLException e) {
152+
} catch (MalformedURLException _) {
154153
return Optional.empty();
155154
}
156155
}
@@ -167,7 +166,7 @@ private Optional<URL> findEmbeddedLink(Document html, URL base) {
167166
try {
168167
URL url = base.toURI().resolve(pdfUrl.get()).toURL();
169168
return Optional.of(url);
170-
} catch (MalformedURLException | URISyntaxException e) {
169+
} catch (MalformedURLException | URISyntaxException _) {
171170
return Optional.empty();
172171
}
173172
}

jablib/src/main/java/org/jabref/logic/integrity/FileChecker.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import java.nio.file.Path;
55
import java.util.List;
66
import java.util.Optional;
7-
import java.util.stream.Collectors;
87

98
import org.jabref.logic.FilePreferences;
109
import org.jabref.logic.importer.util.FileFieldParser;

jablib/src/main/java/org/jabref/logic/l10n/Encodings.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ private Encodings() {
1515
static {
1616
ENCODINGS_DISPLAYNAMES = ENCODINGS_LIST.stream().map(Charset::displayName).distinct().toArray(String[]::new);
1717
ENCODINGS = ENCODINGS_LIST.toArray(new Charset[0]);
18-
1918
}
2019

2120
public static List<Charset> getCharsets() {

jablib/src/main/java/org/jabref/model/entry/BibEntry.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import java.util.function.BiFunction;
1919
import java.util.function.Predicate;
2020
import java.util.stream.Collectors;
21-
import java.util.stream.Stream;
2221

2322
import javafx.beans.Observable;
2423
import javafx.beans.property.ObjectProperty;

0 commit comments

Comments
 (0)