Release/2.0.0 (#8)

* Updated CryptoExchange.Net to version 9.0.0, see https://github.com/JKorf/CryptoExchange.Net/releases/
* Added support for Native AOT compilation
* Added RateLimitUpdated event
* Added SharedSymbol response property to all Shared interfaces response models returning a symbol name
* Added GenerateClientOrderId method to UsdFutures and Spot Shared clients
* Added OptionalExchangeParameters and Supported properties to EndpointOptions
* Added IBookTickerRestClient implementation to UsdFutures and Spot Shared clients
* Added ISpotOrderClientIdClient implementation to Spot Shared client
* Added IFuturesOrderClientIdClient implementation to UsdFutures Shared client
* Added IFuturesTriggerOrderRestClient implementation to UsdFutures Shared client
* Added IPositionModeRestClient implementation to UsdFutures Shared client
* Added IFuturesTpSlRestClient implementation to UsdFutures Shared client
* Added MaxLongLeverage and MaxShortLeverage to SharedFuturesSymbol response model
* Added takeProfitPrice and stopLossPrice support to Shared UsdFutures PlaceOrderAsync method
* Added TakeProfitPrice, StopLossPrice, TriggerPrice and IsTriggerOrder to SharedFuturesOrder model
* Added QuoteVolume property mapping to SharedSpotTicker response model
* Added restClient.UsdFuturesApi.Trading.CancelAllAfterAsync endpoint
* Added restClient.UsdFuturesApi.Account.SetPositionModeAsync and GetPositionModeAsync endpoints
* Added PositionMode properties to response models
* Added All property to retrieve all available environment on BitMartEnvironment
* Added CancelSource property to BitMartOrder model
* Refactored Shared clients quantity parameters and responses to use Shared Quantity
* Updated all IEnumerable response and model types to array response types
* Updated BitMartFuturesOrderUpdate response model
* Replaced BitMartApiCredentials with ApiCredentials
* Fixed incorrect DataTradeMode on certain Shared interface responses
* Removed Newtonsoft.Json dependency
* Removed legacy ISpotClient implementation
* Removed legacy AddBitMart(restOptions, socketOptions) DI overload
* Fixed some typos

Author: JKorf

.github/ISSUE_TEMPLATE/bug_report.md

@@ -16,5 +16,10 @@ What endpoints and subscriptions are called.
 **Expected behavior**
 A clear and concise description of what you expected to happen.
 
-**Debug logging**
-Add debug logging related to the issue.
+**Additional info**
+If the issue is with a specific endpoint please provide:
+response.RequestBody: 
+If possible enable the `options.Rest.OutputOriginalData` client options and provide:
+response.OriginalData: 
+
+If available provide related logging:

BitMart.Net.UnitTests/BitMartRestClientTests.cs

@@ -1,15 +1,14 @@
-using CryptoExchange.Net.Authentication;
 using CryptoExchange.Net.Clients;
-using CryptoExchange.Net.Converters.JsonNet;
 using NUnit.Framework;
 using System.Collections.Generic;
 using System.Net.Http;
 using BitMart.Net.Clients;
-using BitMart.Net.Objects;
 using Microsoft.Extensions.Configuration;
 using Microsoft.Extensions.DependencyInjection;
 using CryptoExchange.Net.Objects;
 using BitMart.Net.Interfaces.Clients;
+using CryptoExchange.Net.Authentication;
+using CryptoExchange.Net.Converters.SystemTextJson;
 
 namespace BitMart.Net.UnitTests
 {
@@ -19,7 +18,7 @@ public class BitMartRestClientTests
         [Test]
         public void CheckSignatureExample1()
         {
-            var authProvider = new BitMartAuthenticationProvider(new BitMartApiCredentials("XXX", "XXX", "XXX"));
+            var authProvider = new BitMartAuthenticationProvider(new ApiCredentials("XXX", "XXX", "XXX"));
             var client = (RestApiClient)new BitMartRestClient().SpotApi;
 
             CryptoExchange.Net.Testing.TestHelpers.CheckSignature(
@@ -36,7 +35,7 @@ public void CheckSignatureExample1()
                 {
                     { "symbol", "LTCBTC" },
                 },
-                DateTimeConverter.ParseFromLong(1499827319559),
+                DateTimeConverter.ParseFromDouble(1499827319559),
                 true,
                 false);
         }
@@ -119,10 +118,10 @@ public void TestConstructorConfiguration()
                 {
                     { "ApiCredentials:Key", "123" },
                     { "ApiCredentials:Secret", "456" },
-                    { "ApiCredentials:Passphrase", "000" },
+                    { "ApiCredentials:Pass", "000" },
                     { "Socket:ApiCredentials:Key", "456" },
                     { "Socket:ApiCredentials:Secret", "789" },
-                    { "Socket:ApiCredentials:Passphrase", "xxx" },
+                    { "Socket:ApiCredentials:Pass", "xxx" },
                     { "Rest:OutputOriginalData", "true" },
                     { "Socket:OutputOriginalData", "false" },
                     { "Rest:Proxy:Host", "host" },

BitMart.Net.UnitTests/BitMartRestIntegrationTests.cs

@@ -1,6 +1,8 @@
 using BitMart.Net.Clients;
 using BitMart.Net.Objects;
 using BitMart.Net.Objects.Options;
+using BitMart.Net.SymbolOrderBooks;
+using CryptoExchange.Net.Authentication;
 using CryptoExchange.Net.Testing;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
@@ -32,7 +34,7 @@ public override BitMartRestClient GetClient(ILoggerFactory loggerFactory)
             return new BitMartRestClient(null, loggerFactory, Options.Create(new BitMartRestOptions
             {
                 OutputOriginalData = true,
-                ApiCredentials = Authenticated ? new BitMartApiCredentials(key, sec, pass) : null
+                ApiCredentials = Authenticated ? new ApiCredentials(key, sec, pass) : null
             }));
         }
 
@@ -121,5 +123,12 @@ public async Task TestUsdFuturesTrading()
             await RunAndCheckResult(client => client.UsdFuturesApi.Trading.GetPositionRiskAsync(default, default), true);
             await RunAndCheckResult(client => client.UsdFuturesApi.Trading.GetUserTradesAsync("ETHUSDT", default, default, default), true);
         }
+
+        [Test]
+        public async Task TestOrderBooks()
+        {
+            await TestOrderBook(new BitMartSpotSymbolOrderBook("ETH_USDT"));
+            await TestOrderBook(new BitMartUsdFuturesSymbolOrderBook("ETHUSDT"));
+        }
     }
 }

BitMart.Net.UnitTests/BitMartSocketIntegrationTests.cs

@@ -0,0 +1,46 @@
+using BitMart.Net.Clients;
+using BitMart.Net.Objects.Models;
+using BitMart.Net.Objects.Options;
+using CryptoExchange.Net.Testing;
+using Microsoft.Extensions.Logging;
+using Microsoft.Extensions.Options;
+using NUnit.Framework;
+using System;
+using System.Threading.Tasks;
+
+namespace BitMart.Net.UnitTests
+{
+    [NonParallelizable]
+    internal class BitMartSocketIntegrationTests : SocketIntegrationTest<BitMartSocketClient>
+    {
+        public override bool Run { get; set; }
+
+        public BitMartSocketIntegrationTests()
+        {
+        }
+
+        public override BitMartSocketClient GetClient(ILoggerFactory loggerFactory)
+        {
+            var key = Environment.GetEnvironmentVariable("APIKEY");
+            var sec = Environment.GetEnvironmentVariable("APISECRET");
+            var pass = Environment.GetEnvironmentVariable("APIPASS");
+
+            Authenticated = key != null && sec != null;
+            return new BitMartSocketClient(Options.Create(new BitMartSocketOptions
+            {
+                OutputOriginalData = true,
+                ApiCredentials = Authenticated ? new CryptoExchange.Net.Authentication.ApiCredentials(key, sec, pass) : null
+            }), loggerFactory);
+        }
+
+        [Test]
+        public async Task TestSubscriptions()
+        {
+            await RunAndCheckUpdate<BitMartTickerUpdate>((client, updateHandler) => client.SpotApi.SubscribeToBalanceUpdatesAsync(default , default), false, true);
+            await RunAndCheckUpdate<BitMartTickerUpdate>((client, updateHandler) => client.SpotApi.SubscribeToTickerUpdatesAsync("ETH_USDT", updateHandler, default), true, false);
+
+            await RunAndCheckUpdate<BitMartFuturesBalanceUpdate>((client, updateHandler) => client.UsdFuturesApi.SubscribeToBalanceUpdatesAsync(default, default), false, true);
+            await RunAndCheckUpdate<BitMartFuturesTickerUpdate>((client, updateHandler) => client.UsdFuturesApi.SubscribeToTickerUpdatesAsync("ETHUSDT", updateHandler, default), true, false);
+        } 
+    }
+}

BitMart.Net.UnitTests/Endpoints/UsdFutures/Account/GetPositionMode.txt

@@ -0,0 +1,11 @@
+GET
+/contract/private/get-position-mode
+true
+{
+  "code": 1000,
+  "trace": "0cc6f4c4-8b8c-4253-8e90-8d3195aa109c",
+  "message": "Ok",
+  "data": {
+    "position_mode":"one_way_mode"
+  }
+}

BitMart.Net.UnitTests/Endpoints/UsdFutures/Account/SetPositionMode.txt

@@ -0,0 +1,11 @@
+POST
+/contract/private/set-position-mode
+true
+{
+  "code": 1000,
+  "trace": "0cc6f4c4-8b8c-4253-8e90-8d3195aa109c",
+  "message": "Ok",
+  "data": {
+    "position_mode":"one_way_mode"
+  }
+}

BitMart.Net.UnitTests/Endpoints/UsdFutures/Trading/CancelAllAfter.txt

@@ -0,0 +1,13 @@
+POST
+/contract/private/cancel-all-after
+true
+{
+  "code": 1000,
+  "trace": "0cc6f4c4-8b8c-4253-8e90-8d3195aa109c",
+  "message": "Ok",
+  "data": {
+    "result": true,
+    "set_time": 1743064715,
+    "cancel_time": 1743064725
+  }
+}

BitMart.Net.UnitTests/RestRequestTests.cs

@@ -9,6 +9,7 @@
 using System.Linq;
 using BitMart.Net.Enums;
 using System.Drawing;
+using CryptoExchange.Net.Authentication;
 
 namespace BitMart.Net.UnitTests
 {
@@ -21,9 +22,9 @@ public async Task ValidateSpotAccountDataCalls()
             var client = new BitMartRestClient(opts =>
             {
                 opts.AutoTimestamp = false;
-                opts.ApiCredentials = new BitMartApiCredentials("123", "456", "XXX");
+                opts.ApiCredentials = new ApiCredentials("123", "456", "XXX");
             });
-            var tester = new RestRequestValidator<BitMartRestClient>(client, "Endpoints/Spot/Account", "https://api-cloud.bitmart.com", IsAuthenticated, stjCompare: true);
+            var tester = new RestRequestValidator<BitMartRestClient>(client, "Endpoints/Spot/Account", "https://api-cloud.bitmart.com", IsAuthenticated);
             await tester.ValidateAsync(client => client.SpotApi.Account.GetFundingBalancesAsync("123"), "GetFundingBalances", nestedJsonProperty: "data.wallet");
             await tester.ValidateAsync(client => client.SpotApi.Account.GetSpotBalancesAsync(), "GetSpotBalances", nestedJsonProperty: "data.wallet");
             await tester.ValidateAsync(client => client.SpotApi.Account.GetDepositAddressAsync("123"), "GetDepositAddress", nestedJsonProperty: "data");
@@ -42,9 +43,9 @@ public async Task ValidateSpotExchangeDataCalls()
             var client = new BitMartRestClient(opts =>
             {
                 opts.AutoTimestamp = false;
-                opts.ApiCredentials = new BitMartApiCredentials("123", "456", "XXX");
+                opts.ApiCredentials = new ApiCredentials("123", "456", "XXX");
             });
-            var tester = new RestRequestValidator<BitMartRestClient>(client, "Endpoints/Spot/ExchangeData", "https://api-cloud.bitmart.com", IsAuthenticated, stjCompare: true);
+            var tester = new RestRequestValidator<BitMartRestClient>(client, "Endpoints/Spot/ExchangeData", "https://api-cloud.bitmart.com", IsAuthenticated);
             await tester.ValidateAsync(client => client.SpotApi.ExchangeData.GetTickerAsync("123"), "GetTicker", nestedJsonProperty: "data");
             await tester.ValidateAsync(client => client.SpotApi.ExchangeData.GetAssetDepositWithdrawInfoAsync(), "GetAssetDepositWithdrawInfo", nestedJsonProperty: "data.currencies");
             await tester.ValidateAsync(client => client.SpotApi.ExchangeData.GetServerStatusAsync(), "GetServerStatus", nestedJsonProperty: "data.service");
@@ -60,9 +61,9 @@ public async Task ValidateSpotMarginDataCalls()
             var client = new BitMartRestClient(opts =>
             {
                 opts.AutoTimestamp = false;
-                opts.ApiCredentials = new BitMartApiCredentials("123", "456", "XXX");
+                opts.ApiCredentials = new ApiCredentials("123", "456", "XXX");
             });
-            var tester = new RestRequestValidator<BitMartRestClient>(client, "Endpoints/Spot/Margin", "https://api-cloud.bitmart.com", IsAuthenticated, stjCompare: true);
+            var tester = new RestRequestValidator<BitMartRestClient>(client, "Endpoints/Spot/Margin", "https://api-cloud.bitmart.com", IsAuthenticated);
             await tester.ValidateAsync(client => client.SpotApi.Margin.BorrowAsync("123", "123", 0.1m), "Borrow", nestedJsonProperty: "data");
             await tester.ValidateAsync(client => client.SpotApi.Margin.RepayAsync("123", "123", 0.1m), "Repay", nestedJsonProperty: "data");
             await tester.ValidateAsync(client => client.SpotApi.Margin.GetBorrowHistoryAsync("123"), "GetBorrowHistory", nestedJsonProperty: "data.records");
@@ -76,9 +77,9 @@ public async Task ValidateSpotSubAccountCalls()
             var client = new BitMartRestClient(opts =>
             {
                 opts.AutoTimestamp = false;
-                opts.ApiCredentials = new BitMartApiCredentials("123", "456", "XXX");
+                opts.ApiCredentials = new ApiCredentials("123", "456", "XXX");
             });
-            var tester = new RestRequestValidator<BitMartRestClient>(client, "Endpoints/Spot/SubAccount", "https://api-cloud.bitmart.com", IsAuthenticated, stjCompare: true);
+            var tester = new RestRequestValidator<BitMartRestClient>(client, "Endpoints/Spot/SubAccount", "https://api-cloud.bitmart.com", IsAuthenticated);
             await tester.ValidateAsync(client => client.SpotApi.SubAccount.TransferSubToMainForMainAsync("123", "123", 0.1m, "123"), "TransferSubToMainForMain");
             await tester.ValidateAsync(client => client.SpotApi.SubAccount.TransferSubToMainForSubAsync("123", "123", 0.1m), "TransferSubToMainForSub");
             await tester.ValidateAsync(client => client.SpotApi.SubAccount.TransferMainToSubAccountAsync("123", "123", 0.1m, "123"), "TransferMainToSubAccount");
@@ -95,9 +96,9 @@ public async Task ValidateSpotTradingDataCalls()
             var client = new BitMartRestClient(opts =>
             {
                 opts.AutoTimestamp = false;
-                opts.ApiCredentials = new BitMartApiCredentials("123", "456", "XXX");
+                opts.ApiCredentials = new ApiCredentials("123", "456", "XXX");
             });
-            var tester = new RestRequestValidator<BitMartRestClient>(client, "Endpoints/Spot/Trading", "https://api-cloud.bitmart.com", IsAuthenticated, stjCompare: true);
+            var tester = new RestRequestValidator<BitMartRestClient>(client, "Endpoints/Spot/Trading", "https://api-cloud.bitmart.com", IsAuthenticated);
             await tester.ValidateAsync(client => client.SpotApi.Trading.PlaceOrderAsync("123", OrderSide.Buy, OrderType.Market), "PlaceOrder", nestedJsonProperty: "data");
             await tester.ValidateAsync(client => client.SpotApi.Trading.CancelOrderAsync("123"), "CancelOrder");
             await tester.ValidateAsync(client => client.SpotApi.Trading.PlaceMarginOrderAsync("123", OrderSide.Buy, OrderType.Market), "PlaceMarginOrder", nestedJsonProperty: "data");
@@ -117,13 +118,15 @@ public async Task ValidateUsdFuturesAccountCalls()
             var client = new BitMartRestClient(opts =>
             {
                 opts.AutoTimestamp = false;
-                opts.ApiCredentials = new BitMartApiCredentials("123", "456", "XXX");
+                opts.ApiCredentials = new ApiCredentials("123", "456", "XXX");
             });
-            var tester = new RestRequestValidator<BitMartRestClient>(client, "Endpoints/UsdFutures/Account", "https://api-cloud-v2.bitmart.com", IsAuthenticated, stjCompare: true);
+            var tester = new RestRequestValidator<BitMartRestClient>(client, "Endpoints/UsdFutures/Account", "https://api-cloud-v2.bitmart.com", IsAuthenticated);
             //await tester.ValidateAsync(client => client.UsdFuturesApi.Account.GetBalancesAsync(), "GetBalances", nestedJsonProperty: "data");
             await tester.ValidateAsync(client => client.UsdFuturesApi.Account.GetTransferHistoryAsync(), "GetTransferHistory", nestedJsonProperty: "data.records");
             await tester.ValidateAsync(client => client.UsdFuturesApi.Account.TransferAsync("123", 0.1m, FuturesTransferType.ContractToSpot), "Transfer", nestedJsonProperty: "data");
             await tester.ValidateAsync(client => client.UsdFuturesApi.Account.SetLeverageAsync("123", 0.1m, MarginType.CrossMargin), "SetLeverage", nestedJsonProperty: "data");
+            await tester.ValidateAsync(client => client.UsdFuturesApi.Account.GetPositionModeAsync(), "GetPositionMode", nestedJsonProperty: "data");
+            await tester.ValidateAsync(client => client.UsdFuturesApi.Account.SetPositionModeAsync(PositionMode.HedgeMode), "SetPositionMode", nestedJsonProperty: "data");
         }
 
         [Test]
@@ -132,9 +135,9 @@ public async Task ValidateUsdFuturesExchangeDataCalls()
             var client = new BitMartRestClient(opts =>
             {
                 opts.AutoTimestamp = false;
-                opts.ApiCredentials = new BitMartApiCredentials("123", "456", "XXX");
+                opts.ApiCredentials = new ApiCredentials("123", "456", "XXX");
             });
-            var tester = new RestRequestValidator<BitMartRestClient>(client, "Endpoints/UsdFutures/ExchangeData", "https://api-cloud-v2.bitmart.com", IsAuthenticated, stjCompare: true);
+            var tester = new RestRequestValidator<BitMartRestClient>(client, "Endpoints/UsdFutures/ExchangeData", "https://api-cloud-v2.bitmart.com", IsAuthenticated);
             await tester.ValidateAsync(client => client.UsdFuturesApi.ExchangeData.GetContractsAsync(), "GetContracts", nestedJsonProperty: "data.symbols");
             await tester.ValidateAsync(client => client.UsdFuturesApi.ExchangeData.GetOrderBookAsync("123"), "GetOrderBook", nestedJsonProperty: "data");
             await tester.ValidateAsync(client => client.UsdFuturesApi.ExchangeData.GetOpenInterestAsync("123"), "GetOpenInterest", nestedJsonProperty: "data");
@@ -149,9 +152,9 @@ public async Task ValidateUsdFuturesSubAccountCalls()
             var client = new BitMartRestClient(opts =>
             {
                 opts.AutoTimestamp = false;
-                opts.ApiCredentials = new BitMartApiCredentials("123", "456", "XXX");
+                opts.ApiCredentials = new ApiCredentials("123", "456", "XXX");
             });
-            var tester = new RestRequestValidator<BitMartRestClient>(client, "Endpoints/UsdFutures/SubAccount", "https://api-cloud-v2.bitmart.com", IsAuthenticated, stjCompare: true);
+            var tester = new RestRequestValidator<BitMartRestClient>(client, "Endpoints/UsdFutures/SubAccount", "https://api-cloud-v2.bitmart.com", IsAuthenticated);
             await tester.ValidateAsync(client => client.UsdFuturesApi.SubAccount.TransferSubToMainForMainAsync("123", 0.1m, "123", "123"), "TransferSubToMainForMain");
             await tester.ValidateAsync(client => client.UsdFuturesApi.SubAccount.TransferMainToSubForMainAsync("123", 0.1m, "123", "123"), "TransferMainToSubForMain");
             await tester.ValidateAsync(client => client.UsdFuturesApi.SubAccount.TransferSubToMainForSubAsync("123", 0.1m, "123"), "TransferSubToMainForSub");
@@ -166,9 +169,9 @@ public async Task ValidateUsdFuturesTradingCalls()
             var client = new BitMartRestClient(opts =>
             {
                 opts.AutoTimestamp = false;
-                opts.ApiCredentials = new BitMartApiCredentials("123", "456", "XXX");
+                opts.ApiCredentials = new ApiCredentials("123", "456", "XXX");
             });
-            var tester = new RestRequestValidator<BitMartRestClient>(client, "Endpoints/UsdFutures/Trading", "https://api-cloud-v2.bitmart.com", IsAuthenticated, stjCompare: true);
+            var tester = new RestRequestValidator<BitMartRestClient>(client, "Endpoints/UsdFutures/Trading", "https://api-cloud-v2.bitmart.com", IsAuthenticated);
             await tester.ValidateAsync(client => client.UsdFuturesApi.Trading.GetOrderAsync("123", "123"), "GetOrder", nestedJsonProperty: "data");
             await tester.ValidateAsync(client => client.UsdFuturesApi.Trading.GetClosedOrdersAsync("123"), "GetClosedOrders", nestedJsonProperty: "data");
             await tester.ValidateAsync(client => client.UsdFuturesApi.Trading.GetOpenOrdersAsync(), "GetOpenOrders", nestedJsonProperty: "data");
@@ -186,6 +189,7 @@ public async Task ValidateUsdFuturesTradingCalls()
             await tester.ValidateAsync(client => client.UsdFuturesApi.Trading.EditTpSlOrderAsync("123", 0.1m, TriggerPriceType.FairPrice, PlanCategory.PositionTpSl, OrderType.Market), "EditTpSlOrder", nestedJsonProperty: "data");
             await tester.ValidateAsync(client => client.UsdFuturesApi.Trading.EditTriggerOrderAsync("123", 0.1m, TriggerPriceType.FairPrice, OrderType.Market), "EditPlanOrder", nestedJsonProperty: "data");
             await tester.ValidateAsync(client => client.UsdFuturesApi.Trading.EditPresetTriggerOrderAsync("123", "123", TriggerPriceType.FairPrice, TriggerPriceType.FairPrice, 0.1m, 0.1m), "EditPresetPlanOrder", nestedJsonProperty: "data");
+            await tester.ValidateAsync(client => client.UsdFuturesApi.Trading.CancelAllAfterAsync("ETHUSDT", TimeSpan.Zero), "CancelAllAfter", nestedJsonProperty: "data");
         }
 
         private bool IsAuthenticated(WebCallResult result)