Skip to content

Commit df413d4

Browse files
committed
phpmd warning: The method render uses an else expression
1 parent 4d1b4a0 commit df413d4

File tree

1 file changed

+15
-16
lines changed

1 file changed

+15
-16
lines changed

lib/jblond/Diff/Renderer/Text/Unified.php

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -53,22 +53,21 @@ public function render(): string
5353
"\n ",
5454
$this->diff->getArrayRange($this->diff->getOld(), $i1, $i2)
5555
) . "\n";
56-
} else {
57-
if ($tag == 'replace' || $tag == 'delete') {
58-
$diff .= '-' .
59-
implode(
60-
"\n-",
61-
$this->diff->getArrayRange($this->diff->getOld(), $i1, $i2)
62-
) . "\n";
63-
}
64-
65-
if ($tag == 'replace' || $tag == 'insert') {
66-
$diff .= '+' .
67-
implode(
68-
"\n+",
69-
$this->diff->getArrayRange($this->diff->getNew(), $j1, $j2)
70-
) . "\n";
71-
}
56+
continue;
57+
}
58+
if ($tag == 'replace' || $tag == 'delete') {
59+
$diff .= '-' .
60+
implode(
61+
"\n-",
62+
$this->diff->getArrayRange($this->diff->getOld(), $i1, $i2)
63+
) . "\n";
64+
}
65+
if ($tag == 'replace' || $tag == 'insert') {
66+
$diff .= '+' .
67+
implode(
68+
"\n+",
69+
$this->diff->getArrayRange($this->diff->getNew(), $j1, $j2)
70+
) . "\n";
7271
}
7372
}
7473
}

0 commit comments

Comments
 (0)