Skip to content

Commit bd6297c

Browse files
committed
Merge branch 'master' into php-dif-60
2 parents 24c8bb9 + 0a16fd1 commit bd6297c

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

README.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,12 +113,14 @@ Included is a light and a dark theme.
113113
* PHP Multibyte String
114114
* [jblond/php-cli](https://github.com/jblond/php-cli) (suggested)
115115

116-
## Issues and feature requests
116+
## Contribution, Issues and feature requests
117117

118118
If you found a bug, or have an idea for new functionality,
119119
feel free to report it on the issue tracker - just use search beforehand.
120120
[Issue tracker](https://github.com/JBlond/php-diff/issues)
121121

122+
You can also fork this repository and open a PR.
123+
122124
## Merge files using jQuery
123125

124126
Xiphe has build a jQuery plugin with that you can merge the compared files.

lib/jblond/Diff/Renderer/MainRenderer.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ protected function renderSequences(): array
190190
* @param int $endOld last line of the block in old to replace.
191191
* @param int $startNew First line of the block in new to replace.
192192
*/
193-
private function markInlineChange(array &$oldText, array &$newText, $startOld, $endOld, $startNew)
193+
private function markInlineChange(array &$oldText, array &$newText, int $startOld, int $endOld, int $startNew)
194194
{
195195
for ($iterator = 0; $iterator < ($endOld - $startOld); ++$iterator) {
196196
// Check each line in the block for differences.

lib/jblond/Diff/Renderer/Text/InlineCli.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ public function generateDiffHeader(): string
7171
*
7272
* @return string Start of the diff view.
7373
*/
74-
public function generateBlockHeader($changes): string
74+
public function generateBlockHeader(array $changes): string
7575
{
7676
return '';
7777
}

0 commit comments

Comments
 (0)