Skip to content

Commit 0ef6def

Browse files
committed
Fix code quality.
- Rename interface SubRenderer to SubRendererInterface. - Throw exception instead of aborting script execution with exit at cli example. - Changed line-endings from LF to CRLF of PHPUnit resource textInlineCli.txt (Check if these are changed by git!).
1 parent c323f77 commit 0ef6def

File tree

6 files changed

+10
-10
lines changed

6 files changed

+10
-10
lines changed

example/cli.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
if (php_sapi_name() !== 'cli') {
1010
echo 'This script demonstrates console support for the php-diff package.<br>';
1111
echo 'Please execute it from a cli interpreter.';
12-
exit;
12+
throw new RuntimeException('Script for CLI use only!');
1313
}
1414

1515

lib/jblond/Diff/Renderer/Html/Inline.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
namespace jblond\Diff\Renderer\Html;
66

77
use jblond\Diff\Renderer\MainRenderer;
8-
use jblond\Diff\Renderer\SubRenderer;
8+
use jblond\Diff\Renderer\SubRendererInterface;
99

1010
/**
1111
* Inline HTML diff generator for PHP DiffLib.
@@ -21,7 +21,7 @@
2121
* @version 2.0.0
2222
* @link https://github.com/JBlond/php-diff
2323
*/
24-
class Inline extends MainRenderer implements SubRenderer
24+
class Inline extends MainRenderer implements SubRendererInterface
2525
{
2626
/**
2727
* @var array Associative array containing the default options available for this renderer and their default

lib/jblond/Diff/Renderer/Html/SideBySide.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
namespace jblond\Diff\Renderer\Html;
66

77
use jblond\Diff\Renderer\MainRenderer;
8-
use jblond\Diff\Renderer\SubRenderer;
8+
use jblond\Diff\Renderer\SubRendererInterface;
99

1010
/**
1111
* Side by Side HTML diff generator for PHP DiffLib.
@@ -21,7 +21,7 @@
2121
* @version 2.0.0
2222
* @link https://github.com/JBlond/php-diff
2323
*/
24-
class SideBySide extends MainRenderer implements SubRenderer
24+
class SideBySide extends MainRenderer implements SubRendererInterface
2525
{
2626
/**
2727
* @var array Associative array containing the default options available for this renderer and their default

lib/jblond/Diff/Renderer/Html/Unified.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
namespace jblond\Diff\Renderer\Html;
66

77
use jblond\Diff\Renderer\MainRenderer;
8-
use jblond\Diff\Renderer\SubRenderer;
8+
use jblond\Diff\Renderer\SubRendererInterface;
99

1010
/**
1111
* Unified HTML diff generator for PHP DiffLib.
@@ -21,7 +21,7 @@
2121
* @version 2.0.0
2222
* @link https://github.com/JBlond/php-diff
2323
*/
24-
class Unified extends MainRenderer implements SubRenderer
24+
class Unified extends MainRenderer implements SubRendererInterface
2525
{
2626
/**
2727
* @var array Associative array containing the default options available for this renderer and their default

lib/jblond/Diff/Renderer/SubRenderer.php renamed to lib/jblond/Diff/Renderer/SubRendererInterface.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
* @version 2.0.0
1717
* @link https://github.com/JBlond/php-diff
1818
*/
19-
interface SubRenderer
19+
interface SubRendererInterface
2020
{
2121
/**
2222
* Render and return a diff-view with changes between two sequences.

lib/jblond/Diff/Renderer/Text/InlineCli.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
use jblond\cli\CliColors;
88
use jblond\Diff\Renderer\MainRenderer;
9-
use jblond\Diff\Renderer\SubRenderer;
9+
use jblond\Diff\Renderer\SubRendererInterface;
1010

1111
/**
1212
* Inline diff generator for PHP DiffLib.
@@ -20,7 +20,7 @@
2020
* @version 2.0.0
2121
* @link https://github.com/JBlond/php-diff
2222
*/
23-
class InlineCli extends MainRenderer implements SubRenderer
23+
class InlineCli extends MainRenderer implements SubRendererInterface
2424
{
2525
/**
2626
* @var array Associative array containing the default options available for this renderer and their default

0 commit comments

Comments
 (0)