Skip to content

Very short margin on OAuth token refresh #140

@vicdelfant

Description

@vicdelfant

It seems that an access token is only refreshed if it actually expired already, or will expire within the next 1 second:

return (int) $this->expiresAt - time() < 1;

This seems to be a very short window given that there can easily be a time difference between systems. Is there a specific reason that this was set to such a short timeframe, or would it be okay to submit a PR to change it to a minute? With the access tokens being valid for 1 hour, that's still plenty of margin.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions