Header Paths Issue

[flowb]

Hi,

Thank you for putting this together. Very excited to get going with it.

I think I found an issue with compiling a simple example. It looks like the specified plugin path might be getting ignored for part of the build phase.

Python 3.11.1 (heads/3.11-Derivative-dirty:82b0389147, Jan 25 2023, 22:34:27) [MSC v.1929 64 bit (AMD64)]

Building ...
Building ...
**********************************************************************
** Visual Studio 2022 Developer Command Prompt v17.6.0
** Copyright (c) 2022 Microsoft Corporation
**********************************************************************
[vcvarsall.bat] Environment initialized for: 'x64'

C:\Users\flo\OneDrive\Desktop\PluginProjects>cmake -B build -G Ninja -DPLUGIN_BUILDER_DIR=D:/git/PluginBuilder -DPLUGIN_DIR=Plugins/ -DCMAKE_BUILD_TYPE=Release
Building demoCHOP...
Compiling demoCHOP...
**********************************************************************
** Visual Studio 2022 Developer Command Prompt v17.6.0
** Copyright (c) 2022 Microsoft Corporation
**********************************************************************
[vcvarsall.bat] Environment initialized for: 'x64'

D:\plugbuildtests\PluginProjects\demoCHOP>cmake -B build -G Ninja -DPLUGIN_BUILDER_DIR=D:/git/PluginBuilder -DPLUGIN_DIR=Plugins/demoCHOP -DCMAKE_BUILD_TYPE=Release
-- The CXX compiler identification is MSVC 19.36.32532.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files/Microsoft Visual Studio/2022/Community/VC/Tools/MSVC/14.36.32532/bin/Hostx64/x64/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- INCLUDE_DIR: D:/TD/PluginBuilder/include
-- Configuring done (0.8s)
-- Generating done (0.0s)
-- Build files have been written to: D:/plugbuildtests/PluginProjects/demoCHOP/build

D:\plugbuildtests\PluginProjects\demoCHOP>ninja -C build
ninja: Entering directory `build'
[1/2] Building CXX object CMakeFiles\demoCHOP.dir\source\demoCHOP.cpp.obj
FAILED: CMakeFiles/demoCHOP.dir/source/demoCHOP.cpp.obj 
C:\PROGRA~1\MICROS~2\2022\COMMUN~1\VC\Tools\MSVC\1436~1.325\bin\Hostx64\x64\cl.exe  /nologo /TP -DdemoCHOP_EXPORTS -ID:\plugbuildtests\PluginProjects\demoCHOP\source -ID:\TD\PluginBuilder\include /DWIN32 /D_WINDOWS /EHsc /O2 /Ob2 /DNDEBUG -std:c++17 -MD /showIncludes /FoCMakeFiles\demoCHOP.dir\source\demoCHOP.cpp.obj /FdCMakeFiles\demoCHOP.dir\ /FS -c D:\plugbuildtests\PluginProjects\demoCHOP\source\demoCHOP.cpp
D:\plugbuildtests\PluginProjects\demoCHOP\source\demoCHOP.h(15): fatal error C1083: Cannot open include file: 'CHOP_CPlusPlusBase.h': No such file or directory
ninja: build stopped: subcommand failed.
Building demoCHOP...
D:\plugbuildtests\PluginProjects\demoCHOP>cmake -B build -G Ninja -DPLUGIN_BUILDER_DIR=D:/git/PluginBuilder -DPLUGIN_DIR=Plugins/demoCHOP -DCMAKE_BUILD_TYPE=Release
-- INCLUDE_DIR: D:/TD/PluginBuilder/include
-- Configuring done (0.0s)
-- Generating done (0.0s)
-- Build files have been written to: D:/plugbuildtests/PluginProjects/demoCHOP/build
python >>> 

I had specified d:/git/PluginBuilder in the setup, and it looks like it's properly called out in the invokation of cmake, however the INCLUDE_DIR in the build system checks appears to be hardcoded to d:/TD/PluginBuilder. Compile failed until I duplicated the repo to that path.

[keithlostracco]

Hi, sounds like the settings.ini isn't getting saved or loaded.

Can you take a screenshot after editing the settings DAT in the SetSettings.toe? Then if it appears to have saved the file (yellow warning symbol dissappears on the DAT), can you load PluginBuilder in a project navigate to PluginBuilder/Builder and take a screenshot of settings there?

Then paste both here?

(Technically you don't have edit the settings DAT in the SetSettings.toe you can do it in the Builder as well, I just made it so the installation process was clear)

[keithlostracco]

Sorry no need to do anything (except pull the latest commit...) When I set the value I forgot to use the cache flag and it wasn't getting overwritten by the command argument. I just removed it and made argument mandatory.