Skip to content

Commit a8e3e56

Browse files
authored
style17JULY2021 (#790)
1 parent ec36373 commit a8e3e56

File tree

6 files changed

+19
-20
lines changed

6 files changed

+19
-20
lines changed

dpnp/backend/include/dpnp_iface.hpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,8 @@ INP_DLLEXPORT void dpnp_all_c(const void* array, void* result, const size_t size
128128
* @param [in] atol_val The absolute tolerance parameter.
129129
*/
130130
template <typename _DataType1, typename _DataType2, typename _ResultType>
131-
INP_DLLEXPORT void dpnp_allclose_c(const void* array1_in, const void* array2_in, void* result1, const size_t size, double rtol, double atol);
131+
INP_DLLEXPORT void dpnp_allclose_c(
132+
const void* array1_in, const void* array2_in, void* result1, const size_t size, double rtol, double atol);
132133

133134
/**
134135
* @ingroup BACKEND_API

dpnp/backend/kernels/dpnp_krnl_linalg.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -418,7 +418,8 @@ void dpnp_qr_c(void* array1_in, void* result1, void* result2, void* result3, siz
418418
cl::sycl::vector_class<cl::sycl::event> depends(1);
419419
set_barrier_event(DPNP_QUEUE, depends);
420420

421-
event = mkl_lapack::geqrf(DPNP_QUEUE, size_m, size_n, in_a, lda, tau, geqrf_scratchpad, geqrf_scratchpad_size, depends);
421+
event =
422+
mkl_lapack::geqrf(DPNP_QUEUE, size_m, size_n, in_a, lda, tau, geqrf_scratchpad, geqrf_scratchpad_size, depends);
422423

423424
event.wait();
424425

@@ -453,8 +454,8 @@ void dpnp_qr_c(void* array1_in, void* result1, void* result2, void* result3, siz
453454
depends.clear();
454455
set_barrier_event(DPNP_QUEUE, depends);
455456

456-
event =
457-
mkl_lapack::orgqr(DPNP_QUEUE, size_m, size_m, nrefl, in_a, lda, tau, orgqr_scratchpad, orgqr_scratchpad_size, depends);
457+
event = mkl_lapack::orgqr(
458+
DPNP_QUEUE, size_m, size_m, nrefl, in_a, lda, tau, orgqr_scratchpad, orgqr_scratchpad_size, depends);
458459

459460
event.wait();
460461

dpnp/backend/kernels/dpnp_krnl_logic.cpp

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,8 @@ template <typename _DataType1, typename _DataType2, typename _ResultType>
7575
class dpnp_allclose_c_kernel;
7676

7777
template <typename _DataType1, typename _DataType2, typename _ResultType>
78-
void dpnp_allclose_c(const void* array1_in, const void* array2_in, void* result1, const size_t size, double rtol_val, double atol_val)
78+
void dpnp_allclose_c(
79+
const void* array1_in, const void* array2_in, void* result1, const size_t size, double rtol_val, double atol_val)
7980
{
8081
if (!array1_in || !result1)
8182
{
@@ -99,22 +100,20 @@ void dpnp_allclose_c(const void* array1_in, const void* array2_in, void* result1
99100
auto kernel_parallel_for_func = [=](cl::sycl::id<1> global_id) {
100101
size_t i = global_id[0];
101102

102-
if (std::abs(array1[i] - array2[i]) > (atol_val + rtol_val * std::abs(array2[i]))){
103-
104-
result[0]= false;
105-
103+
if (std::abs(array1[i] - array2[i]) > (atol_val + rtol_val * std::abs(array2[i])))
104+
{
105+
result[0] = false;
106106
}
107-
108107
};
109108

110109
auto kernel_func = [&](cl::sycl::handler& cgh) {
111-
cgh.parallel_for<class dpnp_allclose_c_kernel<_DataType1, _DataType2, _ResultType>>(gws, kernel_parallel_for_func);
110+
cgh.parallel_for<class dpnp_allclose_c_kernel<_DataType1, _DataType2, _ResultType>>(gws,
111+
kernel_parallel_for_func);
112112
};
113113

114114
event = DPNP_QUEUE.submit(kernel_func);
115115

116116
event.wait();
117-
118117
}
119118

120119
template <typename _DataType, typename _ResultType>

dpnp/backend/src/verbose.cpp

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ bool _is_verbose_mode_init = false;
3131

3232
bool is_verbose_mode()
3333
{
34-
if(!_is_verbose_mode_init)
34+
if (!_is_verbose_mode_init)
3535
{
3636
_is_verbose_mode = false;
3737
const char* env_var = std::getenv("DPNP_VERBOSE");
@@ -46,7 +46,7 @@ bool is_verbose_mode()
4646

4747
class barrierKernelClass;
4848

49-
void set_barrier_event(cl::sycl::queue queue, sycl::vector_class<sycl::event> & depends)
49+
void set_barrier_event(cl::sycl::queue queue, sycl::vector_class<sycl::event>& depends)
5050
{
5151
if (is_verbose_mode())
5252
{
@@ -62,11 +62,7 @@ void verbose_print(std::string header, cl::sycl::event first_event, cl::sycl::ev
6262
{
6363
auto first_event_end = first_event.get_profiling_info<sycl::info::event_profiling::command_end>();
6464
auto last_event_end = last_event.get_profiling_info<sycl::info::event_profiling::command_end>();
65-
std::cout << "DPNP_VERBOSE "
66-
<< header
67-
<< " Time: "
68-
<< (last_event_end - first_event_end)/1.0e9
69-
<< " s"
65+
std::cout << "DPNP_VERBOSE " << header << " Time: " << (last_event_end - first_event_end) / 1.0e9 << " s"
7066
<< std::endl;
7167
}
7268
}

dpnp/backend/src/verbose.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
#include <CL/sycl.hpp>
3131

3232
bool is_verbose_mode();
33-
void set_barrier_event(cl::sycl::queue queue, sycl::vector_class<sycl::event> & depends);
33+
void set_barrier_event(cl::sycl::queue queue, sycl::vector_class<sycl::event>& depends);
3434
void verbose_print(std::string header, cl::sycl::event first_event, cl::sycl::event last_event);
3535

3636
#endif // VERBOSE_H

tests/test_logic.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ def test_all(type, shape):
3737
dpnp_res = ia.all()
3838
numpy.testing.assert_allclose(dpnp_res, np_res)
3939

40+
4041
@pytest.mark.parametrize("type",
4142
[numpy.float64, numpy.float32, numpy.int64, numpy.int32],
4243
ids=['float64', 'float32', 'int64', 'int32'])
@@ -60,6 +61,7 @@ def test_allclose(type):
6061
dpnp_res = dpnp.allclose(dpnp_a, dpnp_b)
6162
numpy.testing.assert_allclose(dpnp_res, np_res)
6263

64+
6365
@pytest.mark.parametrize("type",
6466
[numpy.float64, numpy.float32, numpy.int64, numpy.int32, numpy.bool, numpy.bool_],
6567
ids=['float64', 'float32', 'int64', 'int32', 'bool', 'bool_'])

0 commit comments

Comments
 (0)