Skip to content

Commit 78179a2

Browse files
authored
Temporary disable failing tests for NaN input passed to dpnp.linalg.cond (#2454)
The PR mutes the `tests/test_linalg.py::TestCond::test_nan` tests temporary on Windows to unblock the internal CI.
1 parent 8cef740 commit 78179a2

File tree

3 files changed

+10
-4
lines changed

3 files changed

+10
-4
lines changed

dpnp/backend/extensions/lapack/getrf_batch.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ static sycl::event getrf_batch_impl(sycl::queue &exec_q,
116116
auto error_matrices_ids_size = error_matrices_ids.size();
117117
auto dev_info_size = static_cast<std::size_t>(py::len(dev_info));
118118
if (error_matrices_ids_size != dev_info_size) {
119-
throw py::value_error("The size of `dev_info` must be equal to" +
119+
throw py::value_error("The size of `dev_info` must be equal to " +
120120
std::to_string(error_matrices_ids_size) +
121121
", but currently it is " +
122122
std::to_string(dev_info_size) + ".");

dpnp/backend/extensions/lapack/getri_batch.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ static sycl::event getri_batch_impl(sycl::queue &exec_q,
114114
auto error_matrices_ids_size = error_matrices_ids.size();
115115
auto dev_info_size = static_cast<std::size_t>(py::len(dev_info));
116116
if (error_matrices_ids_size != dev_info_size) {
117-
throw py::value_error("The size of `dev_info` must be equal to" +
117+
throw py::value_error("The size of `dev_info` must be equal to " +
118118
std::to_string(error_matrices_ids_size) +
119119
", but currently it is " +
120120
std::to_string(dev_info_size) + ".");

dpnp/tests/test_linalg.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
from dpctl.utils import ExecutionPlacementError
77
from numpy.testing import (
88
assert_allclose,
9-
assert_almost_equal,
109
assert_array_equal,
1110
assert_equal,
1211
assert_raises,
@@ -20,12 +19,13 @@
2019
assert_dtype_allclose,
2120
generate_random_numpy_array,
2221
get_all_dtypes,
23-
get_complex_dtypes,
2422
get_float_complex_dtypes,
2523
get_integer_float_dtypes,
2624
has_support_aspect64,
2725
is_cpu_device,
2826
is_cuda_device,
27+
is_gpu_device,
28+
is_win_platform,
2929
numpy_version,
3030
)
3131
from .third_party.cupy import testing
@@ -334,6 +334,12 @@ def test_nan(self, p):
334334
# while OneMKL returns nans
335335
if is_cuda_device() and p in [-dpnp.inf, -1, 1, dpnp.inf, "fro"]:
336336
pytest.skip("Different behavior on CUDA")
337+
elif (
338+
is_gpu_device()
339+
and is_win_platform()
340+
and p in [-dpnp.inf, -1, 1, dpnp.inf, "fro"]
341+
):
342+
pytest.skip("SAT-7966")
337343
a = generate_random_numpy_array((2, 2, 2, 2))
338344
a[0, 0] = 0
339345
a[1, 1] = 0

0 commit comments

Comments
 (0)