Skip to content

Commit 6a27f70

Browse files
committed
small fixes in build and functions iface
1 parent b467748 commit 6a27f70

File tree

4 files changed

+61
-49
lines changed

4 files changed

+61
-49
lines changed

dpnp/backend/backend_iface.hpp

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,8 @@ INP_DLLEXPORT void custom_cov_c(void* array1_in, void* result1, size_t nrows, si
248248
*
249249
*/
250250
template <typename _DataType>
251-
INP_DLLEXPORT void custom_max_c(void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis);
251+
INP_DLLEXPORT void
252+
custom_max_c(void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis);
252253

253254
/**
254255
* @ingroup BACKEND_API
@@ -268,7 +269,8 @@ INP_DLLEXPORT void custom_max_c(void* array1_in, void* result1, size_t* shape, s
268269
*
269270
*/
270271
template <typename _DataType, typename _ResultType>
271-
INP_DLLEXPORT void custom_mean_c(void* array, void* result, size_t* shape, size_t ndim, size_t* axis, size_t naxis);
272+
INP_DLLEXPORT void
273+
custom_mean_c(void* array, void* result, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis);
272274

273275
/**
274276
* @ingroup BACKEND_API
@@ -288,7 +290,8 @@ INP_DLLEXPORT void custom_mean_c(void* array, void* result, size_t* shape, size_
288290
*
289291
*/
290292
template <typename _DataType, typename _ResultType>
291-
INP_DLLEXPORT void custom_median_c(void* array, void* result, size_t* shape, size_t ndim, size_t* axis, size_t naxis);
293+
INP_DLLEXPORT void
294+
custom_median_c(void* array, void* result, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis);
292295

293296
/**
294297
* @ingroup BACKEND_API
@@ -308,7 +311,8 @@ INP_DLLEXPORT void custom_median_c(void* array, void* result, size_t* shape, siz
308311
*
309312
*/
310313
template <typename _DataType>
311-
INP_DLLEXPORT void custom_min_c(void* array, void* result, size_t* shape, size_t ndim, size_t* axis, size_t naxis);
314+
INP_DLLEXPORT void
315+
custom_min_c(void* array, void* result, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis);
312316

313317
/**
314318
* @ingroup BACKEND_API
@@ -358,8 +362,8 @@ INP_DLLEXPORT void custom_argmin_c(void* array, void* result, size_t size);
358362
*
359363
*/
360364
template <typename _DataType, typename _ResultType>
361-
INP_DLLEXPORT void
362-
custom_std_c(void* array, void* result, size_t* shape, size_t ndim, size_t* axis, size_t naxis, size_t ddof);
365+
INP_DLLEXPORT void custom_std_c(
366+
void* array, void* result, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis, size_t ddof);
363367

364368
/**
365369
* @ingroup BACKEND_API
@@ -381,8 +385,8 @@ INP_DLLEXPORT void
381385
*
382386
*/
383387
template <typename _DataType, typename _ResultType>
384-
INP_DLLEXPORT void
385-
custom_var_c(void* array, void* result, size_t* shape, size_t ndim, size_t* axis, size_t naxis, size_t ddof);
388+
INP_DLLEXPORT void custom_var_c(
389+
void* array, void* result, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis, size_t ddof);
386390

387391
#if 0 // Example for OpenCL kernel
388392
template <typename _DataType>

dpnp/backend/custom_kernels_statistics.cpp

Lines changed: 45 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,10 @@ template <typename _DataType>
144144
class custom_max_c_kernel;
145145

146146
template <typename _DataType>
147-
void custom_max_c(void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis)
147+
void custom_max_c(void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis)
148148
{
149+
__attribute__((unused)) void* tmp = (void*)(axis + naxis);
150+
149151
_DataType* array_1 = reinterpret_cast<_DataType*>(array1_in);
150152
_DataType* result = reinterpret_cast<_DataType*>(result1);
151153

@@ -167,16 +169,17 @@ void custom_max_c(void* array1_in, void* result1, size_t* shape, size_t ndim, si
167169
#endif
168170
}
169171

170-
template void
171-
custom_max_c<double>(void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis);
172-
template void
173-
custom_max_c<float>(void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis);
174-
template void
175-
custom_max_c<long>(void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis);
176-
template void custom_max_c<int>(void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis);
172+
template void custom_max_c<double>(
173+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis);
174+
template void custom_max_c<float>(
175+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis);
176+
template void custom_max_c<long>(
177+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis);
178+
template void custom_max_c<int>(
179+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis);
177180

178181
template <typename _DataType, typename _ResultType>
179-
void custom_mean_c(void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis)
182+
void custom_mean_c(void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis)
180183
{
181184
_ResultType* result = reinterpret_cast<_ResultType*>(result1);
182185

@@ -200,16 +203,16 @@ void custom_mean_c(void* array1_in, void* result1, size_t* shape, size_t ndim, s
200203
}
201204

202205
template void custom_mean_c<double, double>(
203-
void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis);
204-
template void
205-
custom_mean_c<float, float>(void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis);
206-
template void
207-
custom_mean_c<long, double>(void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis);
208-
template void
209-
custom_mean_c<int, double>(void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis);
206+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis);
207+
template void custom_mean_c<float, float>(
208+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis);
209+
template void custom_mean_c<long, double>(
210+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis);
211+
template void custom_mean_c<int, double>(
212+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis);
210213

211214
template <typename _DataType, typename _ResultType>
212-
void custom_median_c(void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis)
215+
void custom_median_c(void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis)
213216
{
214217
_ResultType* result = reinterpret_cast<_ResultType*>(result1);
215218

@@ -240,19 +243,19 @@ void custom_median_c(void* array1_in, void* result1, size_t* shape, size_t ndim,
240243
}
241244

242245
template void custom_median_c<double, double>(
243-
void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis);
246+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis);
244247
template void custom_median_c<float, double>(
245-
void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis);
248+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis);
246249
template void custom_median_c<long, double>(
247-
void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis);
250+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis);
248251
template void custom_median_c<int, double>(
249-
void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis);
252+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis);
250253

251254
template <typename _DataType>
252255
class custom_min_c_kernel;
253256

254257
template <typename _DataType>
255-
void custom_min_c(void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis)
258+
void custom_min_c(void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis)
256259
{
257260
_DataType* array_1 = reinterpret_cast<_DataType*>(array1_in);
258261
_DataType* result = reinterpret_cast<_DataType*>(result1);
@@ -275,16 +278,18 @@ void custom_min_c(void* array1_in, void* result1, size_t* shape, size_t ndim, si
275278
#endif
276279
}
277280

278-
template void
279-
custom_min_c<double>(void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis);
280-
template void
281-
custom_min_c<float>(void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis);
282-
template void
283-
custom_min_c<long>(void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis);
284-
template void custom_min_c<int>(void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis);
281+
template void custom_min_c<double>(
282+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis);
283+
template void custom_min_c<float>(
284+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis);
285+
template void custom_min_c<long>(
286+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis);
287+
template void custom_min_c<int>(
288+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis);
285289

286290
template <typename _DataType, typename _ResultType>
287-
void custom_std_c(void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis, size_t ddof)
291+
void custom_std_c(
292+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis, size_t ddof)
288293
{
289294
_DataType* array1 = reinterpret_cast<_DataType*>(array1_in);
290295
_ResultType* result = reinterpret_cast<_ResultType*>(result1);
@@ -302,19 +307,20 @@ void custom_std_c(void* array1_in, void* result1, size_t* shape, size_t ndim, si
302307
}
303308

304309
template void custom_std_c<int, double>(
305-
void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis, size_t ddof);
310+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis, size_t ddof);
306311
template void custom_std_c<long, double>(
307-
void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis, size_t ddof);
312+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis, size_t ddof);
308313
template void custom_std_c<float, float>(
309-
void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis, size_t ddof);
314+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis, size_t ddof);
310315
template void custom_std_c<double, double>(
311-
void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis, size_t ddof);
316+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis, size_t ddof);
312317

313318
template <typename _DataType, typename _ResultType>
314319
class custom_var_c_kernel;
315320

316321
template <typename _DataType, typename _ResultType>
317-
void custom_var_c(void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis, size_t ddof)
322+
void custom_var_c(
323+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis, size_t ddof)
318324
{
319325
cl::sycl::event event;
320326
_DataType* array1 = reinterpret_cast<_DataType*>(array1_in);
@@ -362,10 +368,10 @@ void custom_var_c(void* array1_in, void* result1, size_t* shape, size_t ndim, si
362368
}
363369

364370
template void custom_var_c<int, double>(
365-
void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis, size_t ddof);
371+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis, size_t ddof);
366372
template void custom_var_c<long, double>(
367-
void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis, size_t ddof);
373+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis, size_t ddof);
368374
template void custom_var_c<float, float>(
369-
void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis, size_t ddof);
375+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis, size_t ddof);
370376
template void custom_var_c<double, double>(
371-
void* array1_in, void* result1, size_t* shape, size_t ndim, size_t* axis, size_t naxis, size_t ddof);
377+
void* array1_in, void* result1, const size_t* shape, size_t ndim, const size_t* axis, size_t naxis, size_t ddof);

setup.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -279,7 +279,8 @@
279279
"include_dirs": _mkl_include + _project_backend_dir + _dpctrl_include,
280280
"library_dirs": _mkl_libpath + _omp_libpath + _dpctrl_libpath,
281281
"runtime_library_dirs": _project_rpath + _mkl_rpath + _cmplr_rpath + _omp_rpath + _dpctrl_libpath,
282-
"extra_preargs": _project_cmplr_flag_sycl + _project_cmplr_flag_compatibility,
282+
"extra_preargs": _project_cmplr_flag_sycl,
283+
"extra_link_preargs": _project_cmplr_flag_compatibility,
283284
"extra_link_postargs": [],
284285
"libraries": _mkl_libs + _dpctrl_lib,
285286
"macros": _project_cmplr_macro,

utils/command_build_clib.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ def build_libraries(self, libraries):
8080
runtime_library_dirs = build_info.get("runtime_library_dirs")
8181
extra_preargs = build_info.get("extra_preargs")
8282
extra_link_postargs = build_info.get("extra_link_postargs")
83+
extra_link_preargs = build_info.get("extra_link_preargs")
8384
force_build = build_info.get("force_build")
8485
compiler = build_info.get("compiler")
8586
linker = build_info.get("linker")
@@ -121,7 +122,7 @@ def build_libraries(self, libraries):
121122
libraries=libraries,
122123
library_dirs=library_dirs,
123124
runtime_library_dirs=runtime_library_dirs,
124-
extra_preargs=extra_preargs,
125+
extra_preargs=extra_preargs + extra_link_preargs,
125126
extra_postargs=extra_link_postargs,
126127
debug=self.debug,
127128
build_temp=self.build_temp,

0 commit comments

Comments
 (0)