From 68172e80856da7f9d581bc62bef99d0a3a71a167 Mon Sep 17 00:00:00 2001 From: Niels Dekker Date: Wed, 27 Nov 2024 22:49:54 +0100 Subject: [PATCH] STYLE: Remove Initialize() calls on new point sets RegisterTwoPointSets When a point set is just created by `New()`, it is already properly initialized. - Follow-up to pull request https://github.com/InsightSoftwareConsortium/ITK/pull/4976 commit https://github.com/InsightSoftwareConsortium/ITK/commit/bc044c1dabfdefa186da6eaa0f7a768ab36be3a8 "STYLE: Remove p->Initialize() call after p = T::New() in example" --- src/Registration/Metricsv4/RegisterTwoPointSets/Code.cxx | 4 ---- src/Registration/Metricsv4/RegisterTwoPointSets/Code.py | 2 -- .../Metricsv4/RegisterTwoPointSets/RegisterTwoPointSets.ipynb | 2 -- 3 files changed, 8 deletions(-) diff --git a/src/Registration/Metricsv4/RegisterTwoPointSets/Code.cxx b/src/Registration/Metricsv4/RegisterTwoPointSets/Code.cxx index 3a55cee1c..d2463cac7 100644 --- a/src/Registration/Metricsv4/RegisterTwoPointSets/Code.cxx +++ b/src/Registration/Metricsv4/RegisterTwoPointSets/Code.cxx @@ -82,11 +82,7 @@ main(int argc, char * argv[]) using PointType = PointSetType::PointType; auto fixedPoints = PointSetType::New(); - fixedPoints->Initialize(); - auto movingPoints = PointSetType::New(); - movingPoints->Initialize(); - // two ellipses, one rotated slightly /* diff --git a/src/Registration/Metricsv4/RegisterTwoPointSets/Code.py b/src/Registration/Metricsv4/RegisterTwoPointSets/Code.py index 06a3238a9..298765131 100644 --- a/src/Registration/Metricsv4/RegisterTwoPointSets/Code.py +++ b/src/Registration/Metricsv4/RegisterTwoPointSets/Code.py @@ -35,8 +35,6 @@ def make_circles(l_dimension: int = 2): fixed_points = PointSetType.New() moving_points = PointSetType.New() - fixed_points.Initialize() - moving_points.Initialize() step = 0.1 for count in range(0, int(2 * pi / step) + 1): diff --git a/src/Registration/Metricsv4/RegisterTwoPointSets/RegisterTwoPointSets.ipynb b/src/Registration/Metricsv4/RegisterTwoPointSets/RegisterTwoPointSets.ipynb index 3c86600e6..2cb8b9969 100644 --- a/src/Registration/Metricsv4/RegisterTwoPointSets/RegisterTwoPointSets.ipynb +++ b/src/Registration/Metricsv4/RegisterTwoPointSets/RegisterTwoPointSets.ipynb @@ -54,8 +54,6 @@ "\n", " fixed_points = PointSetType.New()\n", " moving_points = PointSetType.New()\n", - " fixed_points.Initialize()\n", - " moving_points.Initialize()\n", "\n", " count = 0\n", " step = 0.1\n",