Skip to content

Commit f655202

Browse files
committed
build(docker): add VERSION build arg for emscripten-threads
Also fix non-threads VERSION build arg for latest debug builds.
1 parent f0891eb commit f655202

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

src/docker/itk-wasm-base/build.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ $exe $build_cmd $tag_flag quay.io/itkwasm/emscripten-base:latest-threads-$host_a
7070
--build-arg IMAGE=quay.io/itkwasm/emscripten-base \
7171
--build-arg HOST_ARCH=$host_arch \
7272
--build-arg CMAKE_BUILD_TYPE=Release \
73+
--build-arg VERSION=latest-threads \
7374
--build-arg VCS_REF=${VCS_REF} \
7475
--build-arg VCS_URL=${VCS_URL} \
7576
--build-arg BUILD_DATE=${BUILD_DATE} \
@@ -81,7 +82,7 @@ if $version_tag; then
8182
--build-arg IMAGE=quay.io/itkwasm/emscripten-base \
8283
--build-arg HOST_ARCH=$host_arch \
8384
--build-arg CMAKE_BUILD_TYPE=Release \
84-
--build-arg VERSION=${TAG} \
85+
--build-arg VERSION=${TAG}-threads \
8586
--build-arg VCS_REF=${VCS_REF} \
8687
--build-arg VCS_URL=${VCS_URL} \
8788
--build-arg BUILD_DATE=${BUILD_DATE} \
@@ -125,6 +126,7 @@ if $debug; then
125126
--build-arg HOST_ARCH=$host_arch \
126127
--build-arg CMAKE_BUILD_TYPE=Debug \
127128
--build-arg USE_DCMTK=OFF \
129+
--build-arg VERSION=latest-debug \
128130
--build-arg VCS_REF=${VCS_REF} \
129131
--build-arg VCS_URL=${VCS_URL} \
130132
--build-arg BUILD_DATE=${BUILD_DATE} \
@@ -150,6 +152,7 @@ if $debug; then
150152
--build-arg HOST_ARCH=$host_arch \
151153
--build-arg CMAKE_BUILD_TYPE=Debug \
152154
--build-arg USE_DCMTK=OFF \
155+
--build-arg VERSION=${TAG}-threads-debug \
153156
--build-arg VCS_REF=${VCS_REF} \
154157
--build-arg VCS_URL=${VCS_URL} \
155158
--build-arg BUILD_DATE=${BUILD_DATE} \

src/docker/itk-wasm/build.sh

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@ fi
6565
$exe $build_cmd --pull=false $tag_flag quay.io/itkwasm/emscripten:latest-threads-$host_arch \
6666
--build-arg IMAGE=quay.io/itkwasm/emscripten \
6767
--build-arg HOST_ARCH=$host_arch \
68+
--build-arg VERSION=latest-threads \
6869
--build-arg CMAKE_BUILD_TYPE=Release \
6970
--build-arg BASE_IMAGE=quay.io/itkwasm/emscripten-base \
7071
--build-arg BASE_TAG=latest-threads-$host_arch \
@@ -79,7 +80,7 @@ if $version_tag; then
7980
--build-arg CMAKE_BUILD_TYPE=Release \
8081
--build-arg BASE_IMAGE=quay.io/itkwasm/emscripten-base \
8182
--build-arg BASE_TAG=${TAG}-threads-$host_arch \
82-
--build-arg VERSION=${TAG} \
83+
--build-arg VERSION=${TAG}-threads \
8384
--build-arg VCS_REF=${VCS_REF} \
8485
--build-arg VCS_URL=${VCS_URL} \
8586
--build-arg BUILD_DATE=${BUILD_DATE} \
@@ -117,6 +118,7 @@ if $debug; then
117118
--build-arg IMAGE=quay.io/itkwasm/emscripten \
118119
--build-arg HOST_ARCH=$host_arch \
119120
--build-arg CMAKE_BUILD_TYPE=Debug \
121+
--build-arg VERSION=latest-debug \
120122
--build-arg BASE_TAG=latest-debug-$host_arch \
121123
--build-arg VCS_REF=${VCS_REF} \
122124
--build-arg VCS_URL=${VCS_URL} \
@@ -139,6 +141,7 @@ if $debug; then
139141
--build-arg HOST_ARCH=$host_arch \
140142
--build-arg CMAKE_BUILD_TYPE=Debug \
141143
--build-arg BASE_TAG=latest-threads-debug-$host_arch \
144+
--build-arg VERSION=latest-threads-debug \
142145
--build-arg VCS_REF=${VCS_REF} \
143146
--build-arg VCS_URL=${VCS_URL} \
144147
--build-arg BUILD_DATE=${BUILD_DATE} \
@@ -148,7 +151,7 @@ if $debug; then
148151
--build-arg IMAGE=quay.io/itkwasm/emscripten \
149152
--build-arg HOST_ARCH=$host_arch \
150153
--build-arg CMAKE_BUILD_TYPE=Debug \
151-
--build-arg VERSION=${TAG}-debug \
154+
--build-arg VERSION=${TAG}-threads-debug \
152155
--build-arg BASE_TAG=${TAG}-threads-debug-$host_arch \
153156
--build-arg VCS_REF=${VCS_REF} \
154157
--build-arg VCS_URL=${VCS_URL} \

0 commit comments

Comments
 (0)