const optimization on string parameters

[chuacw]

procedure TIdCmdTCPClient.DoReplyUnknownCommand(AContext: TIdContext; ALine: string) in IdCmdTCPClient

to change to

procedure TIdCmdTCPClient.DoReplyUnknownCommand(AContext: TIdContext; const ALine: string).

---

procedure TIdCmdTCPServer.DoReplyUnknownCommand(AContext: TIdContext; ALine: string);

to change to

procedure TIdCmdTCPServer.DoReplyUnknownCommand(AContext: TIdContext; const ALine: string);

in IdCmdTCPServer.pas

---

procedure TIdCommandHandler.DoCommand(const AData: string; AContext: TIdContext; AUnparsedParams: string);

to change to

procedure TIdCommandHandler.DoCommand(const AData: string; AContext: TIdContext; const AUnparsedParams: string);

and

procedure TIdCommandHandler.DoParseParams(AUnparsedParams: string; AParams: TStrings);

to change to

procedure TIdCommandHandler.DoParseParams(const AUnparsedParams: string; AParams: TStrings);

in IdCommandHandlers.pas

---

function TIdIOHandler.ReadLn(ATerminator: string; AByteEncoding: IIdTextEncoding
{$IFDEF STRING_IS_ANSI}; ADestEncoding: IIdTextEncoding = nil{$ENDIF}
): string;
{$IFDEF USE_CLASSINLINE}inline;{$ENDIF}

to change to

function TIdIOHandler.ReadLn(const ATerminator: string; AByteEncoding: IIdTextEncoding
{$IFDEF STRING_IS_ANSI}; ADestEncoding: IIdTextEncoding = nil{$ENDIF}
): string;
{$IFDEF USE_CLASSINLINE}inline;{$ENDIF}

and

function TIdIOHandler.ReadLnSplit(var AWasSplit: Boolean; ATerminator: string = LF;
ATimeout: Integer = IdTimeoutDefault; AMaxLineLength: Integer = -1;
AByteEncoding: IIdTextEncoding = nil
{$IFDEF STRING_IS_ANSI}; ADestEncoding: IIdTextEncoding = nil{$ENDIF}
): string;

to change to

function TIdIOHandler.ReadLnSplit(var AWasSplit: Boolean; const ATerminator: string = LF;
ATimeout: Integer = IdTimeoutDefault; AMaxLineLength: Integer = -1;
AByteEncoding: IIdTextEncoding = nil
{$IFDEF STRING_IS_ANSI}; ADestEncoding: IIdTextEncoding = nil{$ENDIF}
): string;

and

procedure TIdIOHandler.Capture(ADest: TStream; ADelim: string;
AUsesDotTransparency: Boolean = True; AByteEncoding: IIdTextEncoding = nil
{$IFDEF STRING_IS_ANSI}; ADestEncoding: IIdTextEncoding = nil{$ENDIF}
);

to change to

procedure TIdIOHandler.Capture(ADest: TStream; const ADelim: string;
AUsesDotTransparency: Boolean = True; AByteEncoding: IIdTextEncoding = nil
{$IFDEF STRING_IS_ANSI}; ADestEncoding: IIdTextEncoding = nil{$ENDIF}
);

in IdIOHandler.pas

---

function TIdTCPConnection.SendCmd(AOut: string; const AResponse: Array of Int16;
AEncoding: IIdTextEncoding = nil): Int16;

to change to

function TIdTCPConnection.SendCmd(const AOut: string; const AResponse: Array of Int16;
AEncoding: IIdTextEncoding = nil): Int16;

and

function TIdTCPConnection.SendCmd(AOut: string; const AResponse: Int16 = -1;
AEncoding: IIdTextEncoding = nil): Int16;

to change to

function TIdTCPConnection.SendCmd(const AOut: string; const AResponse: Int16 = -1;
AEncoding: IIdTextEncoding = nil): Int16;

and

function TIdTCPConnection.SendCmd(AOut: string; const AResponse: string;
AEncoding: IIdTextEncoding = nil): string;

to change to

function TIdTCPConnection.SendCmd(const AOut: string; const AResponse: string;
AEncoding: IIdTextEncoding = nil): string;

in IdTCPConnection.pas

---

All of the AURL parameters needs a const in IdHTTP.pas

[rlebeau]

Why? I don't want to make interface breaking changes that affect multiple components without good reason.

[chuacw]

Improve performance of Indy, so that the invisible calls to UAddStrRef and UStrClr, in addition to a try finally block are removed.

[rlebeau]

Most internet protocols have textual elements to them, so Indy is very heavily string-oriented and has a lot of string processing functionality. What you are asking for is not just a few select optimizations, but really a complete review of the entire codebase. We don't have the manpower for that level of effort.

[WhiteWind]

But this is not a complete review if codebase. It's just about adding const specifier to string parameters. And it doesn't break interface - it only changes the implementation of method by removing implicit try/finally block and refcounting on const pointer ср, 7 марта 2018 г., 4:34 Remy Lebeau <notifications@github.com>:

…

Most internet protocols have textual elements to them, so Indy is very heavily string-oriented and has a lot of string processing functionality. What you are asking for is not just a few select optimizations, but really a complete review of the entire codebase. We don't have the manpower for that level of effort. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#195 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABOM_Rtu0fdPe1alaqMpS5El3P6VEtU5ks5tbvLVgaJpZM4SbNmU> .

[rlebeau]

Yes, it would need to be a complete review. Like I said, Indy is pretty heavily string-oriented. Do you realize how many string parameters Indy actually has? A LOT. And yes, adding 'const' to string parameters is a DCU-breaking interface change. I try to keep interface changes to a minimum except in big releases. This would be too much of a sweeping change for the current release. However, there is a maintenance release currently in progress that already has some big sweeping changes in it, so I might consider this issue for that release, or it may have to wait for the next major version instead.