Skip to content

Commit 1fc929b

Browse files
author
IndominusByte
committed
improve code remove unused decoder issuer
1 parent b0b68c3 commit 1fc929b

File tree

1 file changed

+19
-24
lines changed

1 file changed

+19
-24
lines changed

fastapi_jwt_auth/auth_jwt.py

Lines changed: 19 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -484,13 +484,11 @@ def unset_refresh_cookies(self,response: Optional[Response] = None) -> None:
484484
domain=self._cookie_domain
485485
)
486486

487-
def _verify_and_get_jwt_optional_in_cookies(self,issuer: Optional[str] = None) -> "AuthJWT":
487+
def _verify_and_get_jwt_optional_in_cookies(self) -> "AuthJWT":
488488
"""
489489
Optionally check if cookies have a valid access token. if an access token present in
490490
cookies property _token will set. raises exception error when an access token is invalid
491491
and doesn't match with CSRF token double submit
492-
493-
:param issuer: expected issuer in the JWT
494492
"""
495493
cookie_key = self._access_cookie_key
496494
cookie = self._request.cookies.get(cookie_key)
@@ -506,7 +504,7 @@ def _verify_and_get_jwt_optional_in_cookies(self,issuer: Optional[str] = None) -
506504

507505
# set token from cookie and verify jwt
508506
self._token = cookie
509-
self.verify_jwt_optional_in_request(self._token,issuer)
507+
self.verify_jwt_optional_in_request(self._token)
510508

511509
decoded_token = self.get_raw_jwt()
512510

@@ -524,7 +522,6 @@ def _verify_and_get_jwt_optional_in_cookies(self,issuer: Optional[str] = None) -
524522
def _verify_and_get_jwt_in_cookies(
525523
self,
526524
type_token: str,
527-
issuer: Optional[str] = None,
528525
fresh: Optional[bool] = False
529526
) -> "AuthJWT":
530527
"""
@@ -533,7 +530,6 @@ def _verify_and_get_jwt_in_cookies(
533530
is invalid and doesn't match with CSRF token double submit
534531
535532
:param type_token: indicate token is access or refresh token
536-
:param issuer: expected issuer in the JWT
537533
:param fresh: check freshness token if True
538534
"""
539535
if type_token == 'access':
@@ -553,7 +549,7 @@ def _verify_and_get_jwt_in_cookies(
553549

554550
# set token from cookie and verify jwt
555551
self._token = cookie
556-
self.verify_jwt_in_request(self._token,type_token,'cookies',issuer,fresh)
552+
self.verify_jwt_in_request(self._token,type_token,'cookies',fresh)
557553

558554
decoded_token = self.get_raw_jwt()
559555

@@ -563,15 +559,14 @@ def _verify_and_get_jwt_in_cookies(
563559
if not hmac.compare_digest(csrf_cookie,decoded_token['csrf']):
564560
raise CSRFError(status_code=401,message="CSRF double submit tokens do not match")
565561

566-
def verify_jwt_optional_in_request(self,token: str, issuer: Optional[str] = None) -> None:
562+
def verify_jwt_optional_in_request(self,token: str) -> None:
567563
"""
568564
Optionally check if this request has a valid access token
569565
570566
:param token: The encoded JWT
571-
:param issuer: expected issuer in the JWT
572567
"""
573568
if token:
574-
self._verifying_token(token,issuer)
569+
self._verifying_token(token)
575570

576571
if token and self.get_raw_jwt(token)['type'] != 'access':
577572
raise AccessTokenRequired(status_code=422,message="Only access tokens are allowed")
@@ -581,7 +576,6 @@ def verify_jwt_in_request(
581576
token: str,
582577
type_token: str,
583578
token_from: str,
584-
issuer: Optional[str] = None,
585579
fresh: Optional[bool] = False
586580
) -> None:
587581
"""
@@ -590,9 +584,10 @@ def verify_jwt_in_request(
590584
:param token: The encoded JWT
591585
:param type_token: indicate token is access or refresh token
592586
:param token_from: indicate token from headers or cookies
593-
:param issuer: expected issuer in the JWT
594587
:param fresh: check freshness token if True
595588
"""
589+
issuer = self._decode_issuer if type_token == 'access' else None
590+
596591
if token:
597592
self._verifying_token(token,issuer)
598593

@@ -659,14 +654,14 @@ def jwt_required(self) -> None:
659654
"""
660655
if len(self._token_location) == 2:
661656
if self._token and self.jwt_in_headers:
662-
self.verify_jwt_in_request(self._token,'access','headers',self._decode_issuer)
657+
self.verify_jwt_in_request(self._token,'access','headers')
663658
if not self._token and self.jwt_in_cookies:
664-
self._verify_and_get_jwt_in_cookies('access',self._decode_issuer)
659+
self._verify_and_get_jwt_in_cookies('access')
665660
else:
666661
if self.jwt_in_headers:
667-
self.verify_jwt_in_request(self._token,'access','headers',self._decode_issuer)
662+
self.verify_jwt_in_request(self._token,'access','headers')
668663
if self.jwt_in_cookies:
669-
self._verify_and_get_jwt_in_cookies('access',self._decode_issuer)
664+
self._verify_and_get_jwt_in_cookies('access')
670665

671666
def jwt_optional(self) -> None:
672667
"""
@@ -676,14 +671,14 @@ def jwt_optional(self) -> None:
676671
"""
677672
if len(self._token_location) == 2:
678673
if self._token and self.jwt_in_headers:
679-
self.verify_jwt_optional_in_request(self._token,self._decode_issuer)
674+
self.verify_jwt_optional_in_request(self._token)
680675
if not self._token and self.jwt_in_cookies:
681-
self._verify_and_get_jwt_optional_in_cookies(self._decode_issuer)
676+
self._verify_and_get_jwt_optional_in_cookies()
682677
else:
683678
if self.jwt_in_headers:
684-
self.verify_jwt_optional_in_request(self._token,self._decode_issuer)
679+
self.verify_jwt_optional_in_request(self._token)
685680
if self.jwt_in_cookies:
686-
self._verify_and_get_jwt_optional_in_cookies(self._decode_issuer)
681+
self._verify_and_get_jwt_optional_in_cookies()
687682

688683
def jwt_refresh_token_required(self) -> None:
689684
"""
@@ -706,14 +701,14 @@ def fresh_jwt_required(self) -> None:
706701
"""
707702
if len(self._token_location) == 2:
708703
if self._token and self.jwt_in_headers:
709-
self.verify_jwt_in_request(self._token,'access','headers',self._decode_issuer,True)
704+
self.verify_jwt_in_request(self._token,'access','headers',True)
710705
if not self._token and self.jwt_in_cookies:
711-
self._verify_and_get_jwt_in_cookies('access',self._decode_issuer,True)
706+
self._verify_and_get_jwt_in_cookies('access',True)
712707
else:
713708
if self.jwt_in_headers:
714-
self.verify_jwt_in_request(self._token,'access','headers',self._decode_issuer,True)
709+
self.verify_jwt_in_request(self._token,'access','headers',True)
715710
if self.jwt_in_cookies:
716-
self._verify_and_get_jwt_in_cookies('access',self._decode_issuer,True)
711+
self._verify_and_get_jwt_in_cookies('access',True)
717712

718713
def get_raw_jwt(self,encoded_token: Optional[str] = None) -> Optional[Dict[str,Union[str,int,bool]]]:
719714
"""

0 commit comments

Comments
 (0)