-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
bugSomething isn't workingSomething isn't working
Description
As an INTER scientist when activating / deactivating my point detector, I would like my wiring tables to change accordingly. To this end, they have a custom function defined on the PDInBeam
parameter which should do the following:
def on_detector_change(pd_was_in_beam, pd_now_in_beam):
from genie_python import genie as g
g.set_instrument(None)
if pd_was_in_beam != pd_now_in_beam:
if pd_now_in_beam:
g.change_tables(<wiring old>, <detector_old>, <spectra_old>)
else:
g.change_tables(<wiring new>, <detector new>, <spectra new>)
return "DAE tables changed"
While fixing another issue on their beamline, I redefined the position of the PDZ axis which resulted in PDInBeam
to go from IN to OUT and should have automatically changed the wiring tables. However, INTER said the wiring tables hadn't actually changed. We should recreate the issue, investigate where this broke down and fix it.
Note: There was a message in the refl server log suggesting the above function actually had been called.
Acceptance Criteria
- Make sure wiring tables get changed correctly when parking/unparking PD with INTER config
- Make sure the above is true when the parked status changes because of redefining a motor axis
How to Test
verbose instructions for reviewer to test changes
(Add before making a PR)
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working