Skip to content

Wrap-up quiz M3 needs some maintainance #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArturoAmorQ opened this issue Feb 13, 2025 · 1 comment
Open

Wrap-up quiz M3 needs some maintainance #801

ArturoAmorQ opened this issue Feb 13, 2025 · 1 comment

Comments

@ArturoAmorQ
Copy link
Collaborator

There are a couple of things that I've noticed that should be updated:

  • As reported in this forum comment, we don't clarify in the instructions that at a first stage we expect students to use the whole dataset when comparing models (we later use nested cross-validation, also on the whole dataset);
  • We provide the students with a list of preprocessors to evaluate:
all_preprocessors = [
    None,
    StandardScaler(),
    MinMaxScaler(),
    QuantileTransformer(n_quantiles=100),
    PowerTransformer(method="box-cox"),
]

Even if it works for this small dataset, using "passthrough" is better than using None (I don't know if this behavior is documented somewhere in the scikit-learn doc).

@ArturoAmorQ
Copy link
Collaborator Author

Partially addressed in MR 91 in our private repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant