v1.0.1

Author: IMC-GER

README.md

@@ -45,18 +45,21 @@ For full functionality "Maximum avatar file size" in "ACP" > "Board configuratio
 
 ## Changelog
 
+### v1.0.1 (22-10-2022)
+- Code changes
+
 ### v1.0.0 (31-07-2022)
-- Add avatar resize
-- Add Version check
-- Add Controller for ACP template
+- Added avatar resize
+- Added version check
+- Added controller for ACP template
 - Update check system requirement
-- Bug in EXIF orientation handling 
+- Fixed EXIF orientation handling 
 
 ### v0.1.0 (31-05-2022)
-- Bug in migrations
+- Fixed migrations
 
 ### v0.0.4 (18-03-2022)
-- Cleanup Code
+- Cleanup code
 
 ### v0.0.3 (20-02-2022)
 - Code changes

imcger/imgupload/README.md

@@ -45,18 +45,21 @@ For full functionality "Maximum avatar file size" in "ACP" > "Board configuratio
 
 ## Changelog
 
+### v1.0.1 (22-10-2022)
+- Code changes
+
 ### v1.0.0 (31-07-2022)
-- Add avatar resize
-- Version check
-- Check system requirement
-- Controller for ACP template
-- Bug in EXIF orientation handling 
+- Added avatar resize
+- Added version check
+- Added controller for ACP template
+- Update check system requirement
+- Fixed EXIF orientation handling 
 
 ### v0.1.0 (31-05-2022)
-- Error in migrations
+- Fixed migrations
 
 ### v0.0.4 (18-03-2022)
-- Cleanup Code
+- Cleanup code
 
 ### v0.0.3 (20-02-2022)
 - Code changes

imcger/imgupload/acp/main_module.php

@@ -24,25 +24,25 @@ public function main($id, $mode)
 	{
 		global $phpbb_container;
 
-		/* Add ACP lang file */
+		// Add ACP lang file
 		$language = $phpbb_container->get('language');
 
-		/* Get an instance of the admin controller */
+		// Get an instance of the admin controller
 		$admin_controller = $phpbb_container->get('imcger.imgupload.admin.controller');
 
-		/* Make the $u_action url available in the admin controller */
+		// Make the $u_action url available in the admin controller
 		$admin_controller->set_page_url($this->u_action);
 
 		switch ($mode)
 		{
 			case 'settings':
-				/* Load a template from adm/style for our ACP page */
+				// Load a template from adm/style for our ACP page
 				$this->tpl_name = 'acp_imgupload_body';
 
-				/* Set the page title for our ACP page */
+				// Set the page title for our ACP page
 				$this->page_title = $language->lang('ACP_IMCGER_IMGUPLOAD_TITLE');
 
-				/* Load the display options handle in the admin controller */
+				// Load the display options handle in the admin controller
 				$admin_controller->display_options();
 			break;
 		}

imcger/imgupload/adm/style/acp_imgupload_body.html

@@ -10,25 +10,20 @@ <h1>{{ lang('ACP_IMCGER_IMGUPLOAD_TITLE') }}</h1>
 		<legend>{{ lang('ACP_IMCGER_SETTINGS_THUMB') }}</legend>
 		<dl>
 			<dt><label for="imcger_imgupload_tum_quality">{{ lang('ACP_IMCGER_THUMB_QUALITY') ~ lang('COLON') }}</label><br/><span>{{ lang('ACP_IMCGER_THUMB_QUALITY_DESC') }}</span></dt>
-			<dd><input type="number" id="imcger_imgupload_tum_quality" min="50" max="90" step="any" maxlength="3" name="imcger_imgupload_tum_quality" value="{{ IMCGER_TUM_QUALITY }}" /></dd>
+			<dd><input type="number" id="imcger_imgupload_tum_quality" min="50" max="90" step="any" maxlength="3" name="imcger_imgupload_tum_quality" value="{{ IMCGER_TUM_QUALITY }}"></dd>
 		</dl>
 	</fieldset>
 
 	<fieldset>
 		<legend>{{ lang('ACP_IMCGER_SETTINGS_IMAGE') }}</legend>
 		<dl>
 			<dt><label for="imcger_imgupload_img_quality">{{ lang('ACP_IMCGER_IMAGE_QUALITY') ~ lang('COLON') }}</label><br/><span>{{ lang('ACP_IMCGER_IMAGE_QUALITY_DESC') }}</span></dt>
-			<dd><input type="number" id="imcger_imgupload_img_quality" min="50" max="90" step="any" maxlength="3" name="imcger_imgupload_img_quality" value="{{ IMCGER_IMG_QUALITY }}" /></dd>
+			<dd><input type="number" id="imcger_imgupload_img_quality" min="50" max="90" step="any" maxlength="3" name="imcger_imgupload_img_quality" value="{{ IMCGER_IMG_QUALITY }}"></dd>
 		</dl>
 
 		<dl>
-			<dt><label for="imcger_imgupload_max_width">{{ lang('ACP_IMCGER_MAX_WIDTH') ~ lang('COLON') }}</label><br/><span>{{ lang('ACP_IMCGER_MAX_WIDTH_DESC') }}</span></dt>
-			<dd><input type="number" id="imcger_imgupload_max_width" min="0" max="9999999999" step="any" maxlength="10" name="imcger_imgupload_max_width" value="{{ IMCGER_MAX_WIDTH }}" /></dd>
-		</dl>
-
-		<dl>
-			<dt><label for="imcger_imgupload_max_height">{{ lang('ACP_IMCGER_MAX_HEIGTH') ~ lang('COLON') }}</label><br/><span>{{ lang('ACP_IMCGER_MAX_HEIGTH_DESC') }}</span></dt>
-			<dd><input type="number" id="imcger_imgupload_max_height" min="0" max="9999999999" step="any" maxlength="10" name="imcger_imgupload_max_height" value="{{ IMCGER_MAX_HEIGHT }}" /></dd>
+			<dt><label for="imcger_imgupload_max_width">{{ lang('ACP_IMCGER_MAX_SIZE') ~ lang('COLON') }}</label><br/><span>{{ lang('ACP_IMCGER_MAX_SIZE_DESC') }}</span></dt>
+			<dd><input type="number" id="imcger_imgupload_max_width" min="0" max="9999999999" step="any" maxlength="10" name="imcger_imgupload_max_width" value="{{ IMCGER_MAX_WIDTH }}"> x <input type="number" id="imcger_imgupload_max_height" min="0" max="9999999999" step="any" maxlength="10" name="imcger_imgupload_max_height" value="{{ IMCGER_MAX_HEIGHT }}"> px</dd>
 		</dl>
 
 		<dl>
@@ -39,8 +34,8 @@ <h1>{{ lang('ACP_IMCGER_IMGUPLOAD_TITLE') }}</h1>
 		<dl>
 			<dt><label for="imcger_imgupload_del_exif">{{ lang('ACP_IMCGER_DEL_EXIF') }} {{ lang('COLON') }}</label><br><span>{{ lang('ACP_IMCGER_DEL_EXIF_DESC') }}</span></dt>
 			<dd>
-				<label><input type="radio" class="radio" id="imcger_imgupload_del_exif" name="imcger_imgupload_del_exif" value='1'{% if IMCGER_DEL_EXIF %} checked="checked"{% endif %} /> {{ lang('YES') }}</label>
-				<label><input type="radio" class="radio" name="imcger_imgupload_del_exif" value='0'{% if not IMCGER_DEL_EXIF %} checked="checked"{% endif %} /> {{ lang('NO') }}</label>
+				<label><input type="radio" class="radio" id="imcger_imgupload_del_exif" name="imcger_imgupload_del_exif" value='1'{% if IMCGER_DEL_EXIF %} checked="checked"{% endif %}> {{ lang('YES') }}</label>
+				<label><input type="radio" class="radio" name="imcger_imgupload_del_exif" value='0'{% if not IMCGER_DEL_EXIF %} checked="checked"{% endif %}> {{ lang('NO') }}</label>
 			</dd>
 		</dl>
 	</fieldset>
@@ -51,15 +46,15 @@ <h1>{{ lang('ACP_IMCGER_IMGUPLOAD_TITLE') }}</h1>
 			<dt><label for="imcger_imgupload_avatar_resize">{{ lang('ACP_IMCGER_AVATAR_RESIZE') }} {{ lang('COLON') }}</label><br><span>{{ lang('ACP_IMCGER_AVATAR_RESIZE_DESC') }}</span>
 				{% if IMCGER_AVATAR_FILESIZE_ISSET %}<br><span style="color: red">{{ lang('ACP_IMCGER_AVATAR_FILESIZE_ISSET') }}</span>{% endif %}</dt>
 			<dd>
-				<label><input type="radio" class="radio" id="imcger_imgupload_avatar_resize" name="imcger_imgupload_avatar_resize" value='1'{% if IMCGER_AVATAR_RESIZE %} checked="checked"{% endif %} /> {{ lang('YES') }}</label>
-				<label><input type="radio" class="radio" name="imcger_imgupload_avatar_resize" value='0'{% if not IMCGER_AVATAR_RESIZE %} checked="checked"{% endif %} /> {{ lang('NO') }}</label>
+				<label><input type="radio" class="radio" id="imcger_imgupload_avatar_resize" name="imcger_imgupload_avatar_resize" value='1'{% if IMCGER_AVATAR_RESIZE %} checked="checked"{% endif %}> {{ lang('YES') }}</label>
+				<label><input type="radio" class="radio" name="imcger_imgupload_avatar_resize" value='0'{% if not IMCGER_AVATAR_RESIZE %} checked="checked"{% endif %}> {{ lang('NO') }}</label>
 			</dd>
 		</dl>
 	</fieldset>
 
 	<fieldset class="submit-buttons">
-		<input class="button1" type="submit" id="submit" name="submit" value="{L_SUBMIT}" />
-		{S_FORM_TOKEN}
+		<input class="button1" type="submit" id="submit" name="submit" value="{L_SUBMIT}">
+		{{ S_FORM_TOKEN }}
 	</fieldset>
 
 </form>

imcger/imgupload/composer.json

@@ -3,8 +3,8 @@
 	"type": "phpbb-extension",
 	"description": "Using ImageMagick php librarie for resize image attachments and creating thumbnails.",
 	"homepage": "https://github.com/IMC-GER/phpBB-Image-upload-use-ImageMagick/tags",
-	"version": "1.0.0",
-	"time": "2022-07-31",
+	"version": "1.0.1",
+	"time": "2022-10-22",
 	"license": "GPL-2.0-only",
 	"authors": [{
 			"name": "Thorsten Ahlers",

imcger/imgupload/config/services.yml

@@ -1,6 +1,6 @@
 services:
     imcger.imgupload.admin.controller:
-        class: 'imcger\imgupload\controller\admin_controller'
+        class: imcger\imgupload\controller\admin_controller
         arguments:
             - '@config'
             - '@template'
@@ -11,5 +11,6 @@ services:
         arguments:
             - '@config'
             - '@language'
+            - '@upload_imagesize'
         tags:
             - { name: event.listener }

imcger/imgupload/controller/admin_controller.php

@@ -58,20 +58,20 @@ public function __construct(
 	 */
 	public function display_options()
 	{
-		/* Add ACP lang file */
+		// Add ACP lang file
 		$this->language->add_lang('common', 'imcger/imgupload');
 
 		add_form_key('imcger/imgupload');
 
-		/* Is the form being submitted to us? */
+		// Is the form being submitted to us?
 		if ($this->request->is_set_post('submit'))
 		{
 			if (!check_form_key('imcger/imgupload'))
 			{
 				trigger_error('FORM_INVALID' . adm_back_link($this->u_action), E_USER_WARNING);
 			}
 
-			/* Store the variable to the db */
+			// Store the variable to the db
 			$this->set_variable();
 
 			trigger_error($this->language->lang('ACP_IMCGER_SETTINGS_SAVED') . adm_back_link($this->u_action));