v1.4.0-b1

Author: IMC-GER

README.md

@@ -27,8 +27,8 @@ This extension can change the image size and/or the image file size. It rotate i
 - [Post - upload attachments](https://raw.githubusercontent.com/IMC-GER/images/main/screenshots/imgupload/en/imgupload_upload_en.jpg)
 
 ## Requirements
-- phpBB 3.2.4 or higher
-- php 7.1 or higher
+- phpBB 3.3.0 or higher
+- php 7.2 or higher
 - php ImageMagick library installed
 
 ## Compatible with
@@ -54,6 +54,12 @@ For full functionality "Maximum avatar file size" in "ACP" > "Board configuratio
 
 ## Changelog
 
+### v1.4.0 (21-12-2023)
+- Revised JS code
+- Fixed JS code in ACP don't work with radio buttons
+- Added security measures for Ajax request
+- Changed error handling for missing thumbnail file to a warning message
+
 ### v1.3.2 (13-12-2023)
 - Fixed error when upload none image file
 - Fixed upload aborts sporadically with large files

imcger/imgupload/README.md

@@ -27,8 +27,8 @@ This extension can change the image size and/or the image file size. It rotate i
 - [Post - upload attachments](https://raw.githubusercontent.com/IMC-GER/images/main/screenshots/imgupload/en/imgupload_upload_en.jpg)
 
 ## Requirements
-- phpBB 3.2.4 or higher
-- php 7.1 or higher
+- phpBB 3.3.0 or higher
+- php 7.2 or higher
 - php ImageMagick library installed
 
 ## Compatible with
@@ -54,6 +54,12 @@ For full functionality "Maximum avatar file size" in "ACP" > "Board configuratio
 
 ## Changelog
 
+### v1.4.0 (21-12-2023)
+- Revised JS code
+- Fixed JS code in ACP don't work with radio buttons
+- Added security measures for Ajax request
+- Changed error handling for missing thumbnail file to a warning message
+
 ### v1.3.2 (13-12-2023)
 - Fixed error when upload none image file
 - Fixed upload aborts sporadically with large files

imcger/imgupload/adm/style/acp_imgupload.js

@@ -1,6 +1,10 @@
-/*
- Image upload use ImageMagick
-------------------------------------- */
+/**
+ * Image upload use ImageMagick
+ * An extension for the phpBB Forum Software package.
+ *
+ * @copyright (c) 2022, Thorsten Ahlers
+ * @license GNU General Public License, version 2 (GPL-2.0)
+ */
 
 $('input[name=img_create_thumbnail]').on('change', function () {
 	if ($('input[name=img_create_thumbnail]:checked').last().val() == 1) {
@@ -13,4 +17,3 @@ $('input[name=img_create_thumbnail]').on('change', function () {
 });
 
 $('input[name=imcger_imgupload_image_inline]').trigger('change');
-

imcger/imgupload/composer.json

@@ -3,8 +3,8 @@
     "type": "phpbb-extension",
     "description": "Using ImageMagick php librarie for resize image attachments and creating thumbnails.",
     "homepage": "https://github.com/IMC-GER/phpBB-Image-upload-use-ImageMagick/tags",
-    "version": "1.3.2",
-    "time": "2023-12-13",
+    "version": "1.4.0",
+    "time": "2023-12-21",
     "license": "GPL-2.0-only",
     "authors": [
         {
@@ -20,14 +20,14 @@
     ],
     "require": {
         "php": ">=7.1.0",
-        "phpbb/phpbb": "^3.2.4",
+        "phpbb/phpbb": "^3.3.0",
         "composer/installers": "~1.0",
         "ext-imagick": "*"
     },
     "extra": {
         "display-name": "Image upload use ImageMagick",
         "soft-require": {
-            "phpbb/phpbb": "^3.2.4"
+            "phpbb/phpbb": "^3.3.0"
         },
         "version-check": {
             "host": "raw.githubusercontent.com",

imcger/imgupload/ext.php

@@ -20,16 +20,16 @@ class ext extends \phpbb\extension\base
 	protected $ext_name = 'imgupload';
 
 	/** @var min phpBB version */
-	protected $phpbb_min_version = '3.2.4';
+	protected $phpbb_min_version = '3.3.0';
 
 	/** @var max phpBB version (>= query) */
 	protected $phpbb_max_version = '4.0.0';
 
 	/** @var min PHP version */
-	protected $php_min_version = '7.1.0';
+	protected $php_min_version = '7.1.3';
 
 	/** @var max PHP version (>= query) */
-	protected $php_max_version = '8.3.0';
+	protected $php_max_version = '8.4.0';
 
 	/**
 	 * Check the minimum and maximum requirements.
@@ -66,7 +66,7 @@ public function is_enableable()
 			$error_message += [$language->lang('IMCGER_REQUIRE_PHP', $this->php_min_version, $this->php_max_version, PHP_VERSION),];
 		}
 
-		// When phpBB v3.2 use trigger_error() for message output. For v3.1 return false.
+		// When phpBB v3.2 use trigger_error() for message output.
 		if (phpbb_version_compare(PHPBB_VERSION, '3.3.0', '<') && !empty($error_message))
 		{
 			$message = implode('<br>', $error_message);

imcger/imgupload/language/de/common.php

@@ -39,7 +39,7 @@
 
 	// Language pack author
 	'ACP_IMCGER_LANG_DESC'			=> 'Deutsch (Du)',
-	'ACP_IMCGER_LANG_EXT_VER' 		=> '1.2.1',
+	'ACP_IMCGER_LANG_EXT_VER' 		=> '1.4.0',
 	'ACP_IMCGER_LANG_AUTHOR' 		=> 'IMC-Ger',
 
 	// Messages

imcger/imgupload/language/de_x_sie/common.php

@@ -39,7 +39,7 @@
 
 	// Language pack author
 	'ACP_IMCGER_LANG_DESC'			=> 'Deutsch (Sie)',
-	'ACP_IMCGER_LANG_EXT_VER' 		=> '1.2.1',
+	'ACP_IMCGER_LANG_EXT_VER' 		=> '1.4.0',
 	'ACP_IMCGER_LANG_AUTHOR' 		=> 'IMC-Ger',
 
 	// Messages

imcger/imgupload/language/en/common.php

@@ -39,7 +39,7 @@
 
 	// Language pack author
 	'ACP_IMCGER_LANG_DESC'			=> 'British English',
-	'ACP_IMCGER_LANG_EXT_VER' 		=> '1.2.1',
+	'ACP_IMCGER_LANG_EXT_VER' 		=> '1.4.0',
 	'ACP_IMCGER_LANG_AUTHOR' 		=> 'IMC-Ger',
 
 	// Messages

imcger/imgupload/styles/all/template/event/overall_footer_body_after.html

@@ -1,3 +1,10 @@
+{#
+	Image upload use ImageMagick
+	An extension for the phpBB Forum Software package.
+
+	@copyright (c) 2022, Thorsten Ahlers
+	@license GNU General Public License, version 2 (GPL-2.0)
+#}
 {% if S_SHOW_ATTACH_BOX and FILTERS %}
 {% INCLUDECSS '@imcger_imgupload/imgupload.css' %}
 <script>
@@ -67,7 +74,7 @@
 			return parseInt(b.attach_id) - parseInt(a.attach_id);
 		});
 
-		// Replace [attachment=index] with [attachment=imc-ger]
+		// Set marker at attachment thats rotated
 		let messageText = $('#message').val(),
 			regex		= new RegExp('\\[attachment=' + index + '\\]', 'gm');
 
@@ -78,7 +85,7 @@
 		phpbb.plupload.updateBbcode('removal', index);
 		phpbb.plupload.updateBbcode('add', 0);
 
-		// Replace [attachment=imc-ger] with [attachment=0]
+		// Replace attachment marker to index 0
 		messageText = $('#message').val();
 		messageText = messageText.replace(/\[attachment=imc-ger\]/gm, '[attachment=0]');