v1.4.4

- On migration, set max_filesize in extension_groups for images to 0.
- Change DB query for image extension in main listener

Author: IMC-GER

README.md

@@ -40,7 +40,7 @@ This extension can change the image size and/or the image file size. It rotate i
 Copy the extension to `phpBB3/ext/imcger/imgupload`.
 Go to "ACP" > "Customise" > "Manage extensions" and enable the "Image upload use ImageMagick" extension.
 
-For full functionality "Maximum file size" in "ACP" > "Posting" > "Attachment settings" must be set to 0. This is done automatically during the migration.
+For full functionality "Maximum file size" in "ACP" > "Posting" > "Attachment settings" must be set to 0 and in "ACP" > "Posting" > "Manage attachment extension groups" > "Settings in Images" > "Maximum file size" must be set to 0. This is done automatically during the migration.
 
 For full functionality "Maximum image dimensions" in "ACP" > "Posting" > "Attachment settings" must be set to 0. This is done automatically during the migration.
 For full functionality "Maximum avatar file size" in "ACP" > "Board configuration" > "Avatar settings" must be set to 0. This is done automatically during the migration.
@@ -54,6 +54,10 @@ For full functionality "Maximum avatar file size" in "ACP" > "Board configuratio
 
 ## Changelog
 
+### v1.4.4 (19-06-2024)
+- Added Set max filesize in attachment extension groups on migraton to 0.
+- Fixed Don't work in none standard attachment extension groups
+
 ### v1.4.3 (20-02-2024)
 - Fixed [Error in Post](https://www.phpbb.de/community/viewtopic.php?p=1426071#p1426071)
 

imcger/imgupload/README.md

@@ -40,7 +40,7 @@ This extension can change the image size and/or the image file size. It rotate i
 Copy the extension to `phpBB3/ext/imcger/imgupload`.
 Go to "ACP" > "Customise" > "Manage extensions" and enable the "Image upload use ImageMagick" extension.
 
-For full functionality "Maximum file size" in "ACP" > "Posting" > "Attachment settings" must be set to 0. This is done automatically during the migration.
+For full functionality "Maximum file size" in "ACP" > "Posting" > "Attachment settings" must be set to 0 and in "ACP" > "Posting" > "Manage attachment extension groups" > "Settings in Images" > "Maximum file size" must be set to 0. This is done automatically during the migration.
 
 For full functionality "Maximum image dimensions" in "ACP" > "Posting" > "Attachment settings" must be set to 0. This is done automatically during the migration.
 For full functionality "Maximum avatar file size" in "ACP" > "Board configuration" > "Avatar settings" must be set to 0. This is done automatically during the migration.
@@ -54,6 +54,10 @@ For full functionality "Maximum avatar file size" in "ACP" > "Board configuratio
 
 ## Changelog
 
+### v1.4.4 (19-06-2024)
+- Added Set max filesize in attachment extension groups on migraton to 0.
+- Fixed Don't work in none standard attachment extension groups
+
 ### v1.4.3 (20-02-2024)
 - Fixed [Error in Post](https://www.phpbb.de/community/viewtopic.php?p=1426071#p1426071)
 

imcger/imgupload/composer.json

@@ -3,8 +3,8 @@
     "type": "phpbb-extension",
     "description": "Using ImageMagick php librarie for resize image attachments and creating thumbnails.",
     "homepage": "https://github.com/IMC-GER/phpBB-Image-upload-use-ImageMagick/tags",
-    "version": "1.4.4-b1",
-    "time": "2024-06-18",
+    "version": "1.4.4",
+    "time": "2024-06-19",
     "license": "GPL-2.0-only",
     "authors": [
         {

imcger/imgupload/event/main_listener.php

@@ -113,19 +113,22 @@ public function set_template_vars()
 		$allowed_images = [];
 		$img_max_thumb_width = $this->config['imcger_imgupload_img_max_thumb_width'];
 
-		$sql_ary =  'SELECT group_id FROM ' . EXTENSION_GROUPS_TABLE	. ' WHERE group_name = "IMAGES"';
-		$result = $this->db->sql_query($sql_ary);
-		$arry = $this->db->sql_fetchrow($result);
-		$this->db-> sql_freeresult();
+		// Get image groups
+		$sql_ary =  'SELECT group_id FROM ' . EXTENSION_GROUPS_TABLE	. ' WHERE cat_id = 1';
+		$result_group = $this->db->sql_query($sql_ary);
 
-		$sql_ary =  'SELECT extension FROM ' . EXTENSIONS_TABLE	. ' WHERE group_id = ' . $arry['group_id'];
-		$result = $this->db->sql_query($sql_ary);
-
-		while ($row = $this->db->sql_fetchrow($result))
+		while ($group_row = $this->db->sql_fetchrow($result_group))
 		{
-			$allowed_images[] = $row['extension'];
+			// Get extension from image groups
+			$sql_ary =  'SELECT extension FROM ' . EXTENSIONS_TABLE	. ' WHERE group_id = ' . $group_row['group_id'];
+			$result_ext = $this->db->sql_query($sql_ary);
+
+			while ($row = $this->db->sql_fetchrow($result_ext))
+			{
+				$allowed_images[] = $row['extension'];
+			}
 		}
-		$this->db-> sql_freeresult();
+		$this->db->sql_freeresult();
 
 		$metadata_manager = $this->ext_manager->create_extension_metadata_manager('imcger/imgupload');
 

imcger/imgupload/migrations/v144.php

@@ -32,7 +32,7 @@ public function update_data()
 
 	public function reset_max_filesize()
 	{
-		$sql = 'UPDATE ' . EXTENSION_GROUPS_TABLE . ' SET max_filesize = 0 WHERE group_name = "IMAGES";';
+		$sql = 'UPDATE ' . EXTENSION_GROUPS_TABLE . ' SET max_filesize = 0 WHERE cat_id = 1;';
 		$this->db->sql_query($sql);
 	}
 }

imgupload_version.json

@@ -1,7 +1,7 @@
 {
     "stable": {
         "1.0": {
-            "current": "1.4.3",
+            "current": "1.4.4",
             "announcement": "https://www.phpbb.de/community/viewtopic.php?t=246009",
             "download": "https://github.com/IMC-GER/phpBB-Image-upload-use-ImageMagick/tags",
             "eol": null,