Skip to content

Commit 77ee7f1

Browse files
mgoldenbergHywan
authored andcommitted
refactor(indexeddb): change indexeddb_serializer::Result to use IndexeddbSerializerError
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
1 parent af90b7a commit 77ee7f1

File tree

8 files changed

+11
-14
lines changed

8 files changed

+11
-14
lines changed

crates/matrix-sdk-indexeddb/src/crypto_store/migrations/mod.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@ use tracing::info;
1919
use wasm_bindgen::JsValue;
2020

2121
use crate::{
22-
crypto_store::{indexeddb_serializer::IndexeddbSerializer, Result},
23-
IndexeddbCryptoStoreError,
22+
crypto_store::Result, indexeddb_serializer::IndexeddbSerializer, IndexeddbCryptoStoreError,
2423
};
2524

2625
mod old_keys;

crates/matrix-sdk-indexeddb/src/crypto_store/migrations/v10_to_v11.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ use wasm_bindgen::JsValue;
2020
use web_sys::{DomException, IdbTransactionMode};
2121

2222
use crate::crypto_store::{
23-
indexeddb_serializer::IndexeddbSerializer,
2423
keys,
2524
migrations::{do_schema_upgrade, old_keys, MigrationDb},
2625
};
26+
use crate::indexeddb_serializer::IndexeddbSerializer;
2727

2828
/// Migrate data from `backup_keys.backup_key_v1` to
2929
/// `backup_keys.backup_version_v1`.

crates/matrix-sdk-indexeddb/src/crypto_store/migrations/v5_to_v7.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,11 @@ use web_sys::{DomException, IdbTransactionMode};
2626

2727
use crate::{
2828
crypto_store::{
29-
indexeddb_serializer::IndexeddbSerializer,
3029
keys,
3130
migrations::{add_nonunique_index, do_schema_upgrade, old_keys, v7, MigrationDb},
3231
Result,
3332
},
33+
indexeddb_serializer::IndexeddbSerializer,
3434
IndexeddbCryptoStoreError,
3535
};
3636

crates/matrix-sdk-indexeddb/src/crypto_store/migrations/v7_to_v8.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,10 @@ use web_sys::{DomException, IdbTransactionMode};
2222

2323
use crate::{
2424
crypto_store::{
25-
indexeddb_serializer::IndexeddbSerializer,
2625
migrations::{do_schema_upgrade, old_keys, v7, MigrationDb},
2726
Result,
2827
},
28+
indexeddb_serializer::IndexeddbSerializer,
2929
IndexeddbCryptoStoreError,
3030
};
3131

crates/matrix-sdk-indexeddb/src/crypto_store/migrations/v8_to_v10.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,14 @@ use web_sys::{DomException, IdbTransactionMode};
2222

2323
use crate::{
2424
crypto_store::{
25-
indexeddb_serializer::IndexeddbSerializer,
2625
keys,
2726
migrations::{
2827
add_nonunique_index, do_schema_upgrade, old_keys,
2928
v7::InboundGroupSessionIndexedDbObject2, MigrationDb,
3029
},
3130
InboundGroupSessionIndexedDbObject, Result,
3231
},
32+
indexeddb_serializer::IndexeddbSerializer,
3333
IndexeddbCryptoStoreError,
3434
};
3535

crates/matrix-sdk-indexeddb/src/crypto_store/mod.rs

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ use async_trait::async_trait;
2121
use gloo_utils::format::JsValueSerdeExt;
2222
use hkdf::Hkdf;
2323
use indexed_db_futures::prelude::*;
24-
use indexeddb_serializer::IndexeddbSerializerError;
2524
use js_sys::Array;
2625
use matrix_sdk_crypto::{
2726
olm::{
@@ -48,12 +47,9 @@ use tracing::{debug, warn};
4847
use wasm_bindgen::JsValue;
4948
use web_sys::IdbKeyRange;
5049

51-
use self::indexeddb_serializer::MaybeEncrypted;
52-
use crate::crypto_store::{
53-
indexeddb_serializer::IndexeddbSerializer, migrations::open_and_upgrade_db,
54-
};
50+
use crate::crypto_store::migrations::open_and_upgrade_db;
51+
use crate::indexeddb_serializer::{IndexeddbSerializer, IndexeddbSerializerError, MaybeEncrypted};
5552

56-
mod indexeddb_serializer;
5753
mod migrations;
5854

5955
mod keys {

crates/matrix-sdk-indexeddb/src/crypto_store/indexeddb_serializer.rs renamed to crates/matrix-sdk-indexeddb/src/indexeddb_serializer.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,9 @@ use wasm_bindgen::JsValue;
2727
use web_sys::IdbKeyRange;
2828
use zeroize::Zeroizing;
2929

30-
use crate::{safe_encode::SafeEncode, IndexeddbCryptoStoreError};
30+
use crate::safe_encode::SafeEncode;
3131

32-
type Result<A, E = IndexeddbCryptoStoreError> = std::result::Result<A, E>;
32+
type Result<A, E = IndexeddbSerializerError> = std::result::Result<A, E>;
3333

3434
const BASE64: GeneralPurpose = GeneralPurpose::new(&alphabet::STANDARD, general_purpose::NO_PAD);
3535

crates/matrix-sdk-indexeddb/src/lib.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ use thiserror::Error;
66

77
#[cfg(feature = "e2e-encryption")]
88
mod crypto_store;
9+
#[cfg(feature = "e2e-encryption")]
10+
mod indexeddb_serializer;
911
mod safe_encode;
1012
#[cfg(feature = "e2e-encryption")]
1113
mod serialize_bool_for_indexeddb;

0 commit comments

Comments
 (0)