refactor(event cache): have EventCacheStore::clear_all_rooms_chunks delete all the events' contents

Author: bnjbvr

benchmarks/benches/room_bench.rs

@@ -173,8 +173,14 @@ pub fn load_pinned_events_benchmark(c: &mut Criterion) {
             assert_eq!(pinned_event_ids.len(), PINNED_EVENTS_COUNT);
 
             // Reset cache so it always loads the events from the mocked endpoint
-            // TODO: allow clearing the events table?
-            //client.event_cache().empty_immutable_cache().await;
+            client
+                .event_cache_store()
+                .lock()
+                .await
+                .unwrap()
+                .clear_all_rooms_chunks()
+                .await
+                .unwrap();
 
             let timeline = Timeline::builder(&room)
                 .with_focus(TimelineFocus::PinnedEvents {

crates/matrix-sdk-base/src/event_cache/store/traits.rs

@@ -98,7 +98,9 @@ pub trait EventCacheStore: AsyncTraitDeps {
     /// Clear persisted events for all the rooms.
     ///
     /// This will empty and remove all the linked chunks stored previously,
-    /// using the above [`Self::handle_linked_chunk_updates`] methods.
+    /// using the above [`Self::handle_linked_chunk_updates`] methods. It
+    /// must *also* delete all the events' content, if they were stored in a
+    /// separate table.
     async fn clear_all_rooms_chunks(&self) -> Result<(), Self::Error>;
 
     /// Given a set of event IDs, return the duplicated events along with their

crates/matrix-sdk-sqlite/src/event_cache_store.rs

@@ -863,7 +863,9 @@ impl EventCacheStore for SqliteEventCacheStore {
             .await?
             .with_transaction(move |txn| {
                 // Remove all the chunks, and let cascading do its job.
-                txn.execute("DELETE FROM linked_chunks", ())
+                txn.execute("DELETE FROM linked_chunks", ())?;
+                // Also clear all the events' contents.
+                txn.execute("DELETE FROM events", ())
             })
             .await?;
         Ok(())