From fa524d94c94fc3605fc897ff0401619a3e342008 Mon Sep 17 00:00:00 2001 From: Brandon Martel Date: Mon, 23 Jun 2025 13:33:18 -0500 Subject: [PATCH 1/3] fix: FIT-250: SplitChannel audio with spectrogram displaying blank space on waveform --- .../src/lib/AudioUltra/Visual/Renderer/WaveformRenderer.ts | 4 ++-- web/libs/editor/src/lib/AudioUltra/Visual/Visualizer.ts | 7 +++---- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/web/libs/editor/src/lib/AudioUltra/Visual/Renderer/WaveformRenderer.ts b/web/libs/editor/src/lib/AudioUltra/Visual/Renderer/WaveformRenderer.ts index d5decb357f78..027fbf06cada 100644 --- a/web/libs/editor/src/lib/AudioUltra/Visual/Renderer/WaveformRenderer.ts +++ b/web/libs/editor/src/lib/AudioUltra/Visual/Renderer/WaveformRenderer.ts @@ -105,7 +105,7 @@ export class WaveformRenderer implements Renderer { renderWave(context: RenderContext, channelNumber: number, layer: Layer, iStart: number, iEnd: number): boolean { const renderId = this.config.renderId; const audio = this.audio; - const height = this.config.waveHeight / (audio?.channelCount ?? 1); + const height = this.config.waveHeight; const scrollLeftPx = context.scrollLeftPx; const zoom = context.zoom; const amp = this.config.amp ?? 1; @@ -139,7 +139,7 @@ export class WaveformRenderer implements Renderer { let x = 0; const audio = this.audio; const channelCount = audio?.channelCount ?? 1; - const height = this.config.waveHeight / channelCount; + const height = this.config.waveHeight; const scrollLeftPx = context.scrollLeftPx; const dataLength = context.dataLength; this.lastWaveformRenderedScrollLeftPx = scrollLeftPx; diff --git a/web/libs/editor/src/lib/AudioUltra/Visual/Visualizer.ts b/web/libs/editor/src/lib/AudioUltra/Visual/Visualizer.ts index 0f29611bfda8..fa50ea24de55 100644 --- a/web/libs/editor/src/lib/AudioUltra/Visual/Visualizer.ts +++ b/web/libs/editor/src/lib/AudioUltra/Visual/Visualizer.ts @@ -154,7 +154,7 @@ export class Visualizer extends Events { backgroundLayer, config: { renderId: this.renderId, - waveHeight: this.waveHeight, + waveHeight: this.waveformHeight, padding: this.padding, reservedSpace: this.reservedSpace, waveColor: this.waveColor, @@ -1092,14 +1092,13 @@ export class Visualizer extends Events { if (!spectrogramLayer?.isVisible) return 0; const channelCount = this.audio?.channelCount ?? 1; - const totalAvailableHeight = this.waveHeight; if (this.splitChannels) { // Each channel gets an equal split of the spectrogram area - return totalAvailableHeight / channelCount; + return this.waveHeight / channelCount; } // Spectrogram uses the full height when not split - return totalAvailableHeight; + return this.waveHeight; } setAmp(amp: number) { From 7b338bb503910cfe8c668e2d3568ec1c413e1f1c Mon Sep 17 00:00:00 2001 From: bmartel Date: Mon, 23 Jun 2025 21:47:31 +0000 Subject: [PATCH 2/3] Sync Follow Merge dependencies Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/15835814289 From f7b91e6451620f63984e0e1dbf2a6c0594606dd5 Mon Sep 17 00:00:00 2001 From: bmartel Date: Tue, 24 Jun 2025 12:55:54 +0000 Subject: [PATCH 3/3] Sync Follow Merge dependencies Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/15850965763