Skip to content

fix: LEAP-1449: Don't highlight instructions button #6522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

hlomzik
Copy link
Collaborator

@hlomzik hlomzik commented Oct 15, 2024

Instructions button had a weird styling in some conditions.

Screenshot 2024-10-15 at 22 31 01

When you open editor and instructions are displayed ahead — the button becames primary and primary style for icon buttons should definitely be improved.

But if you open instructions modal during your work the style is good, because Actions don't use observer(), so changes in store don't affect it.

Also couple of files connected to buttons usage in different streams are removed as not used.

PR fulfills these requirements

  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Does this PR introduce a breaking change?

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

Primary for icon buttons is too much.
Why here? Toolbar was using instructions but apparently is not used anymore.
LabelButtons are just sitting nearby, also not used.
@github-actions github-actions bot added the fix label Oct 15, 2024
Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit f027ea3
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/670ec03093f802000820ecc0
😎 Deploy Preview https://deploy-preview-6522--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit f027ea3
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/670ec030eab7750008844cd5
😎 Deploy Preview https://deploy-preview-6522--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hlomzik hlomzik merged commit 88aba0c into develop Oct 21, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants