Skip to content

ci: enable some rules in biome #6128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 25, 2024
Merged

Conversation

luarmr
Copy link
Contributor

@luarmr luarmr commented Jul 24, 2024

We re-enabled some biome rules that were previously disabled in our codebase. We made minimal changes to the code, focusing mainly on switch statements.
Each rule is enabled in a separate commit. Reviewing commit by commit is recommended.

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

We aim to remove the exclusion in our biome.json file.

What does this fix?

Refactoring some code

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

Will run selenium in LSE

@github-actions github-actions bot added the ci label Jul 24, 2024
Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit bc15761
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/66a134d3f69f4e0008300e06

Copy link

netlify bot commented Jul 24, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit bc15761
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/66a134d31a0480000800de80

@luarmr luarmr requested a review from hlomzik July 24, 2024 17:08
@luarmr luarmr enabled auto-merge (squash) July 25, 2024 06:28
@luarmr luarmr merged commit b1fff98 into develop Jul 25, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants