From c29c668f9b0464dd196c252aeb8f92bd9c22096a Mon Sep 17 00:00:00 2001 From: Woen-Sug Choi Date: Fri, 2 Jun 2023 13:24:53 +0900 Subject: [PATCH 01/15] add internal graphics option and unrecognized opt --- run.bash | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/run.bash b/run.bash index 039c036..dd2d7c5 100755 --- a/run.bash +++ b/run.bash @@ -32,9 +32,10 @@ Help() # Display Help echo "Runs a docker container with the image created by build.bash." echo - echo "Syntax: scriptTemplate [-c|s|t|h]" + echo "Syntax: scriptTemplate [-c|i|s|t|h]" echo "options:" echo "c Add cuda library support." + echo "i With internal graphics card (without nvidia)" echo "s Create an image with novnc for use with cloudsim." echo "t Create a test image for use with CI pipelines." echo "x Create base image for the VRX competition server." @@ -47,10 +48,12 @@ JOY=/dev/input/js0 CUDA="" ROCKER_ARGS="--devices $JOY --dev-helpers --nvidia --x11 --user --home --git" -while getopts ":cstxh" option; do +while getopts ":cstxhi" option; do case $option in c) # enable cuda library support CUDA="--cuda ";; + i) # With internal graphics card (without nvidia) + ROCKER_ARGS="--devices /dev/dri $JOY --dev-helpers --x11 --user --home --git";; s) # Build cloudsim image ROCKER_ARGS="--nvidia --novnc --turbovnc --user --user-override-name=developer";; t) # Build test image for Continuous Integration @@ -62,6 +65,9 @@ while getopts ":cstxh" option; do h) # print this help message and exit Help exit;; + \?) # handle unrecognized options + echo "Invalid option: -$OPTARG" >&2 + exit 1;; esac done From b4669950f15b158b1e64f45c3ab91c9c40af7eb3 Mon Sep 17 00:00:00 2001 From: Woensug Choi Date: Tue, 6 Jun 2023 10:29:19 +0900 Subject: [PATCH 02/15] Add colcon --- noetic/Dockerfile | 1 + 1 file changed, 1 insertion(+) diff --git a/noetic/Dockerfile b/noetic/Dockerfile index 7ebb32a..4ba80a3 100644 --- a/noetic/Dockerfile +++ b/noetic/Dockerfile @@ -57,6 +57,7 @@ RUN /bin/sh -c 'echo "deb http://packages.ros.org/ros/ubuntu ${RELEASE} main" > python3-rosinstall \ python3-rosinstall-generator \ python3-vcstool \ + python3-colcon-common-extensions \ ros-${DIST}-gazebo-plugins \ ros-${DIST}-gazebo-ros \ ros-${DIST}-gazebo-ros-control \ From dff6ad3767858a54f1fd384b71db24f0144aa9ac Mon Sep 17 00:00:00 2001 From: Rakesh Vivekanandan Date: Fri, 31 May 2024 02:06:22 -0700 Subject: [PATCH 03/15] added dockerfile for ROS2 Jazzy --- README.md | 5 ++- jazzy/Dockerfile | 102 +++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 105 insertions(+), 2 deletions(-) create mode 100644 jazzy/Dockerfile diff --git a/README.md b/README.md index 890125c..e8f8af1 100644 --- a/README.md +++ b/README.md @@ -4,6 +4,7 @@ Docker images used across multiple repositories supporting simulation of water-r ## Distributions This repository supports baseline images for running Gazebo on the following ROS distributions: +* Jazzy (Ubuntu 24.04 Noble Numbat / ROS 2 Jazzy Jalisco / Gazebo Harmonic) * Humble (Ubuntu 22.04 Jammy Jellyfish / ROS 2 Humble Hawksbill / Gazebo Garden) * Galactic (Ubuntu 20.04 Focal Fossa / ROS 2 Galactic Geochelone / Ignition Fortress) * Noetic (Ubuntu 20.04 Focal Fossa / ROS Noetic Ninjemys / Gazebo 11) @@ -14,9 +15,9 @@ This repository supports baseline images for running Gazebo on the following ROS The latest images corresponding to each of the three distributions above are stored in the [`npslearninglab/watery_robots` repository on Dockerhub](https://hub.docker.com/r/npslearninglab/watery_robots). ## Build Instructions -Build the base image with the `build.bash` script. +Build the base image with the `build.bash` script. ``` -DIST=(noetic | melodic | kinetic) +DIST=(jazzy | humble | galactic | noetic | melodic | kinetic) ./build.bash ${DIST} ``` Run the image locally using the `run.bash` script: diff --git a/jazzy/Dockerfile b/jazzy/Dockerfile new file mode 100644 index 0000000..95905fc --- /dev/null +++ b/jazzy/Dockerfile @@ -0,0 +1,102 @@ +# Ubuntu 24.04 +FROM ros:jazzy-ros-base-noble + +ENV DEBIAN_FRONTEND=noninteractive + +# Setup timezone +ENV TZ=Etc/UTC +RUN echo $TZ > /etc/timezone && \ + ln -fs /usr/share/zoneinfo/$TZ /etc/localtime + +# Tools necessary and useful during development +RUN apt-get -q update \ + && apt-get -q -y upgrade \ + && apt-get -q install --no-install-recommends -y \ + build-essential \ + atop \ + ca-certificates \ + cmake \ + cppcheck \ + curl \ + expect \ + gdb \ + git \ + gnupg2 \ + gnutls-bin \ + iputils-ping \ + libbluetooth-dev \ + libccd-dev \ + libcwiid-dev \ + libeigen3-dev \ + libfcl-dev \ + libgflags-dev \ + libgles2-mesa-dev \ + libgoogle-glog-dev \ + libspnav-dev \ + libusb-dev \ + lsb-release \ + net-tools \ + pkg-config \ + protobuf-compiler \ + python3-dbg \ + python3-empy \ + python3-numpy \ + python3-setuptools \ + python3-pip \ + python3-venv \ + ruby \ + software-properties-common \ + sudo \ + vim \ + wget \ + xvfb \ + && apt clean -qq + +# Setup locale +RUN sudo apt update && sudo apt install locales \ + && sudo locale-gen en_US en_US.UTF-8 \ + && sudo update-locale LC_ALL=en_US.UTF-8 LANG=en_US.UTF-8 \ + && export LANG=en_US.UTF-8 + +ARG ROSDIST=jazzy +ARG GZDIST=harmonic +ENV GZ_VERSION harmonic + +# Install Gazebo and ROS2 Desktop +RUN sudo wget https://packages.osrfoundation.org/gazebo.gpg -O /usr/share/keyrings/pkgs-osrf-archive-keyring.gpg \ + && echo "deb [arch=$(dpkg --print-architecture) signed-by=/usr/share/keyrings/pkgs-osrf-archive-keyring.gpg] http://packages.osrfoundation.org/gazebo/ubuntu-stable $(lsb_release -cs) main" | sudo tee /etc/apt/sources.list.d/gazebo-stable.list > /dev/null \ + && sudo apt-get -q update \ + && sudo apt-get -y --quiet --no-install-recommends install \ + gz-${GZDIST} \ + ros-${ROSDIST}-desktop \ + && sudo apt-get autoremove -y \ + && sudo apt-get clean -y \ + && sudo rm -rf /var/lib/apt/lists/* + +# Install some 'standard' ROS packages and utilities. +RUN sudo sh -c 'echo "deb http://packages.osrfoundation.org/gazebo/ubuntu-stable `lsb_release -cs` main" > /etc/apt/sources.list.d/gazebo-stable.list' \ + && wget http://packages.osrfoundation.org/gazebo.key -O - | sudo apt-key add - \ + && sudo apt-get -q update \ + && sudo apt-get -q -y upgrade \ + && sudo apt-get -q install --no-install-recommends -y \ + libsdformat14 \ + python3-colcon-common-extensions \ + python3-vcstool \ + ros-${ROSDIST}-actuator-msgs \ + ros-${ROSDIST}-ament-cmake-pycodestyle \ + ros-${ROSDIST}-image-transport \ + ros-${ROSDIST}-image-transport-plugins \ + ros-${ROSDIST}-joy-teleop \ + ros-${ROSDIST}-joy-linux \ + ros-${ROSDIST}-mavros-msgs \ + ros-${ROSDIST}-radar-msgs \ + ros-${ROSDIST}-ros-gz \ + ros-${ROSDIST}-rqt-graph \ + ros-${ROSDIST}-rqt-image-view \ + ros-${ROSDIST}-rqt-plot \ + ros-${ROSDIST}-rqt-topic \ + ros-${ROSDIST}-rviz2 \ + ros-${ROSDIST}-xacro \ + && sudo apt-get autoremove -y \ + && sudo apt-get clean -y \ + && sudo rm -rf /var/lib/apt/lists/* From 0b415312a4b14486c160993c0af4d1b720f6b393 Mon Sep 17 00:00:00 2001 From: Woen-Sug Choi Date: Thu, 6 Jun 2024 01:17:05 +0900 Subject: [PATCH 04/15] support apple silicon with rdp --- run.bash | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/run.bash b/run.bash index fe3bd45..866481f 100755 --- a/run.bash +++ b/run.bash @@ -32,10 +32,11 @@ Help() # Display Help echo "Runs a docker container with the image created by build.bash." echo - echo "Syntax: scriptTemplate [-c|i|s|t|h]" + echo "Syntax: scriptTemplate [-c|i|r|s|t|h]" echo "options:" echo "c Add cuda library support." echo "i With internal graphics card (without nvidia)" + echo "r With internal graphics card (without nvidia) and with RDP. default user is docker" echo "s Create an image with novnc for use with cloudsim." echo "t Create a test image for use with CI pipelines." echo "x Create base image for the VRX competition server." @@ -48,12 +49,15 @@ JOY=/dev/input/js0 CUDA="" ROCKER_ARGS="--devices $JOY --dev-helpers --nvidia --x11 --user --home --git" -while getopts ":cstxhi" option; do +while getopts ":cstxhir" option; do case $option in c) # enable cuda library support CUDA="--cuda ";; i) # With internal graphics card (without nvidia) ROCKER_ARGS="--devices /dev/dri $JOY --dev-helpers --x11 --user --home --git";; + r) # With internal graphics card (without nvidia) and with RDP default user is docker + # shellcheck disable=SC2116 + ROCKER_ARGS="--devices /dev/dri $JOY --dev-helpers --x11 --git --home --port 3389:3389 --volume $(echo ~):/home/docker/HOST";; s) # Build cloudsim image ROCKER_ARGS="--nvidia --novnc --turbovnc --user --user-override-name=developer";; t) # Build test image for Continuous Integration From 75cd42483ce7094b690dc7e5906512f8bea40a5b Mon Sep 17 00:00:00 2001 From: Woen-Sug Choi Date: Thu, 27 Jun 2024 08:01:04 +0900 Subject: [PATCH 05/15] remove dev helpers for faster run --- run.bash | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/run.bash b/run.bash index 866481f..0edbd32 100755 --- a/run.bash +++ b/run.bash @@ -54,10 +54,10 @@ while getopts ":cstxhir" option; do c) # enable cuda library support CUDA="--cuda ";; i) # With internal graphics card (without nvidia) - ROCKER_ARGS="--devices /dev/dri $JOY --dev-helpers --x11 --user --home --git";; + ROCKER_ARGS="--devices /dev/dri $JOY --x11 --user --home --git";; r) # With internal graphics card (without nvidia) and with RDP default user is docker # shellcheck disable=SC2116 - ROCKER_ARGS="--devices /dev/dri $JOY --dev-helpers --x11 --git --home --port 3389:3389 --volume $(echo ~):/home/docker/HOST";; + ROCKER_ARGS="--devices /dev/dri $JOY --x11 --git --home --port 3389:3389 --volume $(echo ~):/home/docker/HOST";; s) # Build cloudsim image ROCKER_ARGS="--nvidia --novnc --turbovnc --user --user-override-name=developer";; t) # Build test image for Continuous Integration From fe710fd9b83075cfea7f468b77062aef51467b3e Mon Sep 17 00:00:00 2001 From: Woen-Sug Choi Date: Wed, 18 Sep 2024 15:55:50 +0900 Subject: [PATCH 06/15] don't mount home itself but as HOST on docker user --- run.bash | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/run.bash b/run.bash index 0edbd32..bbccd61 100755 --- a/run.bash +++ b/run.bash @@ -47,17 +47,17 @@ Help() JOY=/dev/input/js0 CUDA="" -ROCKER_ARGS="--devices $JOY --dev-helpers --nvidia --x11 --user --home --git" +ROCKER_ARGS="--devices $JOY --dev-helpers --nvidia --x11 --user --git --volume $(echo ~):/home/docker/HOST" while getopts ":cstxhir" option; do case $option in c) # enable cuda library support - CUDA="--cuda ";; + CUDA="--cuda --volume $(echo ~):/home/docker/HOST";; i) # With internal graphics card (without nvidia) - ROCKER_ARGS="--devices /dev/dri $JOY --x11 --user --home --git";; + ROCKER_ARGS="--devices /dev/dri $JOY --x11 --user --git --volume $(echo ~):/home/docker/HOST";; r) # With internal graphics card (without nvidia) and with RDP default user is docker # shellcheck disable=SC2116 - ROCKER_ARGS="--devices /dev/dri $JOY --x11 --git --home --port 3389:3389 --volume $(echo ~):/home/docker/HOST";; + ROCKER_ARGS="--devices /dev/dri $JOY --x11 --git --port 3389:3389 --volume $(echo ~):/home/docker/HOST";; s) # Build cloudsim image ROCKER_ARGS="--nvidia --novnc --turbovnc --user --user-override-name=developer";; t) # Build test image for Continuous Integration From 86873362bc898dedbb9f185ba6f0e5bda31b5491 Mon Sep 17 00:00:00 2001 From: Woen-Sug Choi Date: Wed, 18 Sep 2024 17:20:45 +0900 Subject: [PATCH 07/15] update --- run.bash | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/run.bash b/run.bash index bbccd61..d84162a 100755 --- a/run.bash +++ b/run.bash @@ -47,14 +47,14 @@ Help() JOY=/dev/input/js0 CUDA="" -ROCKER_ARGS="--devices $JOY --dev-helpers --nvidia --x11 --user --git --volume $(echo ~):/home/docker/HOST" +ROCKER_ARGS="--devices /dev/dri $JOY --dev-helpers --nvidia --x11 --git --volume $(echo ~):/docker/HOST" while getopts ":cstxhir" option; do case $option in c) # enable cuda library support - CUDA="--cuda --volume $(echo ~):/home/docker/HOST";; + CUDA="--cuda";; i) # With internal graphics card (without nvidia) - ROCKER_ARGS="--devices /dev/dri $JOY --x11 --user --git --volume $(echo ~):/home/docker/HOST";; + ROCKER_ARGS="--devices /dev/dri $JOY --x11 --git --volume $(echo ~):/docker/HOST";; r) # With internal graphics card (without nvidia) and with RDP default user is docker # shellcheck disable=SC2116 ROCKER_ARGS="--devices /dev/dri $JOY --x11 --git --port 3389:3389 --volume $(echo ~):/home/docker/HOST";; From 55d3517c2fd3ede915f0d95aeec7a2c1521f2fde Mon Sep 17 00:00:00 2001 From: GauravKumar9920 Date: Fri, 20 Jun 2025 13:29:25 +0530 Subject: [PATCH 08/15] fixed the typo and added a new argument -P --- run.bash | 39 ++++++++++++++++++++++----------------- 1 file changed, 22 insertions(+), 17 deletions(-) diff --git a/run.bash b/run.bash index d84162a..317132d 100755 --- a/run.bash +++ b/run.bash @@ -29,35 +29,38 @@ ############################################################ Help() { - # Display Help - echo "Runs a docker container with the image created by build.bash." - echo - echo "Syntax: scriptTemplate [-c|i|r|s|t|h]" - echo "options:" - echo "c Add cuda library support." - echo "i With internal graphics card (without nvidia)" - echo "r With internal graphics card (without nvidia) and with RDP. default user is docker" - echo "s Create an image with novnc for use with cloudsim." - echo "t Create a test image for use with CI pipelines." - echo "x Create base image for the VRX competition server." - echo "h Print this help message and exit." - echo + # Display Help + echo "Runs a docker container with the image created by build.bash." + echo + echo "Syntax: scriptTemplate [-c|i|r|s|t|h|P]" + echo "options:" + echo "c Add cuda library support." + echo "i With internal graphics card (without nvidia)" + echo "r With internal graphics card (without nvidia) and with RDP. default user is docker (host port $HOST_RDP_PORT)" + echo "s Create an image with novnc for use with cloudsim." + echo "t Create a test image for use with CI pipelines." + echo "x Create base image for the VRX competition server." + echo "h Print this help message and exit." + echo "P Override host RDP port (usage: -P )." + + echo } JOY=/dev/input/js0 CUDA="" -ROCKER_ARGS="--devices /dev/dri $JOY --dev-helpers --nvidia --x11 --git --volume $(echo ~):/docker/HOST" +HOST_RDP_PORT=3389 +ROCKER_ARGS="--devices /dev/dri $JOY --dev-helpers --nvidia --x11 --git --volume $(echo ~):/home/docker/HOST" -while getopts ":cstxhir" option; do +while getopts ":cstxhirP:" option; do case $option in c) # enable cuda library support CUDA="--cuda";; i) # With internal graphics card (without nvidia) - ROCKER_ARGS="--devices /dev/dri $JOY --x11 --git --volume $(echo ~):/docker/HOST";; + ROCKER_ARGS="--devices /dev/dri $JOY --x11 --git --volume $(echo ~):/home/docker/HOST";; r) # With internal graphics card (without nvidia) and with RDP default user is docker # shellcheck disable=SC2116 - ROCKER_ARGS="--devices /dev/dri $JOY --x11 --git --port 3389:3389 --volume $(echo ~):/home/docker/HOST";; + ROCKER_ARGS="--devices /dev/dri $JOY --x11 --git --port "$HOST_RDP_PORT":3389 --volume $(echo ~):/home/docker/HOST";; s) # Build cloudsim image ROCKER_ARGS="--nvidia --novnc --turbovnc --user --user-override-name=developer";; t) # Build test image for Continuous Integration @@ -69,6 +72,8 @@ while getopts ":cstxhir" option; do h) # print this help message and exit Help exit;; + P) # Override host RDP port + HOST_RDP_PORT=$OPTARG;; \?) # handle unrecognized options echo "Invalid option: -$OPTARG" >&2 exit 1;; From 5a3ea95e73f5a8fe3a1dcc109a6e77cfa6465de4 Mon Sep 17 00:00:00 2001 From: GauravKumar9920 Date: Fri, 20 Jun 2025 15:45:11 +0530 Subject: [PATCH 09/15] changed echo -> Home for better understanding of the code --- run.bash | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/run.bash b/run.bash index 317132d..9b80eb9 100755 --- a/run.bash +++ b/run.bash @@ -50,17 +50,17 @@ Help() JOY=/dev/input/js0 CUDA="" HOST_RDP_PORT=3389 -ROCKER_ARGS="--devices /dev/dri $JOY --dev-helpers --nvidia --x11 --git --volume $(echo ~):/home/docker/HOST" +ROCKER_ARGS="--devices /dev/dri $JOY --dev-helpers --nvidia --x11 --git --volume "$HOME":/home/docker/HOST" while getopts ":cstxhirP:" option; do case $option in c) # enable cuda library support CUDA="--cuda";; i) # With internal graphics card (without nvidia) - ROCKER_ARGS="--devices /dev/dri $JOY --x11 --git --volume $(echo ~):/home/docker/HOST";; + ROCKER_ARGS="--devices /dev/dri $JOY --x11 --git --volume "$HOME":/home/docker/HOST";; r) # With internal graphics card (without nvidia) and with RDP default user is docker # shellcheck disable=SC2116 - ROCKER_ARGS="--devices /dev/dri $JOY --x11 --git --port "$HOST_RDP_PORT":3389 --volume $(echo ~):/home/docker/HOST";; + ROCKER_ARGS="--devices /dev/dri $JOY --x11 --git --port "$HOST_RDP_PORT":3389 --volume "$HOME":/home/docker/HOST";; s) # Build cloudsim image ROCKER_ARGS="--nvidia --novnc --turbovnc --user --user-override-name=developer";; t) # Build test image for Continuous Integration @@ -88,4 +88,4 @@ CONTAINER_NAME="$(tr ':' '_' <<< "$IMG_NAME")_runtime" ROCKER_ARGS="${ROCKER_ARGS} --name $CONTAINER_NAME" echo "Using image <$IMG_NAME> to start container <$CONTAINER_NAME>" -rocker ${CUDA} ${ROCKER_ARGS} $IMG_NAME +rocker ${CUDA} ${ROCKER_ARGS} $IMG_NAME \ No newline at end of file From 108252f610fca92288ab27ffba2cef4704e92663 Mon Sep 17 00:00:00 2001 From: Woen-Sug Choi Date: Mon, 7 Jul 2025 08:25:50 +0900 Subject: [PATCH 10/15] for non RDP(Macbook), the docker user is root. --- run.bash | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/run.bash b/run.bash index 9b80eb9..17fdf31 100755 --- a/run.bash +++ b/run.bash @@ -50,14 +50,14 @@ Help() JOY=/dev/input/js0 CUDA="" HOST_RDP_PORT=3389 -ROCKER_ARGS="--devices /dev/dri $JOY --dev-helpers --nvidia --x11 --git --volume "$HOME":/home/docker/HOST" +ROCKER_ARGS="--devices /dev/dri $JOY --dev-helpers --nvidia --x11 --git --volume "$HOME":/root/HOST" while getopts ":cstxhirP:" option; do case $option in c) # enable cuda library support CUDA="--cuda";; i) # With internal graphics card (without nvidia) - ROCKER_ARGS="--devices /dev/dri $JOY --x11 --git --volume "$HOME":/home/docker/HOST";; + ROCKER_ARGS="--devices /dev/dri $JOY --x11 --git --volume "$HOME":/root/HOST";; r) # With internal graphics card (without nvidia) and with RDP default user is docker # shellcheck disable=SC2116 ROCKER_ARGS="--devices /dev/dri $JOY --x11 --git --port "$HOST_RDP_PORT":3389 --volume "$HOME":/home/docker/HOST";; From 17206580ed299fb2ffb83f9d6113fce8a3e4c921 Mon Sep 17 00:00:00 2001 From: GauravKumar9920 Date: Thu, 10 Jul 2025 15:41:40 +0530 Subject: [PATCH 11/15] made recommended changes --- run.bash | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/run.bash b/run.bash index 17fdf31..8b85957 100755 --- a/run.bash +++ b/run.bash @@ -32,16 +32,16 @@ Help() # Display Help echo "Runs a docker container with the image created by build.bash." echo - echo "Syntax: scriptTemplate [-c|i|r|s|t|h|P]" + echo "Syntax: $(basename $0) [-P ] [-c|i|r|s|t|h] " echo "options:" echo "c Add cuda library support." echo "i With internal graphics card (without nvidia)" + echo "p Override host RDP port (follow syntax for usage, only affects -r option)" echo "r With internal graphics card (without nvidia) and with RDP. default user is docker (host port $HOST_RDP_PORT)" echo "s Create an image with novnc for use with cloudsim." echo "t Create a test image for use with CI pipelines." echo "x Create base image for the VRX competition server." echo "h Print this help message and exit." - echo "P Override host RDP port (usage: -P )." echo } @@ -52,7 +52,7 @@ CUDA="" HOST_RDP_PORT=3389 ROCKER_ARGS="--devices /dev/dri $JOY --dev-helpers --nvidia --x11 --git --volume "$HOME":/root/HOST" -while getopts ":cstxhirP:" option; do +while getopts ":cstxhirp:" option; do case $option in c) # enable cuda library support CUDA="--cuda";; @@ -72,8 +72,11 @@ while getopts ":cstxhirP:" option; do h) # print this help message and exit Help exit;; - P) # Override host RDP port - HOST_RDP_PORT=$OPTARG;; + p) # Override host RDP port + HOST_RDP_PORT=$OPTARG;; + :) #handle missing arguments + echo "Error: Option -$OPTARG requires an argument." >&2 + exit 1;; \?) # handle unrecognized options echo "Invalid option: -$OPTARG" >&2 exit 1;; From 07cf778aff5f73256ac6a96a8897384d301a555d Mon Sep 17 00:00:00 2001 From: GauravKumar9920 Date: Thu, 10 Jul 2025 15:53:08 +0530 Subject: [PATCH 12/15] typo fix --- run.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/run.bash b/run.bash index 8b85957..ffb913c 100755 --- a/run.bash +++ b/run.bash @@ -32,7 +32,7 @@ Help() # Display Help echo "Runs a docker container with the image created by build.bash." echo - echo "Syntax: $(basename $0) [-P ] [-c|i|r|s|t|h] " + echo "Syntax: $(basename $0) [-p ] [-c|i|r|s|t|h] " echo "options:" echo "c Add cuda library support." echo "i With internal graphics card (without nvidia)" From 6fbdef4e34b6c9778fed9ce832c13164f77c7cba Mon Sep 17 00:00:00 2001 From: GauravKumar9920 Date: Thu, 10 Jul 2025 15:56:08 +0530 Subject: [PATCH 13/15] minor change --- run.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/run.bash b/run.bash index ffb913c..a2673c7 100755 --- a/run.bash +++ b/run.bash @@ -34,10 +34,10 @@ Help() echo echo "Syntax: $(basename $0) [-p ] [-c|i|r|s|t|h] " echo "options:" + echo "r With internal graphics card (without nvidia) and with RDP. default user is docker (host port $HOST_RDP_PORT)" echo "c Add cuda library support." echo "i With internal graphics card (without nvidia)" echo "p Override host RDP port (follow syntax for usage, only affects -r option)" - echo "r With internal graphics card (without nvidia) and with RDP. default user is docker (host port $HOST_RDP_PORT)" echo "s Create an image with novnc for use with cloudsim." echo "t Create a test image for use with CI pipelines." echo "x Create base image for the VRX competition server." From 408eef587ca0be96f8f155fa20e25a7508ae125b Mon Sep 17 00:00:00 2001 From: GauravKumar9920 Date: Mon, 14 Jul 2025 10:57:09 +0530 Subject: [PATCH 14/15] updated the comment --- run.bash | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/run.bash b/run.bash index a2673c7..d156a16 100755 --- a/run.bash +++ b/run.bash @@ -58,7 +58,8 @@ while getopts ":cstxhirp:" option; do CUDA="--cuda";; i) # With internal graphics card (without nvidia) ROCKER_ARGS="--devices /dev/dri $JOY --x11 --git --volume "$HOME":/root/HOST";; - r) # With internal graphics card (without nvidia) and with RDP default user is docker + r) # With internal graphics card (without nvidia) and with RDP. + # The default user in container is 'docker' due to RDP constraints (custom host port can be set via the -p option) # shellcheck disable=SC2116 ROCKER_ARGS="--devices /dev/dri $JOY --x11 --git --port "$HOST_RDP_PORT":3389 --volume "$HOME":/home/docker/HOST";; s) # Build cloudsim image From 944c6883692f1dfa993fd7b93713312c5521492c Mon Sep 17 00:00:00 2001 From: GauravKumar9920 Date: Mon, 14 Jul 2025 14:49:01 +0530 Subject: [PATCH 15/15] minor changes --- run.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/run.bash b/run.bash index d156a16..fff98b3 100755 --- a/run.bash +++ b/run.bash @@ -34,7 +34,7 @@ Help() echo echo "Syntax: $(basename $0) [-p ] [-c|i|r|s|t|h] " echo "options:" - echo "r With internal graphics card (without nvidia) and with RDP. default user is docker (host port $HOST_RDP_PORT)" + echo "r With internal graphics card (without nvidia) and with RDP. The default user in container is 'docker' due to RDP constraints (custom host port can be set via the -p option)" echo "c Add cuda library support." echo "i With internal graphics card (without nvidia)" echo "p Override host RDP port (follow syntax for usage, only affects -r option)"