Skip to content

Commit 2233c14

Browse files
committed
fix: improve workflows
1 parent 7757037 commit 2233c14

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

.github/pull_request_template.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,11 @@
77

88
---
99

10-
<!-- Please make sure you're satisfy and fill the following checkboxes -->
10+
<!-- Please make sure you're satisfied and fill in the following checkboxes -->
1111
<!-- A good PR should include the following parts: -->
1212

1313
- [ ] A clear title (name your PR "[LAB{lab_number}] {your_student_id}")
1414
- [ ] A meaningful message for PR, as well as its commits
1515
- [ ] From your specific branch (***not main or other's branch***) merging to your branch
1616
- [ ] Excluding any irrelevant files, such as binaries, text files, or dot files
17-
- [ ] Passing all CI
17+
- [ ] Passing all CI (You should check it first to pass one of the validations in CI. However, you need to make sure your PR passes all CI after you submit it.)

.github/workflows/PR.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
const pr = await github.rest.pulls.get({ owner, repo, pull_number: issue_number });
1717
const title = pr.data.title;
1818
const labRegex = /\[LAB(\d+)\]/;
19-
const titleRegex = /\[LAB\d+\] [\da-zA-Z]+/;
19+
const titleRegex = /^\[LAB\d+\] [\da-zA-Z]+$/;
2020
2121
if (!titleRegex.test(title)) {
2222
core.setFailed('PR title does not match the required format. Please use the format [LAB#] student#.');

.github/workflows/lab1.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,5 @@ jobs:
2222
sudo apt-get install -y nodejs
2323
- name: grading
2424
run: |
25-
echo "cd lab1"
2625
cd lab1
2726
./validate.sh

0 commit comments

Comments
 (0)