ignore errors for false positive for php8

roberto-butti · roberto-butti · commit 9aae655c53cf · 2021-10-19T22:55:58.000+02:00
diff --git a/app/Objects/WorkflowGenerator.php b/app/Objects/WorkflowGenerator.php
@@ -73,7 +73,6 @@ function ($str) {
     public static function split($somethingToSplit, string $splitChars = ",")
     {
         if (\is_string($somethingToSplit)) {
-            // @phpstan-ignore-next-line
             return array_map('trim', explode($splitChars, $somethingToSplit));
         }
         return $somethingToSplit;
diff --git a/composer.json b/composer.json
@@ -36,6 +36,7 @@
         "mockery/mockery": "^1.4.4",
         "nunomaduro/collision": "^5.10",
         "nunomaduro/larastan": "^0.7.2",
+        "phpstan/phpstan": "^0.12.99",
         "phpunit/phpunit": "^9.5.8",
         "psalm/plugin-laravel": "^1.4",
         "squizlabs/php_codesniffer": "^3.6",
diff --git a/composer.lock b/composer.lock
diff --git a/phpstan.neon b/phpstan.neon
@@ -2,6 +2,9 @@ includes:
     - ./vendor/nunomaduro/larastan/extension.neon
 parameters:
     reportUnmatchedIgnoredErrors: false
+    ignoreErrors:
+        - '#Parameter .1 \$separator of function explode expects non-empty-string, string given.#'
+
     level: 6
     paths:
         - app

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,6 @@ function ($str) {`
`73`	`73`	`public static function split($somethingToSplit, string $splitChars = ",")`
`74`	`74`	`{`
`75`	`75`	`if (\is_string($somethingToSplit)) {`
`76`		`- // @phpstan-ignore-next-line`
`77`	`76`	`return array_map('trim', explode($splitChars, $somethingToSplit));`
`78`	`77`	`}`
`79`	`78`	`return $somethingToSplit;`